Received-SPF: pass (google.com: domain of linux-kernel+bounces-88011-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <1aa8e326-2bec-4324-a767-29e34b0e103d@amd.com>
Date: Fri, 1 Mar 2024 08:30:05 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] clk: zynq: Prevent null pointer dereference caused by
 kmalloc failure
Content-Language: en-US
To: duoming@zju.edu.cn
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-clk@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org
References: <20240301070336.13700-1-duoming@zju.edu.cn>
 <d9b6d49e-9485-4733-a2d6-615bcc8f6ef3@amd.com>
 <74fd8b9e.6331.18df8e68c36.Coremail.duoming@zju.edu.cn>
From: Michal Simek <michal.simek@amd.com>
Autocrypt: addr=michal.simek@amd.com; keydata=
 xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc
 howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy
 svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF
 Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj
 SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5
 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255
 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8
 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa
 XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c
 a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzSlNaWNoYWwgU2lt
 ZWsgKEFNRCkgPG1pY2hhbC5zaW1la0BhbWQuY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI
 CwIEFgIDAQIeAQIXgBYhBGc1DJv1zO6bU2Q1ajd8fyH+PR+RBQJkK9VOBQkWf4AXAAoJEDd8
 fyH+PR+ROzEP/1IFM7J4Y58SKuvdWDddIvc7JXcal5DpUtMdpuV+ZiHSOgBQRqvwH4CVBK7p
 ktDCWQAoWCg0KhdGyBjfyVVpm+Gw4DkZovcvMGUlvY5p5w8XxTE5Xx+cj/iDnj83+gy+0Oyz
 VFU9pew9rnT5YjSRFNOmL2dsorxoT1DWuasDUyitGy9iBegj7vtyAsvEObbGiFcKYSjvurkm
 MaJ/AwuJehZouKVfWPY/i4UNsDVbQP6iwO8jgPy3pwjt4ztZrl3qs1gV1F4Zrak1k6qoDP5h
 19Q5XBVtq4VSS4uLKjofVxrw0J+sHHeTNa3Qgk9nXJEvH2s2JpX82an7U6ccJSdNLYbogQAS
 BW60bxq6hWEY/afbT+tepEsXepa0y04NjFccFsbECQ4DA3cdA34sFGupUy5h5la/eEf3/8Kd
 BYcDd+aoxWliMVmL3DudM0Fuj9Hqt7JJAaA0Kt3pwJYwzecl/noK7kFhWiKcJULXEbi3Yf/Y
 pwCf691kBfrbbP9uDmgm4ZbWIT5WUptt3ziYOWx9SSvaZP5MExlXF4z+/KfZAeJBpZ95Gwm+
 FD8WKYjJChMtTfd1VjC4oyFLDUMTvYq77ABkPeKB/WmiAoqMbGx+xQWxW113wZikDy+6WoCS
 MPXfgMPWpkIUnvTIpF+m1Nyerqf71fiA1W8l0oFmtCF5oTMkzsFNBFFuvDEBEACXqiX5h4IA
 03fJOwh+82aQWeHVAEDpjDzK5hSSJZDE55KP8br1FZrgrjvQ9Ma7thSu1mbr+ydeIqoO1/iM
 fZA+DDPpvo6kscjep11bNhVa0JpHhwnMfHNTSHDMq9OXL9ZZpku/+OXtapISzIH336p4ZUUB
 5asad8Ux70g4gmI92eLWBzFFdlyR4g1Vis511Nn481lsDO9LZhKyWelbif7FKKv4p3FRPSbB
 vEgh71V3NDCPlJJoiHiYaS8IN3uasV/S1+cxVbwz2WcUEZCpeHcY2qsQAEqp4GM7PF2G6gtz
 IOBUMk7fjku1mzlx4zP7uj87LGJTOAxQUJ1HHlx3Li+xu2oF9Vv101/fsCmptAAUMo7KiJgP
 Lu8TsP1migoOoSbGUMR0jQpUcKF2L2jaNVS6updvNjbRmFojK2y6A/Bc6WAKhtdv8/e0/Zby
 iVA7/EN5phZ1GugMJxOLHJ1eqw7DQ5CHcSQ5bOx0Yjmhg4PT6pbW3mB1w+ClAnxhAbyMsfBn
 XxvvcjWIPnBVlB2Z0YH/gizMDdM0Sa/HIz+q7JR7XkGL4MYeAM15m6O7hkCJcoFV7LMzkNKk
 OiCZ3E0JYDsMXvmh3S4EVWAG+buA+9beElCmXDcXPI4PinMPqpwmLNcEhPVMQfvAYRqQp2fg
 1vTEyK58Ms+0a9L1k5MvvbFg9QARAQABwsF8BBgBCAAmAhsMFiEEZzUMm/XM7ptTZDVqN3x/
 If49H5EFAmQr1YsFCRZ/gFoACgkQN3x/If49H5H6BQ//TqDpfCh7Fa5v227mDISwU1VgOPFK
 eo/+4fF/KNtAtU/VYmBrwT/N6clBxjJYY1i60ekFfAEsCb+vAr1W9geYYpuA+lgR3/BOkHlJ
 eHf4Ez3D71GnqROIXsObFSFfZWGEgBtHBZ694hKwFmIVCg+lqeMV9nPQKlvfx2n+/lDkspGi
 epDwFUdfJLHOYxFZMQsFtKJX4fBiY85/U4X2xSp02DxQZj/N2lc9OFrKmFJHXJi9vQCkJdIj
 S6nuJlvWj/MZKud5QhlfZQsixT9wCeOa6Vgcd4vCzZuptx8gY9FDgb27RQxh/b1ZHalO1h3z
 kXyouA6Kf54Tv6ab7M/fhNqznnmSvWvQ4EWeh8gddpzHKk8ixw9INBWkGXzqSPOztlJbFiQ3
 YPi6o9Pw/IxdQJ9UZ8eCjvIMpXb4q9cZpRLT/BkD4ttpNxma1CUVljkF4DuGydxbQNvJFBK8
 ywyA0qgv+Mu+4r/Z2iQzoOgE1SymrNSDyC7u0RzmSnyqaQnZ3uj7OzRkq0fMmMbbrIvQYDS/
 y7RkYPOpmElF2pwWI/SXKOgMUgigedGCl1QRUio7iifBmXHkRrTgNT0PWQmeGsWTmfRit2+i
 l2dpB2lxha72cQ6MTEmL65HaoeANhtfO1se2R9dej57g+urO9V2v/UglZG1wsyaP/vOrgs+3
 3i3l5DA=
In-Reply-To: <74fd8b9e.6331.18df8e68c36.Coremail.duoming@zju.edu.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?emhhb3pqOTV5dzRleW1sd2xubUdiTThSallxa2Y2MXhoRmV5eVVuYXFiT1JW?=
 =?utf-8?B?NWlxNVNDV2xnSGJBKzE1MUNuQzBHZVdUZnIvWHAwNFk3RVhXdExRbXFRWlFO?=
 =?utf-8?B?WXNzZGp0aEkyOW5wRS9Eb0VRU3BKeW4reWZkN0NmV0h2OFIwMzNCTEVHUm1s?=
 =?utf-8?B?bmtUZVpoNFFlMWJiZVliVkRTc0NVVXRjZjFsWDRkL3lzWEk0bTNqTjlGYWRy?=
 =?utf-8?B?SHNYMkFvZkRMdDJyZlZCbVdOSmRhdkxmNDdETThLOUk5cmZORWFPTTRGcEc4?=
 =?utf-8?B?V1VWaG1xVnhMQjBva1FHVjNqVHd5WTllVUVBblNXUFZoT2srcXQvRFdGWWMy?=
 =?utf-8?B?RDVGSjEwd05qZncvV3BLUDFBb3lMUCtpRHZLUlZDcGlndXZUQlgrNGoxUGVI?=
 =?utf-8?B?YkhxSFpKYUc3eElhNEp5N0NFODV0UVZwRGN1akMzSVhuZWozWEsxMzFTdWRx?=
 =?utf-8?B?cmVKTTA0UEJYd3ErNkVoR25sSEFmalNWQTVud3pheWJ5alB1bUt4NmFJN2J5?=
 =?utf-8?B?bU1pWGpSSElRaGhqVmZXbkdpQkVZbnYwcDMyZTVlTllJbzl2dFYvOThWUm41?=
 =?utf-8?B?T0JObHFlaVhsWnNFM3BoaUtrclBHVnJCRkVodnNIWjlmRTV4QnprSUN1NGo3?=
 =?utf-8?B?WjdHeHlwWDF5d2VMdUhJVHYxZjlkVUI2VDBLRGlWRGFsSEZJQ2pOcmV3Rktt?=
 =?utf-8?B?K1B3SUZ2SzJBcTI5S0dSMmgzKzZpaVIyeUZHZXhGektzQkZOaWtCTDZMUzMz?=
 =?utf-8?B?VlpyVU1KNTMvcmN4bUZkVkdXTkJYZHMwdWtLaDd6NGVkNzFWZEx4REt4cTda?=
 =?utf-8?B?Y3RPemRBN1NhUWRPeC9VMkl5WkR2U3dkS3FiT2p0eE56N1k5d3VPVWVCU1Zs?=
 =?utf-8?B?eTNDWkt4UTdpV1JtWlF5SGpGMDcvVmtnVGI0YUF3Q0VPY0hCWU95QWJiSjVp?=
 =?utf-8?B?eVh4V3IyWlM5ek0yTGhSWjUyU1haUklQYnYrTENXbytMeEJ4VDlmcFMyaHJv?=
 =?utf-8?B?a2o5RkpWVkRhd3UvT1ZvNGs5b2h1Q1U5cDhlSXc0WFM4NGdIVDlpUnNCS2tV?=
 =?utf-8?B?OTZrYjd1K0gzd0tUSVBNYTRONjVqR3ZxSkQrOVFVZzZnT21pUUMyTFhKaEVU?=
 =?utf-8?B?MU1VTXNVWlJSaTdCeUdJakcvUUcvUStydC9zeUR2eDhDQ0EyZVZNeEJEZ3VJ?=
 =?utf-8?B?aGJiSFluTkhwMTJpRzRZbEcxVjdoNWE0dmk0bGlHcnV6NnI2TDJ4NVFKZXE5?=
 =?utf-8?B?TS85aERCYWIrellSVlRLRCtpMG91MVZJak9MalZhdCtqcmdCOHc3aDN6aU9t?=
 =?utf-8?B?YzNoWUtDMzRTeWgya3ZIRDc4dVhULzZra21UMmxVelhjS0ZuSlhYZkhRbzlS?=
 =?utf-8?B?dktkMjZEaW1SOGozYnZZcjZlQVFnWlMvRzYzNEpVOUR4N1E2VmlCZmhIRkhG?=
 =?utf-8?B?VWNuN3pEUWJDaWtCMmorWkxsR0JwMitxak93U0x2UjlWTFNqYnUwY2RxcUlR?=
 =?utf-8?B?bVNXaCtPY1A4UmtpMzdPd3kzbE5lbnFVTml1bHVMYzVMWGJqMmNvMk96QlV6?=
 =?utf-8?B?TmVFeFBrbSt6ZE1lLzE3cDlUTU1SWDJZd24xOUsrUXI1MjRRR0crM1VoQXBM?=
 =?utf-8?B?ZDE0aU4wcDVlYWcyRjMyTVVFL2ZlZlVtUXNubWZBYXZRaVhTK3dFVEdhY3Zw?=
 =?utf-8?B?MXBqYkxnYWFzZkYvMDhRUjNhZ0dPVTdqeGhUbGJaaVEzVWV0aVI1bnNiYWFs?=
 =?utf-8?B?VWIyaUVIVnEyQ29aWi9IaE9RdHFOdVpvSENvblZRZG84ZWJFZk1wNEhaaDh5?=
 =?utf-8?B?dGlqaGlNcWVUbzB3eVhtYngrUEE2eGNmK0xBZDhmeTZLNmlTanJCZTNNOGZm?=
 =?utf-8?B?V0NSOW9yWkdqcmdDSVYvTFV3MWZJLzJ5bXd6WE9vRzlYUDhPU2s3UFI3V04x?=
 =?utf-8?B?TjFZazNLTnZXVmwyQ0FPaHZTMGFCZzV3SXJuTkNoOGFvOVVQWnEvWXpudEZq?=
 =?utf-8?B?VkNRdVFxTlJJTEtoWjZIellhVXpoQWlaWWlwbFFhZ0Q0anNQRXZMM3pyOXYw?=
 =?utf-8?B?ekcyUTl5UmRENlcyUU85cGNkM0d2QWFMaXFiN1IxRlBMZUxOR25xWXkvSG4v?=
 =?utf-8?Q?EXqTr+LfGo7EKPYNd8Yssudr6?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0ae84b7-ba06-4eac-00b2-08dc39c170b4
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 07:30:16.5666
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5hgtoMoThu5jQWGT+ocPx8Bk4B4ukcucdkUl2INn/MhmHD2F/m+Qf5/DL0vN9xNi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7234


On 3/1/24 08:24, duoming@zju.edu.cn wrote:
> On Fri, 1 Mar 2024 08:05:17 +0100 Michal Simek wrote:
>>> The kmalloc() in zynq_clk_setup() will return null if the
>>> physical memory has run out. As a result, if we use snprintf()
>>> to write data to the null address, the null pointer dereference
>>> bug will happen.
>>>
>>> This patch uses a stack variable to replace the kmalloc().
>>>
>>> Fixes: 0ee52b157b8e ("clk: zynq: Add clock controller driver")
>>> Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
>>> ---
>>> Changes in v3:
>>>     - Put stack variable in the head of the function and remove variable tmp.
>>>
>>>    drivers/clk/zynq/clkc.c | 7 ++-----
>>>    1 file changed, 2 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/clk/zynq/clkc.c b/drivers/clk/zynq/clkc.c
>>> index 7bdeaff2bfd..45479653c3b 100644
>>> --- a/drivers/clk/zynq/clkc.c
>>> +++ b/drivers/clk/zynq/clkc.c
>>> @@ -215,7 +215,7 @@ static void __init zynq_clk_setup(struct device_node *np)
>>>    	int i;
>>>    	u32 tmp;
>>>    	int ret;
>>> -	char *clk_name;
>>> +	char clk_name[16];
>>>    	unsigned int fclk_enable = 0;
>>>    	const char *clk_output_name[clk_max];
>>>    	const char *cpu_parents[4];
>>> @@ -426,12 +426,10 @@ static void __init zynq_clk_setup(struct device_node *np)
>>>    			"gem1_emio_mux", CLK_SET_RATE_PARENT,
>>>    			SLCR_GEM1_CLK_CTRL, 0, 0, &gem1clk_lock);
>>>    
>>> -	tmp = strlen("mio_clk_00x");
>>> -	clk_name = kmalloc(tmp, GFP_KERNEL);
>>>    	for (i = 0; i < NUM_MIO_PINS; i++) {
>>>    		int idx;
>>>    
>>> -		snprintf(clk_name, tmp, "mio_clk_%2.2d", i);
>>> +		snprintf(clk_name, 16, "mio_clk_%2.2d", i);
>>
>> I would prefer to use macro/define if that values has to match and have connection.
> 
> The origin code "clk_name = kmalloc(tmp, GFP_KERNEL)" allocates 16 bytes, so I set
> the size of stack variable clk_name to 16 bytes.
> 
> Do you think if we use "#define CLK_NAME_LEN 16" is better?

name is fine for me. What macro gives you is that you know that number 16 from 
array size is the same number 16 which you are checking.
It is clear from your patch but some time from now someone can change just one 
part of code without looking at connection.

M