Received-SPF: pass (google.com: domain of linux-kernel+bounces-88047-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 1 Mar 2024 15:36:33 +0800
From: Yan Zhao <yan.y.zhao@intel.com>
To: Sagi Shahar <sagis@google.com>
CC: <linux-kselftest@vger.kernel.org>, Ackerley Tng <ackerleytng@google.com>,
	Ryan Afranji <afranji@google.com>, Erdem Aktas <erdemaktas@google.com>, Isaku
 Yamahata <isaku.yamahata@intel.com>, Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Shuah Khan <shuah@kernel.org>, Peter
 Gonda <pgonda@google.com>, Haibo Xu <haibo1.xu@intel.com>, Chao Peng
	<chao.p.peng@linux.intel.com>, "Vishal Annapurve" <vannapurve@google.com>,
	Roger Wang <runanwang@google.com>, "Vipin Sharma" <vipinsh@google.com>,
	<jmattson@google.com>, <dmatlack@google.com>, <linux-kernel@vger.kernel.org>,
	<kvm@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [RFC PATCH v5 08/29] KVM: selftests: TDX: Add TDX lifecycle test
Message-ID: <ZeGFgQQU2WL7PUO9@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20231212204647.2170650-1-sagis@google.com>
 <20231212204647.2170650-9-sagis@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231212204647.2170650-9-sagis@google.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oPzGd1vgagoMWFlqMUhlGCoV1dxc5RGoPQXkSLjud+Qo+/YYc7ZG2IUgsBzv?=
 =?us-ascii?Q?iWgEGXBzc8hSYkn3GzyGT9Y4ClYHARHbjwmrGeZJ1aV/nHjBw5+ItqbAHG3d?=
 =?us-ascii?Q?Cy1nHSEzxRF2fOr8WFv8GSpKPSDHcow9rulc3kG/lCL+eIHv+irhIV52khzh?=
 =?us-ascii?Q?7A0p7Vj15VelaEC7Mk1Ku7Trsa/+QhJt/ywEbdqDBmrYZvd2EZEHKJZBi8XF?=
 =?us-ascii?Q?aY1rrewjz5UGZTuptRXJZhFGPjojjOrkRlr2+GG54vi/WY8qYJ3JmayedI+o?=
 =?us-ascii?Q?2A5CTbPqMmfDYdAUFlj0vKY8IUnmn7174vXwfCoXr8n7AwzOl8klVYmH6XIT?=
 =?us-ascii?Q?AqAgost1S4l0YjLwXp08o6s1vdvG74y9EGX13/C1QDPEeBCYu1ZK0T/Wfgqr?=
 =?us-ascii?Q?QlT+Tkl6QNCIrv+Sdkxnu1aNV8xjNIuX/qS9t+7undPs/MYVnT+dntwh76Cv?=
 =?us-ascii?Q?2E1JhLpI8uzrlGqTkVQpimK8S5HMwqDJn7z5J8Ur34EXslU60Vz6OSyAN5Ig?=
 =?us-ascii?Q?2YfHtwNXqYkd42AsLTc4r4i+WFMKjkzEy3j2B/QxLI2ItL4L0mTsuzrDUztL?=
 =?us-ascii?Q?jSPxbaK9UVShYgR/jJb2ARlySLQB/4nIkoaaRIvv1x7336VFpwakdXt7Qju1?=
 =?us-ascii?Q?cnrpM6SINxxDVjveU128kukxu1rmHRFU3jTfE8wp2rQaYRzwLE0GduCq6eBl?=
 =?us-ascii?Q?5mmJU1ecP0xnDt/4gX/qgC1UWnjfHt9V52uQevGl4Lh4CAzaHWG+C6rlRZZc?=
 =?us-ascii?Q?tbKDdH4A6wqTBoRpwQLqmJ2OpJuHlNlkynvnImaUIXVoWRQGq5EE6/TqnsRq?=
 =?us-ascii?Q?9FR06AVmhED4AzmG3ns6jJjH3a6freRt2bRTAD3P/lxBG25fRthklcYnOwJ0?=
 =?us-ascii?Q?BTEtb4lRtFgnol9VHrvJ57dw+cyrmfkPMjby4OK6KvPlozchC5bydufqKLIl?=
 =?us-ascii?Q?QgfB2/F/hEUMYT+OAYUPzt6onzMFKp/Lx7q/WPgiPcFNLyUd+zgN1in/kOep?=
 =?us-ascii?Q?mY5gOUph2XDBEcm6zLqY0P4YCqPf8hFCiPAvfCX+zE0/0PJqh7ZoUqhCyQN3?=
 =?us-ascii?Q?FGA9jFngRenq8L5fuu0WkB8gbdTQg3ze6A7jbqikSZ0ddRL+34y/e1Lfm9or?=
 =?us-ascii?Q?DKue48k8SdK64qj7WTOH7r7nAhmhr5/NUcpKQ7Afo1fu9PEXjneEV0VIPZgo?=
 =?us-ascii?Q?lsd2++byBJB+9i0nfpUycFFSCMG/s9rKC2y5wqmtfsAsAFOwsl0anRXD5fPS?=
 =?us-ascii?Q?BjcAllGMKGSIAxQoB1/98dGbEf8mwkJsEMTaTcu5ybF1/ds4mwoGqDDdZ5zi?=
 =?us-ascii?Q?rt0I1tgK5n2lttFe2MHmVvzdKEMJDBbfGXRdXvo95/5ZbPTsPoXy5hmhvcvY?=
 =?us-ascii?Q?GG9+H7xvuHTKsdlI8nx9JrUQKfByhOxU+0Pl/Ujb6f2Dv7QSlZC2yLnhzIYq?=
 =?us-ascii?Q?gRQcFUd22129VYitm+d4gEWrqA2MO1pIQIMkPvgNv6wF45QhLPmxgKC2Xqfe?=
 =?us-ascii?Q?bGl/4ySrs/Wlz5grqa0JCVznqSGhY2YulhbQUfRSMFQ97BjUp9FXjJwrKoUc?=
 =?us-ascii?Q?TsErHQJWtObNHaeVCn/JVkwY38bwjxxYsagOICqu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b9ebe84e-d5dd-447e-a89b-08dc39c67bbe
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 08:06:22.5436
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QVN5UuCp2RUjdUpUD3un8gCT4VQgMhJWKFi9k1rzc9dQLtFOwT0fLwOyQyF/95vtZdj2KSmM5LO15glTb2zqTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4546
X-OriginatorOrg: intel.com

> diff --git a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx_util.c b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx_util.c
> index 063ff486fb86..b302060049d5 100644
> --- a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx_util.c
> +++ b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx_util.c
> @@ -224,6 +224,7 @@ static void tdx_enable_capabilities(struct kvm_vm *vm)
>  		      KVM_X2APIC_API_USE_32BIT_IDS |
>  			      KVM_X2APIC_API_DISABLE_BROADCAST_QUIRK);
>  	vm_enable_cap(vm, KVM_CAP_SPLIT_IRQCHIP, 24);
> +	vm_enable_cap(vm, KVM_CAP_MAX_VCPUS, 512);

This is not a must for TD life cycle?
Though I know, currently, the selftest will fail without setting this
line, due to TD's default max vcpu count is -1.
But I guess it's an error.
https://lore.kernel.org/all/ZeGC64sAzg4EN3G5@yzhao56-desk.sh.intel.com/