Received-SPF: pass (google.com: domain of linux-kernel+bounces-88059-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <4a0e5f42-ec5a-48d2-8887-d14a019a054a@intel.com>
Date: Fri, 1 Mar 2024 09:17:41 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 1/2] net: phy: micrel: lan8814 led errata
To: Horatiu Vultur <horatiu.vultur@microchip.com>, <andrew@lunn.ch>,
	<hkallweit1@gmail.com>, <linux@armlinux.org.uk>, <davem@davemloft.net>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<UNGLinuxDriver@microchip.com>
References: <20240229195220.2673049-1-horatiu.vultur@microchip.com>
 <20240229195220.2673049-2-horatiu.vultur@microchip.com>
Content-Language: en-US
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20240229195220.2673049-2-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2Qza1RUYzc1ZXM3ZnI0RjhoelVzQ1Q3Nm1XZlM3Ulo1akpJd3huVUFMREZp?=
 =?utf-8?B?NEg1U2ZGM2hxQkV0aXNRT2FQNEhtek4xYlV1VlVpZ3BJRmFGZXM1Tys5NVJ0?=
 =?utf-8?B?d2FEaU5PZ2RGK0lDYi9RUDIrQ1hIMVZIUHZhbkpNbHBpYTlQY1Y3Wks2KzJ3?=
 =?utf-8?B?NUsxaGVsZU9EU1BYc0xRbGVZMzFIWnBZMHRsR3V1dGd3cGJwQWFEOS9iUEpG?=
 =?utf-8?B?TGVqbThtRCtKQjB2QzlqcExaNEF1bHFad0RZbnFRSjlleWxnSTkwNXpxSCto?=
 =?utf-8?B?c21tZGlRZHZsRi8vS1FxSnNHVlYwbnVLTXplMzFPS3owcUtqR2pRUm5YRnpQ?=
 =?utf-8?B?VFhMNVd2b3RoZVZOWEc4YllnMzdPSzUyMUxXL0M1eHRGQ0hLaHBITjdzbU96?=
 =?utf-8?B?YS9rdTZBRWNyM2QwYXZQS25BcUNVMEJydk05WUlmRDROQkhLM1lHM1lrdDE3?=
 =?utf-8?B?WDBOaG9NcDdTNFdwUWF1UGNHbWtxY0duZFJLcW5xbzFrMlQyUGFoK3JneEtS?=
 =?utf-8?B?c01KUTUxbHVQd1d6azE1QjVyc1RwOVMrK3VsemJXS0pFcnhGT3o5R2dONWhh?=
 =?utf-8?B?eUMwVktYOEY0aHpNUWlWU01uUmRlVWJmTWt5Z0lsZm1UK1hGdjBaZUZ4OCtt?=
 =?utf-8?B?UVZja2ErV2FjV0hCOFdQTkxYc2ZTcXVqdTVYNnVJWHNEY015RGFMVFdSNEw2?=
 =?utf-8?B?N2hWMzVZcnp0bUw4a21mU1RDY0lHWjRSRkJlaDhhbGpKK0RaN0c0T1IzdGNP?=
 =?utf-8?B?bmVyU3BLN1owcDlleWl3ZXR6N2lZUkZJTXdPVmZsK014akNtcTUzOG5BZXJw?=
 =?utf-8?B?K1VmdkdnK0lFZEk2LzB2VTlvVVhiREx1ZkFxVXd6aTZ5ZE1WQmNaTnZ2L254?=
 =?utf-8?B?LzJLamVsR3BlZVJuQUJvRkhHRVJNaFlpUkRkem5UWGRtQXNXWnMvUzRBQW15?=
 =?utf-8?B?Wi9qbExTQWd2ZDlWemJIa2V0SjBIVUpQano4QmE5Y0pndXczSDAwN210NUth?=
 =?utf-8?B?ZTY2SW50MHRNMkN4NUh1VkZ6VW05WHBPWVZob0tlblN0SVg0YjZYcHVOYkFx?=
 =?utf-8?B?OGkxcWJuUXJ0SDRzbGRRalMvN1MvZ3BmYnhqTHJBc2VBSmYvTVk0aC9IUWlC?=
 =?utf-8?B?dys3aUJtRXVVUzdWeS9WRlEwOUkrNk9UMkt6RXp2NHBrK3VXVCtXdit2NDgz?=
 =?utf-8?B?QSt4eG5yaFNlZDNPT3gvTFVYNmRFRHBxZEZQbzN0cDhNVUhycGp4S0trRmNq?=
 =?utf-8?B?Z2YweUJOeTRBOEQ0Qis2QXVDY2xlRVl5RDhUUXVrN0dlcHNhSk5MN0RJSlpK?=
 =?utf-8?B?R2w3R3M3cHR1MGx5ekhIUXRqeTByMVJoNGUyUldFdVk4KzB4Mjg4RHNhcyt4?=
 =?utf-8?B?Q2dib2RRYk1XUDY5eU5pTkwyTWZua0t5bWJNRDhsNjM1T1FHTkpJMkYrczg0?=
 =?utf-8?B?WUxLc1JFaU02RS9LRlpTNExSRFZqeGdta2RrTlplVzhjRTZqR3pXV2QraFhl?=
 =?utf-8?B?bXppektUUVB3ME5LbGgvNDk1UWxKNlA1VzYxVm1lQlFLVzlHYUMweDl0VCtM?=
 =?utf-8?B?QmZQRWhNZEVSRHdtWml4Ym5IcjY5NzdlZG5USEQxSkFtYkp3cTE0RGNZSEJP?=
 =?utf-8?B?azRWU1BtUlIxL3dUR3hSa3J2ZDZ1MUh0bWtQZnpFNmh6R0thRjNRUHpnUlp5?=
 =?utf-8?B?U0M4MFFFeUJSSnQ0QTBtK3B0aktJZnFHK0tGdzhpTk5nN004SGVGa2RkTy9D?=
 =?utf-8?B?R0g2SEZsMHJPSVlhNkVNazJkOEVRd3RYc2VxaTNFUkVDd2d5Q3VsdjBYVmsr?=
 =?utf-8?B?T1lzOUtKMXlQSVRYN1R1N0JYOEptTXN1QXE4RGxjUm1RRXB3Y0p6ME5veExM?=
 =?utf-8?B?SWd6VUlTYWh5dkRldm0yQ3ljbUplYW92Vm5OVy9tTWI1QzdxRTRsc3FrOTVp?=
 =?utf-8?B?aVROUWM1N0g5b3R1Z25uVTZuaUQ3eHo0ZWtDY2ZuQVhJckROZytoL0p0VUFE?=
 =?utf-8?B?dnVZRW9ScWREd21jakJnU1VCb1Qrc0JPaEFFTXRrVWp4d2ZHWE1MdDdJRy9Z?=
 =?utf-8?B?MWZXMEZ0dHFUdk1GdjJKTHVVaEQySmUzM2ZKNk9OME1lYTFUTjlISDE3OWVx?=
 =?utf-8?B?cUI4R3ZQRjFZSVZCVnpuUEoyeG5kWlpHZzdjZTAxMWFRb3NldFFGNit1cmxF?=
 =?utf-8?B?N1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d3bcdb25-23cb-46f1-7feb-08dc39c813bb
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 08:17:46.9353
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nWEm9iHwNI2K38SYWJpNjrkVDP2x5QMipd91DJixccA4OD43CdetgcxjVwenbKqNkOeVBxZpYhY3F2JJuiNNDX2YoyffjuRbj267eDM7Cio=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8575
X-OriginatorOrg: intel.com


On 29.02.2024 20:52, Horatiu Vultur wrote:
> Lan8814 phy led behavior is not correct. It was noticed that the led
> still remains ON when the cable is unplugged while there was traffic
> passing at that time.
> 
> The fix consists in clearing bit 10 of register 0x38, in this way the
> led behaviour is correct and gets OFF when there is no link.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---

Thank you!
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  drivers/net/phy/micrel.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 9b69735819896..88cc03982bb78 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -114,6 +114,9 @@
>  #define LAN8814_INTR_CTRL_REG_POLARITY		BIT(1)
>  #define LAN8814_INTR_CTRL_REG_INTR_ENABLE	BIT(0)
>  
> +#define LAN8814_EEE_STATE			0x38
> +#define LAN8814_EEE_STATE_MASK2P5P		BIT(10)
> +
>  /* Represents 1ppm adjustment in 2^32 format with
>   * each nsec contains 4 clock cycles.
>   * The value is calculated as following: (1/1000000)/((2^-32)/4)
> @@ -3288,6 +3291,19 @@ static int lan8814_release_coma_mode(struct phy_device *phydev)
>  	return 0;
>  }
>  
> +static void lan8814_clear_2psp_bit(struct phy_device *phydev)
> +{
> +	u16 val;
> +
> +	/* It was noticed that when traffic is passing through the PHY and the
> +	 * cable is removed then the LED was still one even though there is no
> +	 * link
> +	 */
> +	val = lanphy_read_page_reg(phydev, 2, LAN8814_EEE_STATE);
> +	val &= ~LAN8814_EEE_STATE_MASK2P5P;
> +	lanphy_write_page_reg(phydev, 2, LAN8814_EEE_STATE, val);
> +}
> +
>  static int lan8814_probe(struct phy_device *phydev)
>  {
>  	const struct kszphy_type *type = phydev->drv->driver_data;
> @@ -3324,6 +3340,9 @@ static int lan8814_probe(struct phy_device *phydev)
>  
>  	lan8814_ptp_init(phydev);
>  
> +	/* Errata workarounds */
> +	lan8814_clear_2psp_bit(phydev);
> +
>  	return 0;
>  }
>