Received-SPF: pass (google.com: domain of linux-kernel+bounces-88061-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <97713349-723b-4ce1-bc12-2557086cef2e@intel.com>
Date: Fri, 1 Mar 2024 09:18:23 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 2/2] net: phy: micrel: lan8814 cable
 improvement errata
Content-Language: en-US
To: Horatiu Vultur <horatiu.vultur@microchip.com>, <andrew@lunn.ch>,
	<hkallweit1@gmail.com>, <linux@armlinux.org.uk>, <davem@davemloft.net>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<UNGLinuxDriver@microchip.com>
References: <20240229195220.2673049-1-horatiu.vultur@microchip.com>
 <20240229195220.2673049-3-horatiu.vultur@microchip.com>
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20240229195220.2673049-3-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2tXWkl2Ny9wdkhYMEJPM3AweG5ZWmYxK3Rudm1GTGgwUU5pZTNORzlGY3JO?=
 =?utf-8?B?cDBhN0pXVjQyOEM5NGdhSlpFdFc3SVgybytGUFd4KzdrcXZUd3kvZDZxTU43?=
 =?utf-8?B?R1F2dGN4Skl1aW9zV2Y4OWlzNkUrS1hxMkg3bk02QlJGN3M5aVRRdWswcTdO?=
 =?utf-8?B?STJnbVJnL3piRUdpWjMyR3FvUGFTUkx6RCtnSkYxVzNJQlVYL1lxNk1xUHFJ?=
 =?utf-8?B?MktmS0wybFVTUTdZMnNNeUM4N2h6Ti9aVXp5cmZRSDgzZUpnZ0w3NUVpYjl1?=
 =?utf-8?B?NWlwWVVuN3kyLzJYS1hBbHNFU3hjaFdqVDMvZ0xNUEVtSUhMUjMwOTZ1b29k?=
 =?utf-8?B?NStLZnFzcFh5TlBVSVZaL21KblIwRzJnT1JEeVlOZmhaSVloSTdtaElHS2hr?=
 =?utf-8?B?SDR6RTNCUDhmdEszTU1hZUkrZ1JuRmhuemVoWHRleG5CcitSR0FCaTdwNUZh?=
 =?utf-8?B?RG5KQnZVY3p2cjd6dkpGVXdBeXFOQ1NpclRiVHFzYys2ZnFVZ2VocHpEU3Fj?=
 =?utf-8?B?OFBucHVLUnpIdXMrZ0M3d3k0Tm5NNmdrWHRCQWVFZ2J1RFhUbXNhK3VkU1A2?=
 =?utf-8?B?RVBKaUJaUXJDUzdPTGJvdTJYaEt0M09ldjFWdEtZWGxJVXZmNUxFQkpoSGov?=
 =?utf-8?B?VWZteUl0NGlEUXNDcTR3blJRdWhhQ3pVUjhQcVUwL3BpaHp0MCszQmY1WWRQ?=
 =?utf-8?B?bmlkUVJoMWxnKzBKYy9QU3FqSUZoWVp0WUVQaGF3eWdGZUY0anp5b2Y1YmMv?=
 =?utf-8?B?bU8xd3lNWGU4c29ncVcySUU0RlkrRVJ4cXZXdEJNN3JWUUVBUHFDaU1RaVM0?=
 =?utf-8?B?RVE4Z0VWVDRvYWNDOGs5b2g0azRFRFFIT1h2YzcvZ2JLSlFEM2tJR0VSYUsr?=
 =?utf-8?B?cEh1Qk5IOUFpOUlSMUgzWEZiQ0QwcHhidjh1MytiNnVnZCtpNVg1NHJBN003?=
 =?utf-8?B?VmIwOWE4THVTeUp3bFAwd1djUm9leVVqZWNvRTV1U21GRTlCWHM5QVhWN3dI?=
 =?utf-8?B?Q2tGZEN0UGYxK3FMWER2ZkhWOFNXT0lwWkJJM0hJc3Bvd3llSVpCNDVHZFdz?=
 =?utf-8?B?ZmFTMk5XUE5aSm15d2FXcWdITkRCODVTYWtiMGxkTkRvYUYyOXBncnBOUmpB?=
 =?utf-8?B?dVhRcjYvU29zUUpWdzRNTE1UWW5ZWTd2eEdCaCs1SzE3V2M5YXFXQ2xmczdP?=
 =?utf-8?B?NG8zcExQOVFiTFd6bEZUekduUTBBWjdqaXFkZWovUTRHeXhiZXB6b2pWK3BO?=
 =?utf-8?B?MmJ1QnIxTnpkLzh3ZXZNQkpSWU0rR1VlM3AxZTYrMTVEZjNsZ3lYcXI5blMr?=
 =?utf-8?B?TlI5d20zLzEyTmZSYm5ZQnRZWGVwOS9TN0pob3VVaVJzajdWYWtJOWxSL0U0?=
 =?utf-8?B?TGs3b3IybWhoKzNVK2ExWi9XR3NYbTN1SXgreFdER1dpWTFOUU42Ly9XZUpy?=
 =?utf-8?B?UGYxclNYZFJtNFZyNGdoSDRsZjRsRkZVTmQ3bjNnS0plMVQzcndBNUZyRGFE?=
 =?utf-8?B?Y3VuWHNDOGd3TjZKckxGQm5LaGZUUkJoUlRXOTFXbncyMFpScHFleUxpSEhF?=
 =?utf-8?B?WUJnWFJIVmxLdDd0MllCVzJVSWtNUGp2OTRTS2lNTFpxN0MvYm5Uc1h4ZkNm?=
 =?utf-8?B?cGt4dVBiNkIyZTlpUUZpUVVJZVlJZklwZ29RMWw5ZGxZNVdNYjJUOS9zOEZM?=
 =?utf-8?B?TldIcWFiTGdlcFBEZjkzWDVXL0FMRmFtSHdzTGhqOHNvVSs5RkM2bGg2aHoz?=
 =?utf-8?B?MEJwZlBaaW1tck5tc1RoemRsRXBhK1AraVpWSmhncXJSM3d1Q1dhZThlV05W?=
 =?utf-8?B?OHprdkhBQ3B4blo3OTdidXRITVhSTkIrR2dDSWdhbnNEWXBlRGFGOXB5Skw4?=
 =?utf-8?B?ZzNqcDBMandwQnNlejhocGdKSXR4bUg2dGdDRE10c2lKTUtjV2F5YUs3REVB?=
 =?utf-8?B?dDJxRlBUWG55QXFTeTFUcnl5ZjBzaTBvQktPWDFxdW5URXQ2WFp2NEIzSG1x?=
 =?utf-8?B?cUpaODdEc1d3MDdjN0VPRlFyNUV5Z1FET0JaRDk2K2ZUM0UvYzhvalQrdVRo?=
 =?utf-8?B?YkJwU3JCclRjRXNpWm1ya3hGY1BCMGNvbFpvQ3kwSklubWNNbTI2clVwVVlJ?=
 =?utf-8?B?TTZkWkhSWkFwQ3JPeWVQNkZIR2M2RUhvcmF5Vm1aaTdYUU5UaDM1VlpRYzdM?=
 =?utf-8?B?Mnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 320b72c4-b20e-4343-828b-08dc39c82b1b
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 08:18:26.1528
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mo6X5TAUV4lUOHbOfEbO8vrLT5bnzOr+dOlZTRQtA9AqVUerItkeC8XblDiSkGepC141tws6Ye3vdF5FcyaUW5e21uaZPUxIud4wJctYO/4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8575
X-OriginatorOrg: intel.com


On 29.02.2024 20:52, Horatiu Vultur wrote:
> When the length of the cable is more than 100m and the lan8814 is
> configured to run in 1000Base-T Slave then the register of the device
> needs to be optimized.
> 
> Workaround this by setting the measure time to a value of 0xb. This
> value can be set regardless of the configuration.
> 
> This issue is described in 'LAN8814 Silicon Errata and Data Sheet
> Clarification' and according to that, this will not be corrected in a
> future silicon revision.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  drivers/net/phy/micrel.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 88cc03982bb78..788fdd54fd22d 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -117,6 +117,10 @@
>  #define LAN8814_EEE_STATE			0x38
>  #define LAN8814_EEE_STATE_MASK2P5P		BIT(10)
>  
> +#define LAN8814_PD_CONTROLS			0x9d
> +#define LAN8814_PD_CONTROLS_PD_MEAS_TIME_MASK_	GENMASK(3, 0)
> +#define LAN8814_PD_CONTROLS_PD_MEAS_TIME_VAL_	0xb
> +
>  /* Represents 1ppm adjustment in 2^32 format with
>   * each nsec contains 4 clock cycles.
>   * The value is calculated as following: (1/1000000)/((2^-32)/4)
> @@ -3304,6 +3308,20 @@ static void lan8814_clear_2psp_bit(struct phy_device *phydev)
>  	lanphy_write_page_reg(phydev, 2, LAN8814_EEE_STATE, val);
>  }
>  
> +static void lan8814_update_meas_time(struct phy_device *phydev)
> +{
> +	u16 val;
> +
> +	/* By setting the measure time to a value of 0xb this will allow cables
> +	 * longer than 100m to be used. This configuration can be used
> +	 * regardless of the mode of operation of the PHY
> +	 */
> +	val = lanphy_read_page_reg(phydev, 1, LAN8814_PD_CONTROLS);
> +	val &= ~LAN8814_PD_CONTROLS_PD_MEAS_TIME_MASK_;
> +	val |= LAN8814_PD_CONTROLS_PD_MEAS_TIME_VAL_;
> +	lanphy_write_page_reg(phydev, 1, LAN8814_PD_CONTROLS, val);
> +}
> +
>  static int lan8814_probe(struct phy_device *phydev)
>  {
>  	const struct kszphy_type *type = phydev->drv->driver_data;
> @@ -3342,6 +3360,7 @@ static int lan8814_probe(struct phy_device *phydev)
>  
>  	/* Errata workarounds */
>  	lan8814_clear_2psp_bit(phydev);
> +	lan8814_update_meas_time(phydev);
>  
>  	return 0;
>  }