Received-SPF: pass (google.com: domain of linux-kernel+bounces-88082-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com>
 <20240229-rk-dts-additions-v3-2-6afe8473a631@gmail.com> <823379825559bb76088c31f44f998dd3@manjaro.org>
 <CABjd4YybaQnKm+VpU_xVrCb=pxQ7oQXPHGZzn_u1w_h3yn7gwg@mail.gmail.com>
 <a8ebe39b28a34c3544481a4e43e61d2b@manjaro.org> <b16f1d40549554598a3658679ceba9bf@manjaro.org>
In-Reply-To: <b16f1d40549554598a3658679ceba9bf@manjaro.org>
From: Alexey Charkov <alchark@gmail.com>
Date: Fri, 1 Mar 2024 12:30:14 +0400
Message-ID: <CABjd4YwAq28C6gKTJKJdZQ_Fw1oEjR475oTS96xEXRj=XQ5_pg@mail.gmail.com>
Subject: Re: [PATCH v3 2/5] arm64: dts: rockchip: enable automatic active
 cooling on Rock 5B
To: Dragan Simic <dsimic@manjaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Heiko Stuebner <heiko@sntech.de>, Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Viresh Kumar <viresh.kumar@linaro.org>, Chen-Yu Tsai <wens@kernel.org>, devicetree@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 1, 2024 at 12:25=E2=80=AFPM Dragan Simic <dsimic@manjaro.org> w=
rote:
>
> On 2024-03-01 07:17, Dragan Simic wrote:
> > On 2024-03-01 06:21, Alexey Charkov wrote:
> >> On Fri, Mar 1, 2024 at 1:25=E2=80=AFAM Dragan Simic <dsimic@manjaro.or=
g>
> >> wrote:
> >>> On 2024-02-29 20:26, Alexey Charkov wrote:
> >>> > This links the PWM fan on Radxa Rock 5B as an active cooling device
> >>> > managed automatically by the thermal subsystem, with a target SoC
> >>> > temperature of 65C and a minimum-spin interval from 55C to 65C to
> >>> > ensure airflow when the system gets warm
> >>>
> >>> I'd suggest that you replace "automatic active cooling" with "active
> >>> cooling" in the patch subject.  I know, it may seem like more of the
> >>> unnecessary nitpicking, :) but I hope you'll agree that "automatic"
> >>> is actually redundant there.  It would also make the patch subject
> >>> a bit shorter.
> >>>
> >>> Another option would be to replace "automatic active cooling" with
> >>> "automatic fan control", which may actually be a better choice.
> >>> I'd be happy with whichever one you prefer. :)
> >>
> >> Sounds good to me, thanks!
> >
> > I'm glad that you like it. :)
> >
> >>> Otherwise, please feel free to add:
> >>>
> >>> Reviewed-by: Dragan Simic <dsimic@manjaro.org>
> >>
> >> Thank you Dragan, much appreciated!
> >
> > Thank you for putting up with my nitpicking. :)
>
> Perhaps the following tag would also be deserved for this patch:
>
> Helped-by: Dragan Simic <dsimic@manjaro.org>
>
> I hope you agree. :)

Definitely! Thanks again for your feedback and contribution!

Best regards,
Alexey