Received-SPF: pass (google.com: domain of linux-kernel+bounces-88184-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <d44ada61-8789-444c-9823-fc68704586bd@collabora.com>
Date: Fri, 1 Mar 2024 14:28:27 +0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>, ben@decadent.org.uk,
 shuah@kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] selftests/mm: Dont fail testsuite due to a lack of
 hugepages
Content-Language: en-US
To: Nico Pache <npache@redhat.com>, linux-mm@kvack.org,
 linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240301073300.287508-1-npache@redhat.com>
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <20240301073300.287508-1-npache@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 3/1/24 12:33 PM, Nico Pache wrote:
> On systems that have large core counts and large page sizes, but limited
> memory, the userfaultfd test hugepage requirement is too large.
> 
> Exiting early due to missing one test's requirements is a rather aggressive
> strategy, and prevents a lot of other tests from running. Remove the
> early exit to prevent this.
Why don't we only skip that particular test which requires huge number of
pages instead? Thus the behavior of this script would remain same.

> 
> Fixes: ee00479d6702 ("selftests: vm: Try harder to allocate huge pages")
> Signed-off-by: Nico Pache <npache@redhat.com>
> ---
>  tools/testing/selftests/mm/run_vmtests.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> index 246d53a5d7f28..727ea22ba408e 100755
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -173,7 +173,6 @@ if [ -n "$freepgs" ] && [ -n "$hpgsize_KB" ]; then
>  	if [ "$freepgs" -lt "$needpgs" ]; then
>  		printf "Not enough huge pages available (%d < %d)\n" \
>  		       "$freepgs" "$needpgs"
> -		exit 1
>  	fi
>  else
>  	echo "no hugetlbfs support in kernel?"

-- 
BR,
Muhammad Usama Anjum