Received-SPF: pass (google.com: domain of linux-kernel+bounces-88247-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <0f98e7de-4351-481f-86be-e573805c82f6@web.de>
Date: Fri, 1 Mar 2024 11:20:26 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org,
 Eugen Hristev <eugen.hristev@collabora.com>,
 Mauro Carvalho Chehab <mchehab@kernel.org>
Content-Language: en-GB
Cc: LKML <linux-kernel@vger.kernel.org>
From: Markus Elfring <Markus.Elfring@web.de>
Subject: [PATCH] media: microchip-csi2dc: Move a fwnode_handle_put() call into
 an if branch in csi2dc_of_parse()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:JrS5DAV2alI=;swQcZg+CJenRsuPdDlrFOqKYLWe
 IQwCC05aq9G3hpsqYg1nFlYiiWJdc327P0ltpu7CVeNMyBYP6wMEuqlyjot/z48qKJ7MRzw1W
 BjWo+4GGfwv59c7HlehR09jT0L5vmqv9dmIQVYIO5CjJa4zSOehu4c0FimLE9jAUFfPsbmJ1d
 SmfyTR8Ugpz57jm8hz9RXnN2/u8Xw3B4VCQIjREyP2RF8Xoi9NVLH8Mtp67jiUZNdt4NRV6jS
 sKLhsbXT+2e/oRsfsgf6R6d/47CjOY0oRmzKBXr+57t+XLYTlkTOq6Bdc3BFuhivPXN+sdHTA
 CmYnZn2vePUlSjAkWlnoJZhEEGb/RoV1JUPUfc5dPrYFYpNY1Y0KzCyHaSmYLC+uavyciMIDk
 vib/7NLq16AtuhPEGXgRZmNdpRbKl5xLaIuIFeSx/v7Wzm3jBnU1tXt/J4hrkhvo0WJYDl179
 LVvPh5jSSlxqfkNO383iVI9+7ivNvoewsf8/muQnrVxx99jMr7+oKiPoHmPSIWUY8RM0oR1WJ
 MUVNlxxnQVFcu/KWEv63IXdhZsuqmeANAdmvJd20R7ORTcQNVpryYA0a+MHOncLaNemdJBEAH
 VzpK8ZoIjVaWrWvuMfJjZDv6gYzmmfUxM7nfb0+PV1t1XXd9yHslBfVHQs+DJuTz3iLzV+D8c
 2QNpPR/HDxfH9Aeb7h3n4t/s4UKejBSohBENS23CeP37ONMYmUCwi6fofhFZxY6ovkBJzUojq
 13wgf6mxRHlYX7YdY1n8zdFSOj7Mgi42eM3BLNJxJEvYipT7EWqQrxCoINlBTkAE8Q+s5zicj
 VflXJolFyYv2rjf7xVTMs+TvO6KOTUTpzSDc655JLUHf8=

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 1 Mar 2024 11:11:44 +0100

Move a fwnode_handle_put() call into an if branch of this function
so that the control flow looks a bit safer directly.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--
 drivers/media/platform/microchip/microchip-csi2dc.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/microchip/microchip-csi2dc.c b/drivers=
/media/platform/microchip/microchip-csi2dc.c
index fee73260bb1e..ed800a3bb268 100644
=2D-- a/drivers/media/platform/microchip/microchip-csi2dc.c
+++ b/drivers/media/platform/microchip/microchip-csi2dc.c
@@ -595,12 +595,11 @@ static int csi2dc_of_parse(struct csi2dc_device *csi=
2dc,

 	output_fwnode =3D fwnode_graph_get_next_endpoint
 				(of_fwnode_handle(of_node), input_fwnode);
-
-	if (output_fwnode)
+	if (output_fwnode) {
 		ret =3D v4l2_fwnode_endpoint_parse(output_fwnode,
 						 &output_endpoint);
-
-	fwnode_handle_put(output_fwnode);
+		fwnode_handle_put(output_fwnode);
+	}

 	if (!output_fwnode || ret) {
 		dev_info(csi2dc->dev,
=2D-
2.44.0