Received-SPF: pass (google.com: domain of linux-kernel+bounces-88305-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <03bf515c-9f90-487c-ecfa-90d407dc5d86@ti.com>
Date: Fri, 1 Mar 2024 16:39:50 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH net RESEND] net: ethernet: ti: am65-cpsw: Add
 IFF_UNICAST_FLT flag to port device
Content-Language: en-US
To: Jakub Kicinski <kuba@kernel.org>,
        =?UTF-8?B?U2FuanXDoW4gR2FyY8OtYSwgSm9yZ2U=?= <Jorge.SanjuanGarcia@duagon.com>
CC: "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "s-vadapalli@ti.com" <s-vadapalli@ti.com>,
        "rogerq@kernel.org"
	<rogerq@kernel.org>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "olteanv@gmail.com"
	<olteanv@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ravi
 Gunasekaran <r-gunasekaran@ti.com>
References: <20240228111300.2516590-1-jorge.sanjuangarcia@duagon.com>
 <20240228200516.1166a097@kernel.org>
From: Ravi Gunasekaran <r-gunasekaran@ti.com>
In-Reply-To: <20240228200516.1166a097@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit


On 2/29/24 9:35 AM, Jakub Kicinski wrote:
> On Wed, 28 Feb 2024 11:13:23 +0000 Sanjuán García, Jorge wrote:
>> Since commit 8940e6b669ca ("net: dsa: avoid call to __dev_set_promiscuity()
>> while rtnl_mutex isn't held") when conecting one of this switch's port
>> to a DSA switch as the conduit interface, the network interface is set to
>> promiscuous mode by default and cannot be set to not promiscuous mode again
>> from userspace. The reason for this is that the cpsw ports net devices
>> do not have the flag IFF_UNICAST_FLT set in their private flags.
>>
>> The cpsw switch should be able to set not promiscuous mode as otherwise
>> a '1' is written to bit ALE_PORT_MACONLY_CAF which makes ethernet frames
>> get an additional VLAN tag when entering the port connected to the DSA
>> switch. Setting the IFF_UNICAST_FLT flag to all ports allows us to have
>> the conduit interface on the DSA subsystem set as not promiscuous.
> 
> It doesn't look like am65-cpsw-nuss supports unicast filtering, 
> tho, does it? So we're lying about support to work around some 
> CPSW weirdness (additional VLAN tag thing)?

CPSW driver does not support unicast filtering. 

-- 
Regards,
Ravi