Received-SPF: pass (google.com: domain of linux-kernel+bounces-88379-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <b10df0c1-5d8a-4c4d-b8bd-c0dbb53ea0d1@oracle.com>
Date: Fri, 1 Mar 2024 11:57:35 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/3] scsi: libsas: Define NCQ Priority sysfs attributes
 for SATA devices
To: Igor Pylypiv <ipylypiv@google.com>, Damien Le Moal <dlemoal@kernel.org>,
        Niklas Cassel <cassel@kernel.org>, Jason Yan <yanaijie@huawei.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Jack Wang <jinpu.wang@cloud.ionos.com>, Hannes Reinecke <hare@suse.de>
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, TJ Adams <tadamsjr@google.com>
References: <20240301013759.516817-1-ipylypiv@google.com>
 <20240301013759.516817-3-ipylypiv@google.com>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240301013759.516817-3-ipylypiv@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dkFkSzhpdTg5QmVrQ0c0Q3l4d2tGNWNsTW1Cb3Jib0hEN2dIYnFaOHBGaXhp?=
 =?utf-8?B?L3ZhbVAxU295QkxBMWFyNGExZVdCenkwZGVtMG1NVE9jcWIwVkV2Qlh3bFo0?=
 =?utf-8?B?R3lTQVBLVXNOeXprRnN4NFVxaDdzb2hMOUVqNDhyeWNYT1hLaURrcFIrcmpy?=
 =?utf-8?B?ckJlMy9nRHBDUlo5eTdvS1dYTko4enRaTGhCSzFjUi80bER4aXNoWndOenFs?=
 =?utf-8?B?azI0cFN5ZDh5Y2dhWHpqNUk0UTVjRmZlSFkvaWxudjJyS29mMnVFTkFPSG5H?=
 =?utf-8?B?REw5amFnVFJnRDVrNjFnaWVoZzRaYkcwR043NjFkbkdVOU0rSjU3dFl5RUlj?=
 =?utf-8?B?Ymc4TGJtUno0azlkdUwyTVA2bEtWdUlFcnVNNlgyV2NBUis2UVJpWGcxQjRo?=
 =?utf-8?B?M25BVVg2MGU2c1ZtMDY4ODU1T01TaDV4QkNoNkxCUWJnS2pyZGFOdnM3NkJL?=
 =?utf-8?B?ZjBiR3J4VkhyckVDTXVRU0M1MStVYU1BeTBBOU42SjJFUjFlcUdGeis5ajZi?=
 =?utf-8?B?QjdWWkxhNkRqWGw1TGVOU0xiY2pwMGpobFBQcHdBR2ZWRmwyUkhYemg4TFNN?=
 =?utf-8?B?NkFMRWxOT2Jmd2lXdVVTVHo4VnhhK1dUWTFyVm9Rb01qMWpvQmlxdnA2TlR2?=
 =?utf-8?B?czF4VmNuRC9tYkMyWmlBd2RZQWZDNDZSR1hURGlYVTRXc1JNRkt6OUVEL0hn?=
 =?utf-8?B?MEZzbWVGeGpob213VFZOL0M0WDZBZ1ZxcXR6cUtmMnYxaE54Wk56OEhFL0tt?=
 =?utf-8?B?TXM5aXk0U1NoSzdSU0NtaXZXSjM1WHRIemRXb2QxWkxlc0JIZGdSNUZLRHRE?=
 =?utf-8?B?VlJBWXpaSWllR1c4TWRZeVRZNTRkOXdlTE95RlhQVW1WRnJKeFRZYm4yb0FZ?=
 =?utf-8?B?SlZyTlNtY0xBOFJISWtJLy8zWGdjejZuenZsRTFzY3F0MkZYbERPTVB6Q2ZO?=
 =?utf-8?B?OFRBQWJOREZ5ejhvYWI2U09rSWZyZXg4VU1pNHExOUROdXRzT0V3RlN5MUxT?=
 =?utf-8?B?TlJheDl1UjZQeEpUL05YRmJZdVhmTUtuRUxZWnJoVHZyM3pLRUdDQVQzT3Nh?=
 =?utf-8?B?MGoyYlBDbUY2UHF0d21oZE5ZMy9jQkFWZHRYYkhjNW91dzZ1WTFCT1BHTmtR?=
 =?utf-8?B?Z3A2WE9XUlJlQWdHeEhXVFZxcEMvZ3RUV1RLdkhyc2R5blhMWlNnSVVISG0y?=
 =?utf-8?B?d2VCWWRkUmdyVWRxendobzFSa3dzcTVsZ3J3a281d0FPNGNkY3ZqSVBVU2k0?=
 =?utf-8?B?RkVpQ3BnSmhmVTZFUUpjbHd4YlpEMW5tM1N4c2ljcVE1aXl5MU1UOE9oOTBD?=
 =?utf-8?B?c0xUN0dFZENMcm4zTENWd3NPSHVwa3k1UUtuNzZMWkNaNjA1bGxZdlFnQ3ZJ?=
 =?utf-8?B?L1VHMmtJZVZKSkNYV2J6Y252T2RESjNFT0FsZyszS0UzZWVVVjh0L256Zi83?=
 =?utf-8?B?RDFXUmhIMDNsM0YrZEc3SFhuZU9lcXRHZFRGR1RkOEswMmk3c0xvL3Y0ckY5?=
 =?utf-8?B?SkFvTmFUVXhVSmxQNlZINU5rTnlEaGZwdnJZaUhuRVZSYitEeWllSXVUTXlv?=
 =?utf-8?B?Snl4RVFoM1VqWFU4Yzl1cVdkK3kyRUhiYzdldXJrME42c3VMdzN6S056OU9V?=
 =?utf-8?B?MHh3dUZaazFMQWFEUmUvLzdXdUJ6Rmt6MDNGSis5U20xZGlkd0tmRUxUQXF4?=
 =?utf-8?B?UlBJYTg0cmRERWpteENVQ2xYUXliU1NhcVdla3JJeDJHOU9OZllralV5a1RX?=
 =?utf-8?B?cC9VaWtqTTF4QlFvbGVkb0ZqREFYVWFYL3RzSDMrZVhoQjhad0VnYWRFWEdM?=
 =?utf-8?B?T0JNbjlZVDVJVm5oSmJTTk9UMGJwVnowQnBob1ZRR3lIWGlud0xPWFp2dDFx?=
 =?utf-8?B?WWkrSjVNT0JJWThkc3AydXlQUUZUSHRGNWNGWFBVOUFTcWVxTlBjOTArbzZw?=
 =?utf-8?B?L3FBSW4yMHFCa0pPUmpTZmdXeHlHTVJ3US9ER1ZYTTAzUWRoSVliVFZTTnFG?=
 =?utf-8?B?b1k3VzRYQ2REVVowckxzOEF5WGxkTEV6ME1jTEZVdnFtUFBLR1RmYmgyNGlH?=
 =?utf-8?B?eHhBSkIzMCtnUmE5M0tKcWQvdkVqcGVxS1JCLzhEeXNxUjg2MDhNV2hvbUt4?=
 =?utf-8?Q?8TPtdLOHjIpGUgrnBAcqP7abS?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	8quwwgrbxVAMf1jz/NTq7nBOwAUtNOtzeB9CjANyt1zx56ymFfPWb4aQZkZBfFnxzyNM8aM2lwhIjW/hLLdiMZ/WGHtkllEgUXUG7MUnxL2ZadyqILZ1UpBVHBu4TNyZETcVDZ8d9tZDR+7xxWM/V+wXz6XK0D7Hg2cY4dJPDYLS3iGdvDraTOoOoN6gP2biXyxMBqfY7/ygM/DmN8/nPmohOUMWANv8jJMIUyXwAbWFNsIV+IYYpO/4PLaBvWf7Y2pMmZ0+XPjGubEPHJIz29OwZuemDCFIEOmCYxVK3cPTTNMyr7h4d3sffbt1GFg4h7vlmpVqkz93JhJRUJdhXs41hlWd3MjLm8W2UqHnXD8UJ3SPmJEADFyu5qwI4KbkaBbQwlNFF2WWmqE/NyNbq+h8pYllBeZjjn+15dcazuok44Z5oQrYT58tGxV/hHo25VurzazlAe/0dFnXbi9+UGfU6ETGN4s+1p+ElLjI4Rp0IQ/1waTfWoUjwYh03C6tbT229v3EOBXIDv1/Fy1Ubj3YEfu6ZAz3jqrVLuhEKtgFvz77QOE9VSf1dtd5hnQowrYnbrOHzSA2Ra7j8n+HaWwVajKhfo1++IFb0hxKPBA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07b62907-6e87-40bf-5a25-08dc39e6cb90
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 11:57:40.2514
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xDJ2P0Crz1YKAhPGvqm04D9CE7gptLLaxtZDKLJZwfciyOJOTDGuJoBwGdWNc7HI624of50oVdkqeT0t8X4RIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR10MB7823
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-01_10,2024-03-01_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 suspectscore=0
 spamscore=0 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2403010101
X-Proofpoint-ORIG-GUID: LKPn1RelEIBRh-oBtRUv-ssjVXVOnRtd
X-Proofpoint-GUID: LKPn1RelEIBRh-oBtRUv-ssjVXVOnRtd

On 01/03/2024 01:37, Igor Pylypiv wrote:
> Libata sysfs attributes cannot be used for libsas managed SATA devices
> because the ata_port location is different for libsas.
> 
> Defined sysfs attributes (visible for SATA devices only):
> - /sys/block/*/device/sas_ncq_prio_enable
> - /sys/block/*/device/sas_ncq_prio_supported

it would be good to show the full path

> 
> The newly defined attributes will pass the correct ata_port to libata
> helper functions.
> 
> Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
> Reviewed-by: TJ Adams <tadamsjr@google.com>
> ---
>   drivers/scsi/libsas/sas_ata.c | 87 +++++++++++++++++++++++++++++++++++
>   include/scsi/sas_ata.h        |  6 +++
>   2 files changed, 93 insertions(+)
> 
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index 12e2653846e3..e0b19eee09b5 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -964,3 +964,90 @@ int sas_execute_ata_cmd(struct domain_device *device, u8 *fis, int force_phy_id)
>   			       force_phy_id, &tmf_task);
>   }
>   EXPORT_SYMBOL_GPL(sas_execute_ata_cmd);
> +
> +static ssize_t sas_ncq_prio_supported_show(struct device *device,
> +					   struct device_attribute *attr,
> +					   char *buf)
> +{
> +	struct scsi_device *sdev = to_scsi_device(device);
> +	struct domain_device *ddev = sdev_to_domain_dev(sdev);
> +	int res;
> +
> +	// This attribute shall be visible for SATA devices only

Please don't use c99 comment style

> +	if (WARN_ON(!dev_is_sata(ddev)))
> +		return -EINVAL;
> +
> +	res = ata_ncq_prio_supported(ddev->sata_dev.ap, sdev);
> +	if (res < 0)
> +		return res;
> +
> +	return sysfs_emit(buf, "%u\n", res);
> +}
> +static DEVICE_ATTR_RO(sas_ncq_prio_supported);
> +
> +static ssize_t sas_ncq_prio_enable_show(struct device *device,
> +					struct device_attribute *attr,
> +					char *buf)
> +{
> +	struct scsi_device *sdev = to_scsi_device(device);
> +	struct domain_device *ddev = sdev_to_domain_dev(sdev);
> +	int res;
> +
> +	// This attribute shall be visible for SATA devices only
> +	if (WARN_ON(!dev_is_sata(ddev)))
> +		return -EINVAL;
> +
> +	res = ata_ncq_prio_enabled(ddev->sata_dev.ap, sdev);
> +	if (res < 0)
> +		return res;
> +
> +	return sysfs_emit(buf, "%u\n", res);
> +}
> +
> +static ssize_t sas_ncq_prio_enable_store(struct device *device,
> +					 struct device_attribute *attr,
> +					 const char *buf, size_t len)
> +{
> +	struct scsi_device *sdev = to_scsi_device(device);
> +	struct domain_device *ddev = sdev_to_domain_dev(sdev);
> +	long input;
> +	int res;
> +
> +	// This attribute shall be visible for SATA devices only
> +	if (WARN_ON(!dev_is_sata(ddev)))
> +		return -EINVAL;
> +
> +	res = kstrtol(buf, 10, &input);

I think that kstrtobool_from_user() could be used. But 
kstrtobool_from_user() handles more than 0/1, so that would be a 
different behaviour, so maybe better not to use.

I would also suggest factor out some of ata_ncq_prio_enable_store() with 
this, but a public API which accepts char * would be a bit odd.


> +	if (res)
> +		return res;
> +	if ((input < 0) || (input > 1))
> +		return -EINVAL;
> +
> +	return ata_ncq_prio_enable(ddev->sata_dev.ap, sdev, input) ? : len;

Please don't use ternary operator like this. This seems more 
straightforfward:

res = ata_ncq_prio_enable();
if (res)
	return res;
return len;

> +}
> +static DEVICE_ATTR_RW(sas_ncq_prio_enable);
> +
> +static struct attribute *sas_ata_sdev_attrs[] = {
> +	&dev_attr_sas_ncq_prio_supported.attr,
> +	&dev_attr_sas_ncq_prio_enable.attr,
> +	NULL
> +};
> +
> +static umode_t sas_ata_attr_is_visible(struct kobject *kobj,
> +				       struct attribute *attr, int i)
> +{
> +	struct device *dev = kobj_to_dev(kobj);
> +	struct scsi_device *sdev = to_scsi_device(dev);
> +	struct domain_device *ddev = sdev_to_domain_dev(sdev);
> +
> +	if (!dev_is_sata(ddev))
> +		return 0;
> +
> +	return attr->mode;
> +}
> +
> +const struct attribute_group sas_ata_sdev_attr_group = {
> +	.attrs = sas_ata_sdev_attrs,
> +	.is_visible = sas_ata_attr_is_visible,
> +};
> +EXPORT_SYMBOL_GPL(sas_ata_sdev_attr_group);
> diff --git a/include/scsi/sas_ata.h b/include/scsi/sas_ata.h
> index 2f8c719840a6..cded782fdf33 100644
> --- a/include/scsi/sas_ata.h
> +++ b/include/scsi/sas_ata.h
> @@ -39,6 +39,8 @@ int smp_ata_check_ready_type(struct ata_link *link);
>   int sas_discover_sata(struct domain_device *dev);
>   int sas_ata_add_dev(struct domain_device *parent, struct ex_phy *phy,
>   		    struct domain_device *child, int phy_id);
> +
> +extern const struct attribute_group sas_ata_sdev_attr_group;
>   #else
>   
>   static inline void sas_ata_disabled_notice(void)
> @@ -123,6 +125,10 @@ static inline int sas_ata_add_dev(struct domain_device *parent, struct ex_phy *p
>   	sas_ata_disabled_notice();
>   	return -ENODEV;
>   }
> +
> +static const struct attribute_group sas_ata_sdev_attr_group = {
> +	.attrs = NULL,
> +};
>   #endif
>   
>   #endif /* _SAS_ATA_H_ */