Received-SPF: pass (google.com: domain of linux-kernel+bounces-88382-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <dfe1b3d3-379c-4f19-b580-f280ed89c7b1@oracle.com>
Date: Fri, 1 Mar 2024 11:59:04 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/3] scsi: pm80xx: Add libsas SATA sysfs attributes group
Content-Language: en-US
To: Igor Pylypiv <ipylypiv@google.com>, Damien Le Moal <dlemoal@kernel.org>,
        Niklas Cassel <cassel@kernel.org>, Jason Yan <yanaijie@huawei.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Jack Wang <jinpu.wang@cloud.ionos.com>, Hannes Reinecke <hare@suse.de>
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, TJ Adams <tadamsjr@google.com>
References: <20240301013759.516817-1-ipylypiv@google.com>
 <20240301013759.516817-4-ipylypiv@google.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240301013759.516817-4-ipylypiv@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?YW5pdU1vSlkvUGVSM1E3UC8yMHZQU2gzR1BZdENjRmNIdFhkQlc3dVdJZzli?=
 =?utf-8?B?bkk1bEdzRVo4SHQ5d1Q5VHZ1SHlHNWtiL0RqRUdtWUpJbmZwQnFZUVhjTURJ?=
 =?utf-8?B?R0FBNmVKLy9uS25XQWpQVHowZXlLanJucldIOHR4dU5mWERKVWhkeEJRMmN1?=
 =?utf-8?B?SG9DV2dQRGFuN3ZuU0F5c0R3clFhalBmMU1UdVBIWCt3dkk3ZUNoeG1LWkJv?=
 =?utf-8?B?RG9ZclNtWlR5bUVkdWJrVzI1Z1ZpQTRUK3hNYTRqQW81UEkwemhsTmVuVVJE?=
 =?utf-8?B?bnhKemE4dGNnemlGNWNONlFaQlN2bEk3K1F5VWVYejJ5QWwwSHF2ekJiN2d5?=
 =?utf-8?B?bGM3V1hUMkYxc0xBcjluUnk1b2xHemdRV1E2L3FjbnlWUlVXQU54TVJBanlY?=
 =?utf-8?B?L1BCWHNkMk9ZVGJIKy9nRGlCaEJHdDZZQWxKcTFNOTBsOVhMajRCSWNuNFd6?=
 =?utf-8?B?SERKQ0laU3FIa2lGaitOSFlIU3ZUOHBmcGZScHlibitmZVZ4ZWdyUGlXWnVI?=
 =?utf-8?B?TGtaNGsxZ3NTOGhGSEk1SjNWclcyaUpNbWFmOWF4VEpza3FsWFFna2E0SmRw?=
 =?utf-8?B?OGQrcVZibVlqMlcxWkxWRXExQm9tOGVjZnB2aThqQlJLR3ozRFNqNlNEYVh3?=
 =?utf-8?B?cjZLZTlTbHZUeUM5Q2pOYzFFV3lRQlpPVVZJblVTaUw4dUVvTnFWRUg5TEd0?=
 =?utf-8?B?T3VrRDNuajZFZ1ZUZzJiMFJXVnpBaWJuRWQrU0FKaGVuRUNiRnZLRnhFTFFT?=
 =?utf-8?B?SVJqQUNWL2IwemdWVkFldXJQTXk4UnY2d1NFbm50eFFubTJTV0tlN0ErY0hu?=
 =?utf-8?B?VWo1TTBtZk40WEF1Nmsya0EyY3l5L2Rmdm1WYmU5Q1lpRlVBR3Azd25FWHds?=
 =?utf-8?B?VGZsdE53WVYyeWtUVEk2UXBHUjhkNGxyTDJWLzl5SGZSdE5YYnRnb1kwYWlh?=
 =?utf-8?B?eVozSGhQb2lISDc0MTU2cDNnbXFDdTM2NnNOZnBJZWcyaFplenE4bmpINTlF?=
 =?utf-8?B?WXhKalMwT3JxRUFQMXdsUkR1MEtQYUZRSGpVQVpoN1I2NmFXVGJnU3BrYmFC?=
 =?utf-8?B?Mm1CSSs3Q25WWHI4d0RkSDVienVRWWxOV2xHL08yYVkrUU5nNDYyQmZ4NTJq?=
 =?utf-8?B?STBpdlJjQldmK1I1S25ROFNUNGpscC9YM2NmKzlYRk01RVV4UWhOQlVYMFNB?=
 =?utf-8?B?Q2JzZXkrVDFJQ0ZYVTdnbWpXTDdCMTlTRDdLaStwK2oyYXczSnBHTmxBOWRp?=
 =?utf-8?B?MVVQaW0yM040dy9vZ1dYdkxFbXBvcHhTNjFjYlJzcCtpcnB1QUJEUS8rQzBX?=
 =?utf-8?B?c2pZVUhHeGgvWjNtQURxaGx3ZVZuK0wwNEt5S2lBd0ZpaUJwRzJhUGUrcVB2?=
 =?utf-8?B?N29LblBvelVLcW1KOCtIL1dTOU16S2hpMW9BTURhWVRoZzlEMXRkU2ZYU04z?=
 =?utf-8?B?Z05HMmNHMis4RThueGVCSVl2Q1hQb2xtUGFhUFludG5DWldwb0QyYUZtQm0v?=
 =?utf-8?B?NGZYaVU2a3VzR2g4bkZpcWx5R050TFBEOEF6M2x1V1NxbDBVNVU4WTVlWDRy?=
 =?utf-8?B?YTJkeEhubXhuOUlqanlQSXRkWVN0ejlNYjZaTWsveU9WUW5YbVowNkVKNnkr?=
 =?utf-8?B?U1pLdmcyOFlkWWl5cGVVWm9nb1FNK0VjM1pMSWFqdkthc29uUUtYSzJHNFgx?=
 =?utf-8?B?dTBVV09PZ1N4bWFTVktxRXQrbG1zSWZCSUluNFBFLy95K3RIdVRSR2tWZkpR?=
 =?utf-8?B?Y0MraDJxRlBTN3NRNTBOVThBRlB5YmtvMXdTaXV2RzlpSHMwaGZ1amVXVnds?=
 =?utf-8?B?alpOVmxFaEg3RkNhZjRkc0VLSmZQQUJ2RW54R0x3WUZKZS9CTkhPL1QyT2xm?=
 =?utf-8?B?d0JFNVFSUXNmMFoza2ZDUTBnaXdrRHJ6elRpZmFpWVRzb1p5WlVwUFRhbDJr?=
 =?utf-8?B?dzJSUTdocWRNd1p3aWVZR1QvMXBYZ0ZMQmR6OWJZN0grMy80elRBVkxEVGt6?=
 =?utf-8?B?YmNlc2UxK1p3SFNiV1dQeU0raExrcVNhNUJTM3MxeDhsUnozTUd5ay9HanVj?=
 =?utf-8?B?b3pibVRJU09aREFSeWcwTFVZNHJEU0tUaU9EN2JPOXNkY1ZqUGNiRTNCeEgw?=
 =?utf-8?Q?f1CVLKpD2aHdsctQwe+3QrOc9?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	WS1UWdbL0bincP+H0p67jYwW6lGAC2LoKCtl+/J3u3tpIykVW6R6jlg86eCzg1q1q0h7ok2JQBrgHF1w5L0a0q3FQeejo907NSoqV1gesgxfMILmaQY67Bwh5SqisgjrsbDJamPlTSOyXceiMz3kR/QQnNaG9GICn5d5gF8v1OS7IzMJ9nUJSQtQmrRWWF2ikGMEroFLEESQekpi1jg9S9xjYxM9RyvhH5K8GoNn32al/+Vr7azM6B5dRJ1NnrcMSKr1axPJdtCzYlwaZIHpYsK//s5SdWLAZTBmIIskbhug6sgPnLRtPZWkIXYewQxGgDUwo24IK5h4Cfx2VP5a0WuIOF2CvKOC9tYvdJfwykfxMOfOWgO0T1kPVNpF64THqXbFByJhJ9VVEU5/ifTZIoFyY5zK8lbiWdnpj6baowFu0rDUKS+aXCqEqmiU2nVdWwik9yXbSj1lCjvD8Q5jKCh76EXUDu7mWYQeHJ/GsmgC2zthUismJbpL+OxoRy1LkrnLB04/e/DxfXmqb4v80aV2qjN+R6LuuhYK6AUOj/+FY1PTP+UL5cqXqOQquy/Je3FmZPsEjUJQ2LO0eD573WbvJNDP4L4y+FzWf7/1z/o=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 737b3f69-eb0f-4566-b91d-08dc39e6ff2b
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 11:59:06.8315
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JZJmGcu10FtmUemOM8+S3/uVPzuhJExr6G5CNArnfKm2v1dLcvcHf6z0xwzH47wwQwyi9rl8JmXTWv48NR7TEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR10MB7823
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-01_10,2024-03-01_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0
 mlxlogscore=999 malwarescore=0 spamscore=0 mlxscore=0 adultscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403010101
X-Proofpoint-GUID: 2fX8XHrD6ImegeKNktgoC_JGn51wwvHw
X-Proofpoint-ORIG-GUID: 2fX8XHrD6ImegeKNktgoC_JGn51wwvHw

On 01/03/2024 01:37, Igor Pylypiv wrote:
> The added sysfs attributes group enables the configuration of NCQ Priority
> feature for HBAs that rely on libsas to manage SATA devices.
> 
> Signed-off-by: Igor Pylypiv<ipylypiv@google.com>
> Reviewed-by: TJ Adams<tadamsjr@google.com>
> ---
>   drivers/scsi/pm8001/pm8001_ctl.c  | 5 +++++
>   drivers/scsi/pm8001/pm8001_init.c | 1 +
>   drivers/scsi/pm8001/pm8001_sas.h  | 1 +
>   3 files changed, 7 insertions(+)

More drivers than pm80xx use libsas and also handle SATA devices - 
please make similar changes to them also.

Thanks,
John