Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757076AbYACTPc (ORCPT ); Thu, 3 Jan 2008 14:15:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752927AbYACTPV (ORCPT ); Thu, 3 Jan 2008 14:15:21 -0500 Received: from ms-smtp-02.nyroc.rr.com ([24.24.2.56]:50511 "EHLO ms-smtp-02.nyroc.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbYACTPT (ORCPT ); Thu, 3 Jan 2008 14:15:19 -0500 Date: Thu, 3 Jan 2008 14:15:13 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Chris Wright cc: Ingo Molnar , LKML , Linus Torvalds , Andrew Morton , Peter Zijlstra , Christoph Hellwig , Mathieu Desnoyers , Gregory Haskins , Arnaldo Carvalho de Melo , "William L. Irwin" , Steven Rostedt , Chris Wright , Rusty Russell , virtualization@lists.linux-foundation.org Subject: Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation In-Reply-To: <20080103181651.GC3627@sequoia.sous-sol.org> Message-ID: References: <20080103071609.478486470@goodmis.org> <20080103072226.776141236@goodmis.org> <20080103092104.GE10813@elte.hu> <20080103181651.GC3627@sequoia.sous-sol.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 25 On Thu, 3 Jan 2008, Chris Wright wrote: > > Yes, paravirt ops have a well-specified calling convention (register > based). There was a cleanup that Andi did that caused the problem > because it removed all the "fastcall" annotations since -mregparm=3 > is now always on for i386. Since MCOUNT disables REGPARM the calling > convention changes (caller pushes to stack, callee expects register) > chaos ensues. I sent a patch to fix that quite some months back, but > it went stale and I neglected to update it. Would you like me to dig > it up refresh and resend? Chris, thanks for the refresher. I'm going to see if we can remove the REGPARM hack and change the way mcount does its calls. Maybe this will fix things for us. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/