Received-SPF: pass (google.com: domain of linux-kernel+bounces-88388-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 1 Mar 2024 12:11:56 +0000
From: Mark Brown <broonie@kernel.org>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: Aishwarya TCV <aishwarya.tcv@arm.com>, Zi Yan <ziy@nvidia.com>,
	"Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>,
	linux-mm@kvack.org, "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	David Hildenbrand <david@redhat.com>,
	Yang Shi <shy828301@gmail.com>, Yu Zhao <yuzhao@google.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Zach O'Keefe <zokeefe@google.com>, Hugh Dickins <hughd@google.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge
 pages to any order.
Message-ID: <2d5f9cd5-a2c2-453e-aa52-a84a86107d1f@sirena.org.uk>
References: <20240226205534.1603748-1-zi.yan@sent.com>
 <20240226205534.1603748-9-zi.yan@sent.com>
 <082e48c8-71b7-4937-a5da-7a37b4be16ba@arm.com>
 <0dab0c69-2eac-4e65-9efe-e0b037499abc@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ghaC36SALgS50dQQ"
Content-Disposition: inline
In-Reply-To: <0dab0c69-2eac-4e65-9efe-e0b037499abc@arm.com>


--ghaC36SALgS50dQQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Mar 01, 2024 at 10:33:15AM +0000, Ryan Roberts wrote:

>   - In create_pagecache_thp_and_fd() you do *fd = open(testfile, O_CREAT ...);
>     where testfile is /mnt/thp_fs/testfile. So if /mnt/thp_fs doesn't exist,
>     then the open will fail I think? I'm pretty sure that's what's happening on
>     our CI. Suggest the test needs to setup this dir itself. Is thp_fs a mounted
>     fs or just a dir? If the latter can you just mktemp()?

Mounting on /mnt would also be a bit of an issue, that's something
people are relatively likely to have used for something so could be
disruptive.  If the test is going to do a new mount it's probably better
to do something like make a temporary directory then mount on top of that.

--ghaC36SALgS50dQQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXhxgsACgkQJNaLcl1U
h9CNLgf9HnhxProx3fA8CTE/KbjX2kFnC4nKYaXEmu4hIqNDt7YEDJ3tb98zw/Sj
bTFxhX7W1MPl3iqo8ylB7H8Lkx87AgriD1Z1Dx7ejr4VuFG7wY+yee81LuIL9p9K
YCRKeb8PXzdPitkpVupwFmf3HxNLkpOnPYnZz3e5J6UNthFxxBHkcDKXxNGxa3v2
JE4LuVmQ+tSw442i4gNHrcmIuaSIIdlcGX5GcNFRGvIpR+UshuCxz3nW3E++9Yoa
3V+ueMu756haaNJActL1liljR0Q6JMp934EuvNJ+o6XWl48aGkuXQ4dUabvm7Qn1
LwbKuFeIM2JiK9dS6EWSVyiPTPvS1w==
=Rx7H
-----END PGP SIGNATURE-----

--ghaC36SALgS50dQQ--