Received-SPF: pass (google.com: domain of linux-kernel+bounces-88420-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Zi Yan <ziy@nvidia.com>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: Aishwarya TCV <aishwarya.tcv@arm.com>,
 "\"Pankaj Raghav (Samsung)\"" <kernel@pankajraghav.com>, linux-mm@kvack.org,
 "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 David Hildenbrand <david@redhat.com>, Yang Shi <shy828301@gmail.com>,
 Yu Zhao <yuzhao@google.com>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 =?utf-8?q?=22Michal_Koutn=C3=BD=22?= <mkoutny@suse.com>,
 Roman Gushchin <roman.gushchin@linux.dev>,
 "\"Zach O'Keefe\"" <zokeefe@google.com>, Hugh Dickins <hughd@google.com>,
 Luis Chamberlain <mcgrof@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
 cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 linux-kselftest@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge
 pages to any order.
Date: Fri, 01 Mar 2024 07:52:46 -0500
Message-ID: <08703C70-DD6E-446A-9ABC-BC2C8E33B8CD@nvidia.com>
In-Reply-To: <0dab0c69-2eac-4e65-9efe-e0b037499abc@arm.com>
References: <20240226205534.1603748-1-zi.yan@sent.com>
 <20240226205534.1603748-9-zi.yan@sent.com>
 <082e48c8-71b7-4937-a5da-7a37b4be16ba@arm.com>
 <0dab0c69-2eac-4e65-9efe-e0b037499abc@arm.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_3C9A0395-3E51-410F-87CC-F1244AC147F8_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?OAIqrIZEpNqNCjGx4T7cLI8tdGajuAvjCUg9BkjCzfMHg1JcW2859vbbxZx8?=
 =?us-ascii?Q?sRUDN9yZpvL8Nd9izfn5rZICHrdUXRAnGxwqcJX6hIn9pK5N+GOaoyfB+wUQ?=
 =?us-ascii?Q?sPjG57IF7PQRGyJBAPfazMhKmjlCm/uM/KK4jjfpFoO27gqByGMG0LVK5LoY?=
 =?us-ascii?Q?vKXdwH4YPtIngDilGs+NbRoHwqV+nyJRDuJAwRMUHwi2jk+WJtre4Vsfqewd?=
 =?us-ascii?Q?SUB4fmz/RqPpJuDljJ6A6G5jA9WuUbzWktUypTUVkQhEoeorJDwM8+wLcIum?=
 =?us-ascii?Q?a9oiKd6+18hgrFCvWrNj1TJRhFxFhqkO9n/dgGLH4tWzEuOBoV+fK4SJpGAi?=
 =?us-ascii?Q?rS4ZkrfRB8WCTPChozuNOFZ4oUh3S+lB12D8W0J/KJqduy8obHoqyVoBMlzR?=
 =?us-ascii?Q?JPCVMbv71sCYy2pb+azVeX43/SFRsaAfD9qjqNEuamO5yj30/3d2K38zgx3m?=
 =?us-ascii?Q?cqPWD5HtmG8jfClc1sf9dqkHrzPONOIsTGZ0pIl+D1A9tqIpM9qvIggN2Mu8?=
 =?us-ascii?Q?W5GtK1Gq4iGZYCco/6d41VL+zG2nJxs0feLsKXtiKjx1Fd+76QYbIMpv4nJU?=
 =?us-ascii?Q?QynV1TVFTz2MD6VRhpftEAhPPTi3bDnLSp2xSCG+W7DoSWCWgsaHu9Ap1i82?=
 =?us-ascii?Q?HKDYkLnddUOW2d+DRZCny+4cAkDVh30jebzs6yFElsBrPSK3fkZ+SasenHED?=
 =?us-ascii?Q?dfgZO7hRPfZH3MEVwchug2/ARmbOGBn3v8HmhWyUrBHoJj+57zzPhz3ikna6?=
 =?us-ascii?Q?wXBJUT4OnpTFh2lznOkBs9lkTCyqgX1qTdFQTT3j/EsQTmrH6Rmzzth+WUkf?=
 =?us-ascii?Q?E4LtilUd02Mix3I7lFznbdFUhmeVs96gCn0ATPc2ngnT/2mcSwmqryqDNzQk?=
 =?us-ascii?Q?22q465GPPQMAtm2QiE8LmYkYtH1lfVe2Bpsllvff2xlublYmJIQJKhXVO+K7?=
 =?us-ascii?Q?S6pskxhpVs+NEij2xvFIBbTMx4dexqlkrLESnL9tbLMuSpM0jsCj1dhF1noL?=
 =?us-ascii?Q?TWqVhXwLAjFix+8Y1L7ceEUqrSCibBE719taBXMEvxluFZVDKyOLpiwJh+LM?=
 =?us-ascii?Q?67EFtNJzoJIqy1AInwT1r1MMrUmdAAeB2RCYNSbOKQS9CLC++YK1lG77HFBm?=
 =?us-ascii?Q?yHb/m70hcjzZ06CwageAPhu7m/lqhyMceGG4R5MN0HbU8n9lX1WzfV23vOAy?=
 =?us-ascii?Q?LGGj3m8YaPgkp75lof75e4SBoyiQanlfmPuUk2PHBWT03/x4mWihmyr7tz/R?=
 =?us-ascii?Q?Zuchn0+34c/uMMT5Bt5dnQiuO5yab1z7YUWosM+0nZS+agOtXr540zYUQHjs?=
 =?us-ascii?Q?UdJ0wUOPaQtjNwrcVFuw7FrGrPiVwirJaWqOhbG37yVt9X9QyhaqCqNfXt3W?=
 =?us-ascii?Q?cTjElHefbsJwcc1kMIrfBj+QbMda9B+wPS9vvVxd+D+t7neIL1DAu4dhZPca?=
 =?us-ascii?Q?u56i5PatG/DfOR+0eDZ22L3QnPgrGDCUIwOoWee5PbEJC66GEdrEG4i+Y9uY?=
 =?us-ascii?Q?h+S8eSlgYmizNAzvhjL2ojAUV5/0y0jPgdfjhQxnfGKE6cRJ8TuyXLHzxNYz?=
 =?us-ascii?Q?46iHVqITCxz+KZ+KIaE=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: beb6a631-b263-4f05-a8b1-08dc39ee7f6d
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5730.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 12:52:48.3880
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9i22GnPp8cSnBoI/74f0NNZdEueHcXQsaUUfVlsBPfD/a2QBot0NvFfx/TJlrQ5j
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5716

--=_MailMate_3C9A0395-3E51-410F-87CC-F1244AC147F8_=
Content-Type: text/plain

On 1 Mar 2024, at 5:33, Ryan Roberts wrote:

> On 01/03/2024 09:51, Aishwarya TCV wrote:
>>
>>
>> On 26/02/2024 20:55, Zi Yan wrote:
>>> From: Zi Yan <ziy@nvidia.com>
>>>
>>> It is used to test split_huge_page_to_list_to_order for pagecache THPs.
>>> Also add test cases for split_huge_page_to_list_to_order via both
>>> debugfs.
>>>
>>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>>> ---
>>>  mm/huge_memory.c                              |  34 ++++--
>>>  .../selftests/mm/split_huge_page_test.c       | 115 +++++++++++++++++-
>>>  2 files changed, 131 insertions(+), 18 deletions(-)
>>>
>>
>> Hi Zi,
>>
>> When booting the kernel against next-master(20240228)with Arm64 on
>> Marvell Thunder X2 (TX2), the kselftest-mm test 'split_huge_page_test'
>> is failing in our CI (with rootfs over NFS). I can send the full logs if
>> required.
>
> Just to add, I took a quick eyeball and I think there a couple of potential issues:
>
>   - In create_pagecache_thp_and_fd() you do *fd = open(testfile, O_CREAT ...);
>     where testfile is /mnt/thp_fs/testfile. So if /mnt/thp_fs doesn't exist,
>     then the open will fail I think? I'm pretty sure that's what's happening on
>     our CI. Suggest the test needs to setup this dir itself. Is thp_fs a mounted
>     fs or just a dir? If the latter can you just mktemp()?

The former. the page cache folio split tests require a file system supporting
large folio and I used XFS.

>   - Later in create_pagecache_thp_and_fd() you fail the test if you don't have a
>     filesystem that supports large folios. Can we turn that into a skip? That
>     would reduce noise on the CI.

I can do that. But is this a new requirement that self tests have to be finish
in CI/CD environment? Can you provide a guideline for it? Since I always assume
selftests are just ran by human who can set up environment. In addition, I do
not think it is realistic to make the test file to set up all the environment,
since everyone's machine is different. It is much easier to make the CI/CD
environment to make the mount.

>
> Thanks,
> Ryan
>
>>
>> A bisect (full log below) identified this patch as introducing the
>> failure. Bisected it on the tag "next-20240228" at repo
>> "https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git".
>>
>> This works fine on  Linux version 6.8.0-rc6
>>
>>
>> Sample log from failure against run on TX2:
>> ------
>> 07:17:34.056125  # # ------------------------------
>> 07:17:34.056543  # # running ./split_huge_page_test
>> 07:17:34.056839  # # ------------------------------
>> 07:17:34.057114  # # TAP version 13
>> 07:17:34.058564  # # 1..12
>> 07:17:34.156822  # # ok 1 Split huge pages successful
>> 07:17:34.214074  # # ok 2 Split PTE-mapped huge pages successful
>> 07:17:34.215630  # # # Please enable pr_debug in
>> split_huge_pages_in_file() for more info.
>> 07:17:34.225503  # # # Please check dmesg for more information
>> 07:17:34.225862  # # ok 3 File-backed THP split test done
>> 07:17:34.236944  # # Bail out! Failed to create a file at /mnt/thp_fs#
>> Planned tests != run tests (12 != 3)
>> 07:17:34.237307  # # # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0
>> 07:17:34.237620  # # [FAIL]
>> 07:17:34.246430  # not ok 51 split_huge_page_test # exit=1
>>
>>
>> Bisect log:
>> ------
>> git bisect start
>> # good: [d206a76d7d2726f3b096037f2079ce0bd3ba329b] Linux 6.8-rc6
>> git bisect good d206a76d7d2726f3b096037f2079ce0bd3ba329b
>> # bad: [20af1ca418d2c0b11bc2a1fe8c0c88f67bcc2a7e] Add linux-next
>> specific files for 20240228
>> git bisect bad 20af1ca418d2c0b11bc2a1fe8c0c88f67bcc2a7e
>> # bad: [1322f1801e59dddce10591d602d246c1bf49990c] Merge branch 'main' of
>> git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
>> git bisect bad 1322f1801e59dddce10591d602d246c1bf49990c
>> # bad: [a82f70041487790b7b09fe4bb45436e1b57021d3] Merge branch 'dev' of
>> git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git
>> git bisect bad a82f70041487790b7b09fe4bb45436e1b57021d3
>> # bad: [ce90480b9352ba2bebe8946dad9223e3f24c6e9a] Merge branch
>> 'for-next' of
>> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git
>> git bisect bad ce90480b9352ba2bebe8946dad9223e3f24c6e9a
>> # bad: [5daac92ed3881fd0c656478a301a4e1d124100ee] Merge branch
>> 'mm-everything' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>> git bisect bad 5daac92ed3881fd0c656478a301a4e1d124100ee
>> # good: [acc2643d9e988c63dd4629a9af380ad9ac69c54a] Merge branch
>> 'mm-stable' into mm-unstable
>> git bisect good acc2643d9e988c63dd4629a9af380ad9ac69c54a
>> # good: [0294de8fe7d7c1a7eddc979cbf4c1886406e36b7] Merge branch 'fixes'
>> of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git
>> git bisect good 0294de8fe7d7c1a7eddc979cbf4c1886406e36b7
>> # good: [83e0c8f0e777a1ef0977b2f8189101765703b32d] Merge branch
>> 'mm-nonmm-stable' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>> git bisect good 83e0c8f0e777a1ef0977b2f8189101765703b32d
>> # good: [a739cbe236e0dd3b6ff26a01fa1d31c73d4fac93] mm: memcg: make memcg
>> huge page split support any order split
>> git bisect good a739cbe236e0dd3b6ff26a01fa1d31c73d4fac93
>> # bad: [efb520aa333b2f11daaaaa13f4a598b5ae4ae823] mm: allow non-hugetlb
>> large folios to be batch processed
>> git bisect bad efb520aa333b2f11daaaaa13f4a598b5ae4ae823
>> # bad: [2258bdebb55e3ad3d30fd3849ddb955ff36825de] mm/zsmalloc: don't
>> hold locks of all pages when free_zspage()
>> git bisect bad 2258bdebb55e3ad3d30fd3849ddb955ff36825de
>> # bad: [7fc0be45acf2878cbacc4dba56923c34c3fd8b1e] mm: remove
>> total_mapcount()
>> git bisect bad 7fc0be45acf2878cbacc4dba56923c34c3fd8b1e
>> # good: [d55fac55da2f87ad5a99178e107df09770bbc411] mm: thp: split huge
>> page to any lower order pages
>> git bisect good d55fac55da2f87ad5a99178e107df09770bbc411
>> # bad: [4050d591c1aaf9336c08511fa5984827186e9ad1] mm/memfd: refactor
>> memfd_tag_pins() and memfd_wait_for_pins()
>> git bisect bad 4050d591c1aaf9336c08511fa5984827186e9ad1
>> # bad: [c0ba89c29ef559c95273feb481b049f622c43c17] mm: huge_memory:
>> enable debugfs to split huge pages to any order
>> git bisect bad c0ba89c29ef559c95273feb481b049f622c43c17
>> # first bad commit: [c0ba89c29ef559c95273feb481b049f622c43c17] mm:
>> huge_memory: enable debugfs to split huge pages to any order
>>
>>
>> Thanks,
>> Aishwarya


--
Best Regards,
Yan, Zi

--=_MailMate_3C9A0395-3E51-410F-87CC-F1244AC147F8_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXhz54PHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUXg8QAIA/tXQQRXYzvg2K3/xq2hdCiUtljCgMTdJt
GZQYmZG60pFTA8jec6EfhjrDA6OJg3BD3Qjb42Jq9+ak0qsWeku/J50x0tuXVMZn
0jtW5u7hA+yqHsocXY6IqHa1VUuYMLy7C32i49XondfQhDlRsVHIGA0vf1Oi9YSa
P+PIUYonCBa3vKWT4irYmjE58wpZKevbgqueJ8y+ebOV1qS6Fpmdf6QLagaEk3BG
g4Z97tu5WIRvnhlyjCYMr1q0F3gViUxSmTbhocYkTUAO7cbMWUnQjp7QlC1troEX
cVXDC6kEmbDnY4ddPBCU3IEo+KlA9IhNCUjupeFSddOtRblAeRxfamzoOT5Gpia1
DqYg3TWY5tR8TBGuF1h+yzwRXDWO0Fwg7sjDyksR40XEjN8PvlAKQqS21jC1CYuj
Sz5OamZaPmpl3BcB1FOHoucdaEoiJ49m15YWDBwOFlYEauv1vt3BWGq7AeNAW0rA
6moMDIozSeNacrMCjmcASYqdQQRwfT3+EvdgNjlOrO0fdPsl+iG++MgjOZdA2Gbu
FnJaBkML73RQy9oNW+8OKL4M2bA59sB9SpWisE933k8casEV5e0lGlgrlevXqwzE
+UuXBD8pPDA4TXeXnpigTmkufhJfM2Yj69BRxt1hB+cCYKcKwXH2V08Svl46qmib
Y+jtq+WS
=uu3/
-----END PGP SIGNATURE-----

--=_MailMate_3C9A0395-3E51-410F-87CC-F1244AC147F8_=--