Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp278079lqg; Fri, 1 Mar 2024 05:12:18 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX0BBRhfNn4iH/IhYu2r6GGR+Yz1cbl2zOUIcBBNSDqUzIFHPQ+tKt6YQHcp6mpOhDpyT8ArrhSOUme5Uf9zn6KOjNsfeLoJT5oCpsgYQ== X-Google-Smtp-Source: AGHT+IErrP1GoQLETpYX/iS9pyPUdQ9SB5u32jWgGU+w9QfFlJO6n1UcodI7PK38br3jSY5GxbnD X-Received: by 2002:a05:6a00:3d08:b0:6e5:6e40:a0ca with SMTP id lo8-20020a056a003d0800b006e56e40a0camr1690121pfb.22.1709298738270; Fri, 01 Mar 2024 05:12:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709298738; cv=pass; d=google.com; s=arc-20160816; b=eAL2U9i9Kyn3O5rG5cZy2ipX0Vq0cIkCkDCEew9gr8ISTqRKRKS6sF95bQbmTlErKi WlIkH4PXEM0rqi2484G1N7iioFdHZz5j8EKYcn8V5BzShZdQiQfuVa850LH5TkSZAopg meE+G02ogTTwZolCqFkn2k0zkPRwzcVzRJLU7OC4GU4YXA3tlbaiZkda4zFqPJIvQdwK 3jWeRUIzCTFiJYeoum3y/Q9rvTFY6Cb/DVU/rC4Kqhxdc2VibrLq7WzYo/77sZfkAWBm 3P5ZOSKPZdXt5pzxa4mVOCjDE8Pyflii3kVRRSZm1+3dbvhxxcyVKpnbzSbiz9Ku22/m Jb7g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=S1Y6voyr7uYxfRRUc14qKmVck6hvy3VXFC3+hSJ9giA=; fh=gKBX4PjCCM1kJrhhIShh8Uxf5Q/xBjoedFYwezywuLE=; b=WORXdVLvSiN6l2i/HkJzizpTrjVVSE9pTNsB0jQwiR+qddJethUMyfDg2jvJdkJlXv WV3z2is2M5uP+N8FJjih43j9RhfOZ1gSBH/djG+rDoFbXkNnmuCwS0WygQCFyLYmGY0j Bsy08uqDMekXP3ZbsUWX4EUbiMcl5a0k3rHmxdmI28MzITey20//n7y3fsqF2HR1ygSd cOrXJU/wywHzH+WAgln8wwsp6z2lFDUoeclgUSs40ZXfbNoK9w1aDqkvhpU4xOyAU3w2 8hS8hQUKW0uxqZyC16WFBBgHkTQqSvu6mmjJFMX8VK/P/o7wNx9OEiEjW25VBQdIIxnT ES1w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Jze1M2+d; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-88439-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88439-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id gu11-20020a056a004e4b00b006e3b0284fcbsi3451130pfb.346.2024.03.01.05.12.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 05:12:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88439-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Jze1M2+d; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-88439-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88439-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D4B5D282775 for ; Fri, 1 Mar 2024 13:12:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F32E96D1B5; Fri, 1 Mar 2024 13:12:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Jze1M2+d" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C5F0138C; Fri, 1 Mar 2024 13:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709298727; cv=none; b=aPHJTtynUryIuNwrjBSlS7g+gaEX5gWLX3p2swcrt5VkYwloyaffxrID8pI4cDnQ2L8L01MwDAuPczliDQLkFZT2FLhTJ4n+XXjJNQTmCFm8tZiLsrC7bokCCOqmMBmqSvYbC/GzGPw3+Q9D7agQCfJZosU4obDUBMMzIUZ+XGA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709298727; c=relaxed/simple; bh=FqHEPmazeGZLSdmw3+8lxXDZ2LpYgX5OJCWLme3ZdSI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SyZnmR9n3IrCSrzp6GymBoN+YkJtfz3flgB20GtX/SYW9dxsPZKje8yr6hmKsZ3LIY7xzvHjEBTLAZqWKaQVV5WAiG+LcDs0kjub8P0Jsee/gcMaIIdDLvIqrFfYV+KgDJoHVujnZnUs2O8b4qWXYuvUmnnwmGPorb52Fek1onc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Jze1M2+d; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB442C433C7; Fri, 1 Mar 2024 13:12:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709298726; bh=FqHEPmazeGZLSdmw3+8lxXDZ2LpYgX5OJCWLme3ZdSI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jze1M2+d4/5vULXiqnomgWl4IdzhZznl1mil4VvcV5A6F8iXoQwgONXbah0SSmCow NvF5FqBiD04IfUCsk7/HoAlk1EG+xZnAG3p9do2BSc7QcCd4khszCpa6J4kfFzKPc6 yHxr7I39UHt8F3r5vL54YWQt+Qu4XY80VBV9UB6QfX3sAJl7ZMd1qsY6oU4bxXg9oo wtm6a0Y+45zg+tGmOtvJNdn/Kna/WeSAYXecje30MxNZQBAA0t/ah09RliC4450EK/ F6nMqnBWaWDmZDjMjcvOURVZBsDzCXF5tDqDkZXZZAyYNQ2seWnkov19iKe9SVobKj rL5qSKiQbFOGQ== Date: Fri, 1 Mar 2024 14:12:01 +0100 From: Christian Brauner To: Luis Henriques Cc: Theodore Ts'o , Andreas Dilger , Alexander Viro , Jan Kara , Miklos Szeredi , Amir Goldstein , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] fs_parser: handle parameters that can be empty and don't have a value Message-ID: <20240301-abheben-laborversuch-1a2c74c28643@brauner> References: <20240229163011.16248-1-lhenriques@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240229163011.16248-1-lhenriques@suse.de> > Unfortunately, the two filesystems that use this flag (ext4 and overlayfs) > aren't prepared to have the parameter value set to NULL. Patches #2 and #3 > fix this. Both ext4 and overlayfs define #define fsparam_string_empty(NAME, OPT) \ __fsparam(fs_param_is_string, NAME, OPT, fs_param_can_be_empty, NULL) Please add that to include/linux/fs_parser.h so that it can be used by both.