Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp305328lqg; Fri, 1 Mar 2024 06:00:30 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVBwWiGRJBmYIkpj0CWHT5xSlQyzl05XeXYS4KcRobX9VRrBpNK4uuQDMZk69GVIoWxc0yy5epEILkQKoqGeWo/Ct+UdFUQum8dgWufFQ== X-Google-Smtp-Source: AGHT+IFg/lNA040SrMUZCuPD6CdH6FWAgmXgZ+UmoFtUMOmBi+gFSqFwYv+sINYSDX8+MInDd7GP X-Received: by 2002:a05:6a20:c524:b0:1a1:25a:b779 with SMTP id gm36-20020a056a20c52400b001a1025ab779mr1308547pzb.43.1709301630071; Fri, 01 Mar 2024 06:00:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709301630; cv=pass; d=google.com; s=arc-20160816; b=SIOt/9UQgPo/ECfBLWaxIZvWxkI7ISWRVnanMLianAUCho4nG+s19eej7LN+38GELW 2BPZxX+kHwOCbKAqkWhZqhDG4hYUw/PU1sMU8T7FszItfFg+F9n596Llyone1RaieZxI 6YKtAXJ6OTlpS7fjuAUF9vzp36dPJjIy5CIsKB7bD5SDBSGQI1fp7XnHz8qqCvjLiYWc g19c0R4QabO9m2FD7ktbD/DlULISTASuGezQNjlZUpDqBmKjvIz8Yb2CMLc02UBF95gn nxQ9xb0/vRf12uDzm1jbkim7tBbGNDzrNhAPCUq6AwQUWXNTn8kF733pJBPoRfNxnMXg xwsw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=lt7udYsocuVhKxHFS4ifPlstkCMspm0P7cqn/fPP8AU=; fh=8QsD1GaahBbbkmpKiQmjs2jIdzB/wIjEnPgFs70yCMU=; b=nBHvnZXb89CVHsUgYfejJ1m3eEXXTGHbqjsumA/p2PVmeqKtVMAr7+krOESvNm8v+4 Ypn3k0BPe49lMcDpycDxJBmuXgSLg/gWFwFsX8Tl20wN3ZVW7mlVM8Kmh3obFfs8lmLr VR1aVSAMamDHkHqcwd6U2ZKaCuTWyrnojf7dmYCBwfpE/8O8OTMEtogpN9eXUozdKOjs r2zcWi9G/sOyrDTh+JFfpuUUEA54/eu5kq8D/UmvHgrpj2Uo8MGrzRLy4YlHelDEYLcu Sz8A4/vu2EgTZG6GrUTupJk59moxwx70ZK1M3VTx9nObj1jqjpjm0I3dbW14/e7Go+os QSJA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=VEsMCUKB; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-88527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88527-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id fb32-20020a056a002da000b006e138abef62si3624566pfb.152.2024.03.01.06.00.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 06:00:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=VEsMCUKB; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-88527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88527-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9F0F3286F09 for ; Fri, 1 Mar 2024 14:00:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 198D36EF16; Fri, 1 Mar 2024 14:00:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="VEsMCUKB" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDB765F84C; Fri, 1 Mar 2024 14:00:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709301619; cv=none; b=HDXnAXBHMPghVPaXnPaFR2qmc0Z9acSWPhh5FBsZVUumPPakh7gEfA/gbo3fwmkyVKGorScUMDe2xViIqSVLGbUn26cJJRs3/T1T3VBFRw8WbVMaJIe8IE78i5JO0hjKDmcJ1qS5wc9fv5MlaeWu8SB2GO45c/qWW3/SB0zSr6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709301619; c=relaxed/simple; bh=Uwm4z9If+tkCUKr8I6N3lywyOJRH6O9UKwPft2Dlxs0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iwmd8loJ1F06dRDhlAGbCNdRv9cmnFi6BKSJbPk30kw5I3rxmfesGu48n9Leptavgs4TjfN3xmU1oLr4RH/rACC79ut5lh5/cdVfY7KDCtUIl4q+Ne0KWP+HSYpk8EaVdi7l6LG/w5e+fbzLrdMFFVE3AzR3Xf18kKVj/fart9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=VEsMCUKB; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=lt7udYsocuVhKxHFS4ifPlstkCMspm0P7cqn/fPP8AU=; b=VEsMCUKB+WhD2pxB/+erGT/mHN IvTI5J2+LH0v2cRGGXVk3E051GWncATp6v5s1ZgNynJhqXaclaud3WIfIXV3KToDE+hUv85jfqDVB 02zFW4w4eQX7GMzCAufwskR/ZUX5OruKoN96GbOzTrJx3nW5b2acVijbV6uBqpzLgBU4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rg3R0-0098kj-Tr; Fri, 01 Mar 2024 15:00:22 +0100 Date: Fri, 1 Mar 2024 15:00:22 +0100 From: Andrew Lunn To: Maxime Chevallier Cc: Bastien Curutchet , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pavel Machek , Lee Jones , Richard Cochran , Heiner Kallweit , Russell King , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, Thomas Petazzoni , herve.codina@bootlin.com, christophercordahi@nanometrics.ca Subject: Re: [PATCH v2 6/6] net: phy: DP83640: Add fiber mode enabling/disabling from device tree Message-ID: <7d70e512-ce6f-43ca-b297-fd3397469276@lunn.ch> References: <20240227093945.21525-1-bastien.curutchet@bootlin.com> <20240227093945.21525-7-bastien.curutchet@bootlin.com> <20240301113703.102bbad0@device-28.home> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240301113703.102bbad0@device-28.home> > All in all, do you think that defaulting to copper and leaving users an > option to implement "ti,fiber-mode" is an acceptable risk to take ? Yes, lets do that. But try to make it easy to revert the change if anybody complains about a regression. Andrew