Received-SPF: pass (google.com: domain of linux-kernel+bounces-88529-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Zi Yan <ziy@nvidia.com>
To: Aishwarya TCV <aishwarya.tcv@arm.com>
Cc: "\"Pankaj Raghav (Samsung)\"" <kernel@pankajraghav.com>,
 linux-mm@kvack.org, "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 David Hildenbrand <david@redhat.com>, Yang Shi <shy828301@gmail.com>,
 Yu Zhao <yuzhao@google.com>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 =?utf-8?q?=22Michal_Koutn=C3=BD=22?= <mkoutny@suse.com>,
 Roman Gushchin <roman.gushchin@linux.dev>,
 "\"Zach O'Keefe\"" <zokeefe@google.com>, Hugh Dickins <hughd@google.com>,
 Luis Chamberlain <mcgrof@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
 cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 linux-kselftest@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge
 pages to any order.
Date: Fri, 01 Mar 2024 09:00:33 -0500
Message-ID: <2ED5C25C-FDB2-490F-B740-E413E8186C12@nvidia.com>
In-Reply-To: <082e48c8-71b7-4937-a5da-7a37b4be16ba@arm.com>
References: <20240226205534.1603748-1-zi.yan@sent.com>
 <20240226205534.1603748-9-zi.yan@sent.com>
 <082e48c8-71b7-4937-a5da-7a37b4be16ba@arm.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_733E91E2-3397-4C86-9CED-883987CDD269_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VlRtaGl5MVVNOGZNQ3pBY1JkTzAzUnJXL2M4RW9YMERWaEZTd3dLRE40NDl6?=
 =?utf-8?B?Mm1KYWVFQk5COVRSOUVCaXdycWtWK0NsMldMZi80QUx0elZZV2xzNDVZVTJI?=
 =?utf-8?B?N3dqZEw1TjE4QUFjdXR1UmFLR1RJUG1UTmh0aW9rQ2xrdGhkQk5vZHVRK0VI?=
 =?utf-8?B?UnlCOW92N2RCNTg5M3MxbUI2aDkvWndqV1M3VWpob1loSzhkZWlmUFdRTlVz?=
 =?utf-8?B?Rk1EK0NjN24wQTBWYUtDTkluZllRemZEaHB1ckFPaDdGSm4wWTJ0TFI0LzRn?=
 =?utf-8?B?Zis3NUN3QXJLYUNOSitndTdQbG1sYklwTmlmRkhnTTR3clh6dWVVMVYvc0Rh?=
 =?utf-8?B?ZWlQencyRnVpRDJxaFZpbFVLM3BNeGFsaklCeGxFWjdtSUNkOWdnRUR3cUR4?=
 =?utf-8?B?SGpXRmZxaWRPQnlLck5vTnphcTlrUXozNC9QbkJtaGlJQ0ZBaVNnUkJHdkRa?=
 =?utf-8?B?NU9FMGloUkF6NUdQQWF5Ri9xUlZHeHk2NEpCZ2VZNDdiRlZCaGlRaUY2TUtu?=
 =?utf-8?B?ZmlvbHlpUy9tOWtYVThSZGhNMFVPWmtHSWhRbkJtZGprSHpjbmlkSTc5TmtR?=
 =?utf-8?B?d3pJWmcyWHFnMjUvTEc2VVZpRUY5WiswNGhpb0RtZnQzYTZVNTl1K1FuVUtj?=
 =?utf-8?B?Y2NMa3EyWlBjcnpWcjVaRzJmeDZEK2RXeUZET1dXTXU2T3JpTWcrYzR6d21J?=
 =?utf-8?B?MVdCd1Q3TERweDlsUE1Jai81dDM1bjlpZStYdU1ZeUQ5VTVHRzU1RG1GYUJi?=
 =?utf-8?B?U2tJUkFBRmFwZk4zY29HeEM0UWt2Z2swSDYwWm12NENxSTZzNTdFYm1CdUhY?=
 =?utf-8?B?dUpTMjRhQkZkbFJCNVB6V1RtVisvQXNQS25rbzlWcjFhbkVoRDVGOUk1Wjkx?=
 =?utf-8?B?NVhnWFJnMVh1Zml1SU9JRncwWEpwMXVDYjN5Q01RTG4xNXZZMnFyd25XUDV0?=
 =?utf-8?B?MitaYXZobUMvMjJxbExmc2VwWm5BQlNKc2pBcVRvMkMvUDRKK0llTG5xN0Vh?=
 =?utf-8?B?NkFuRG9HbmV1c2MxV3crcG9kNWZ6Z0o1T1M0UFNNd1VtS3h5dVFaSWJBSS9E?=
 =?utf-8?B?bnM0R1grMmMrM3EwdUdmalUxK05NSE9hUjYrZGp0dk96YVNGVisxZytuUmJK?=
 =?utf-8?B?QWlFMHNQWk9HNmFsWUpOSkZGcmg3RVhtL1BrcVhiMzBkZEcyUXhzb1J4YkJO?=
 =?utf-8?B?RVZxZ0JwaXVHbDdjN3dnK3ZEbUd3dUduRXFSQXRVdG1YTGZhNkhSdlFvbVFo?=
 =?utf-8?B?NmxCa2hWeVp4L1pMNGN1K1V4MkhlUkZwL25PSm9TRXFsL1JiTG05TXdxZjBG?=
 =?utf-8?B?U1dYQkxHV2U3MWwwUVVZVTRmd1N4ZkxzbTgrRmxBTldSNDNhWHhaY1h0dE53?=
 =?utf-8?B?VEJKdU4zQUJETC85M0E1dzVScmZKWkFaVnhBbnFIU2dlN0RsTndNYStLSnBM?=
 =?utf-8?B?cHlmQjBWTk1nVlM2MmF6aE1GQ3JXVEQ0YUlOMUV4NEdTSDNSQzVWclU1REw2?=
 =?utf-8?B?d1hyQmM2eUNhZkhWU0tPWmRxNlFxb0hUWDIySWdzSnV5RWIwVVNPT1FUTTB6?=
 =?utf-8?B?Slg5TmV4QkcyR0xudFJIeVkvMEVmZVdTdWtHUnc5VHNha0ROOHp4RXJyV0VN?=
 =?utf-8?B?SUhQYTZ2VzRWZUo5TGpQL0NOd1F5QXNibW14YXR3UXRmcG5JamNXWmNJZlpw?=
 =?utf-8?B?dmVsbjhmcVZra290cEtubCt0RSs1RHVmanAyNWJ5TVU5MTZEN1p1R2UyRXN4?=
 =?utf-8?B?amVKY0NHVlNJNkJMaUJGallYVEdHa0hMY29iVDA2cW9qMHdCZEYzU0o1TXdj?=
 =?utf-8?B?TXdObU5QeFJYeWlVcW5EMFBDcHNDd0tUVWhyQklPak82SnlEQzVvUDFJa0NO?=
 =?utf-8?B?TThjWkNaL3N1VTZaVWl2MUtGbElhazdXdC83MWNiWENEbFB5WUxqUVNWbTJk?=
 =?utf-8?B?a3ZXTFN4TGhVa3BrWi9vZXNVVkRGZVVRS1Q4UWM3MVFzUDJQY3RtM1lzdSt5?=
 =?utf-8?B?blZCdDlHYXoxbzVYaFJwVTRxOEZwb2tteWt0anJkQ0pWQXRndlNnSXZEd3pq?=
 =?utf-8?B?SE5RTHA5Zkw0YjI0NURqZy91YzBlTkxDRDBqeUZRVWViclJiUjMvWTJ3eGRY?=
 =?utf-8?Q?EHLgcz+hLkxUEHWquK13d6Vxe?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07be0362-e9c9-45a2-89f2-08dc39f7f7da
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 14:00:35.8956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s9k46kjN2BzTAqjhTyvd3/+xK971g7L43Cm7gJHJ/ICr2hgxbrdOdYEBZcqm/gya
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6929

--=_MailMate_733E91E2-3397-4C86-9CED-883987CDD269_=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 1 Mar 2024, at 4:51, Aishwarya TCV wrote:

> On 26/02/2024 20:55, Zi Yan wrote:
>> From: Zi Yan <ziy@nvidia.com>
>>
>> It is used to test split_huge_page_to_list_to_order for pagecache THPs=
=2E
>> Also add test cases for split_huge_page_to_list_to_order via both
>> debugfs.
>>
>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>> ---
>>  mm/huge_memory.c                              |  34 ++++--
>>  .../selftests/mm/split_huge_page_test.c       | 115 +++++++++++++++++=
-
>>  2 files changed, 131 insertions(+), 18 deletions(-)
>>
>
> Hi Zi,
>
> When booting the kernel against next-master(20240228)with Arm64 on
> Marvell Thunder X2 (TX2), the kselftest-mm test 'split_huge_page_test'
> is failing in our CI (with rootfs over NFS). I can send the full logs i=
f
> required.
>
> A bisect (full log below) identified this patch as introducing the
> failure. Bisected it on the tag "next-20240228" at repo
> "https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git".
>
> This works fine on  Linux version 6.8.0-rc6

Hi Aishwarya,

I am trying to fix the issue. When I am compiling selftests/mm, I encount=
ered
the error below when I run make under the folder. Am I missing any config=
uration?
Since you are able to run the test, I assume you know what is happening. =
Thanks.

vm_util.c: In function =E2=80=98__pagemap_scan_get_categories=E2=80=99:
vm_util.c:34:28: error: storage size of =E2=80=98arg=E2=80=99 isn=E2=80=99=
t known
   34 |         struct pm_scan_arg arg;
      |                            ^~~
vm_util.c:41:27: error: invalid application of =E2=80=98sizeof=E2=80=99 t=
o incomplete type =E2=80=98struct pm_scan_arg=E2=80=99
   41 |         arg.size =3D sizeof(struct pm_scan_arg);
      |                           ^~~~~~
vm_util.c:45:35: error: =E2=80=98PAGE_IS_WPALLOWED=E2=80=99 undeclared (f=
irst use in this function)
   45 |         arg.category_anyof_mask =3D PAGE_IS_WPALLOWED | PAGE_IS_W=
RITTEN | PAGE_IS_FILE |
      |                                   ^~~~~~~~~~~~~~~~~
vm_util.c:45:35: note: each undeclared identifier is reported only once f=
or each function it appears in
vm_util.c:45:55: error: =E2=80=98PAGE_IS_WRITTEN=E2=80=99 undeclared (fir=
st use in this function)
   45 |         arg.category_anyof_mask =3D PAGE_IS_WPALLOWED | PAGE_IS_W=
RITTEN | PAGE_IS_FILE |
      |                                                       ^~~~~~~~~~~=
~~~~
vm_util.c:45:73: error: =E2=80=98PAGE_IS_FILE=E2=80=99 undeclared (first =
use in this function)
   45 |         arg.category_anyof_mask =3D PAGE_IS_WPALLOWED | PAGE_IS_W=
RITTEN | PAGE_IS_FILE |
      |                                                                  =
       ^~~~~~~~~~~~
vm_util.c:46:35: error: =E2=80=98PAGE_IS_PRESENT=E2=80=99 undeclared (fir=
st use in this function); did you mean =E2=80=98PAGEMAP_PRESENT=E2=80=99?=

   46 |                                   PAGE_IS_PRESENT | PAGE_IS_SWAPP=
ED | PAGE_IS_PFNZERO |
      |                                   ^~~~~~~~~~~~~~~
      |                                   PAGEMAP_PRESENT
vm_util.c:46:53: error: =E2=80=98PAGE_IS_SWAPPED=E2=80=99 undeclared (fir=
st use in this function)
   46 |                                   PAGE_IS_PRESENT | PAGE_IS_SWAPP=
ED | PAGE_IS_PFNZERO |
      |                                                     ^~~~~~~~~~~~~=
~~
vm_util.c:46:71: error: =E2=80=98PAGE_IS_PFNZERO=E2=80=99 undeclared (fir=
st use in this function)
   46 |                                   PAGE_IS_PRESENT | PAGE_IS_SWAPP=
ED | PAGE_IS_PFNZERO |
      |                                                                  =
     ^~~~~~~~~~~~~~~
vm_util.c:47:35: error: =E2=80=98PAGE_IS_HUGE=E2=80=99 undeclared (first =
use in this function)
   47 |                                   PAGE_IS_HUGE | PAGE_IS_SOFT_DIR=
TY;
      |                                   ^~~~~~~~~~~~
vm_util.c:47:50: error: =E2=80=98PAGE_IS_SOFT_DIRTY=E2=80=99 undeclared (=
first use in this function); did you mean =E2=80=98PM_SOFT_DIRTY=E2=80=99=
?
   47 |                                   PAGE_IS_HUGE | PAGE_IS_SOFT_DIR=
TY;
      |                                                  ^~~~~~~~~~~~~~~~=
~~
      |                                                  PM_SOFT_DIRTY
vm_util.c:50:26: error: =E2=80=98PAGEMAP_SCAN=E2=80=99 undeclared (first =
use in this function); did you mean =E2=80=98PAGEMAP_PFN=E2=80=99?
   50 |         return ioctl(fd, PAGEMAP_SCAN, &arg);
      |                          ^~~~~~~~~~~~
      |                          PAGEMAP_PFN

--
Best Regards,
Yan, Zi

--=_MailMate_733E91E2-3397-4C86-9CED-883987CDD269_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXh34EPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUkIoQAJVaEmpOlSOcfeJpEDI92YVEksQHkSmlCMy+
SFkfW7DjWABKWjhoY4sL/vv0Lt9mkX9TeHdDEXh7austZe2el7B2dEJUa2QL+5PX
Ltes2IRj9gRpLuANv6mUQvE6S78Tx/xtaFge8Vu75cLIgQqQ10pwnyoYWvmMX1sC
L9NlALQ9FyypJnUQRt8q4sKSCIEPWlJlcWwaNTjZeHI04IuxU31YdpxEknQ9uhj9
X8j6SSvbOraXitE+jbZcnXaLQwAn4xf+W1ZVID8wtPzSyFoC9IQTJCs2z/l/sOul
wseZYryqQtP5tJr8giDXlqRz603RZAfl95qiG2xtn2lit1SXy0BmTcg9AicdjvkL
J8zCdt7Uf1JWI+2zfBcwKNk5fe9urGrmuZUpXWIGtq/sizcxqM7AQnKZlqiTwRrI
10JvtLbmysfpu1/PReJPlSRhEfiB0Fxw3c48UGXygiHLipXFs2zWPlUszgjXs3JW
/A0O9oV3zpRDNL1PJrQKr9Yl4KYfkb1m+hurFWSeYkenvMXnCCwApHMvQnnc9rl2
UCLdJ7d9wG+tyjQaBTNXh+dpFgBwnIBrTbuYAS+zuKVdm7+9cT8a3EOO/AsyywOE
Gf6AWfVJs33roAw+iCXqvf9VMN3gBK3RhTEn5hzRCk9h5LJc9IbJQ+VvyKHssdUu
kuUFA5S7
=5Ey1
-----END PGP SIGNATURE-----

--=_MailMate_733E91E2-3397-4C86-9CED-883987CDD269_=--