Received-SPF: pass (google.com: domain of linux-kernel+bounces-88537-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 1 Mar 2024 15:11:18 +0100
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Yunjian Wang <wangyunjian@huawei.com>
CC: <mst@redhat.com>, <willemdebruijn.kernel@gmail.com>,
	<jasowang@redhat.com>, <kuba@kernel.org>, <bjorn@kernel.org>,
	<magnus.karlsson@intel.com>, <jonathan.lemon@gmail.com>,
	<davem@davemloft.net>, <bpf@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
	<virtualization@lists.linux.dev>, <xudingke@huawei.com>,
	<liwei395@huawei.com>
Subject: Re: [PATCH net-next v2 3/3] tun: AF_XDP Tx zero-copy support
Message-ID: <ZeHiBm/frFvioIIt@boxer>
References: <1709118356-133960-1-git-send-email-wangyunjian@huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1709118356-133960-1-git-send-email-wangyunjian@huawei.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NiTGaq+F0r7L+WTypT7ycj6jhu1Hw+rQiQ8D2Ihz5uim/ADWUVnIs767hthb?=
 =?us-ascii?Q?T5yxxnG0uNJpH0SHUKTmathIFIieONj2NfTcIqZ1b6zhlGz73ElEqonNh3tN?=
 =?us-ascii?Q?a9AnbsR7zDwla7CI1zrysi5h6s3b6rymQtxhpxvVQEO6W95xFT9bMrBRvy2o?=
 =?us-ascii?Q?R25qtfzLstWgQoicb39uQlPOhebJx1MuNW8vXsTICly7d8tTnYMtBOFl0Y7h?=
 =?us-ascii?Q?hgGmCTG+BPEciO3abhCk1Nz66iZiny50s0dcjhDFZzgGBDAmJz+2hL/psmOC?=
 =?us-ascii?Q?nV673D3seKPtpbmBr4foj96jQuMvdQ4MA6DksaRxFcAKO2fUU4cIDNPbo2OD?=
 =?us-ascii?Q?glvW2icfbYe2bcIFBLzD0ea4dEzJOKQc/E9a9edwDL9WS9j+5xDKieDYAxRA?=
 =?us-ascii?Q?pjCF7k2j5RLFmgqSe39hJlqmVuQ+Fqq/Xry6Q5cW0C9AIGHkJS/WwVzIg01S?=
 =?us-ascii?Q?lbYniQwgWkXQZEay8yrx13qcCB6O+9PGpVrqqomtS7daX/Fsi30fL2tgHvXe?=
 =?us-ascii?Q?G4j6fwGAhieAHxeubL4l6BGygxP0q2Qhoidb8rIUSnRXPx8Pt2TutFbHcMjm?=
 =?us-ascii?Q?cn/PydoWv0dhyrTL0vXa1xevmi6xYyWhB8mYhiy+CcLncEJtYdgRteiNBDlK?=
 =?us-ascii?Q?2XU0qP5AXrAYvNJe6/mB4pqLKgZTdmkoRpmSsYIWqs3Kr0GfzPx79k/7t0U4?=
 =?us-ascii?Q?Aj8obuvk5LntcjJP0qv5PZ7eFcUfLB2/CnJ3KXT8MvDng+Uux+zfGkbHJ7e1?=
 =?us-ascii?Q?renmVzM2eBwUg2Pay6Sm/psED3ziPuW1nsSfdICKVwNaucD/QR2FIDk4gMFa?=
 =?us-ascii?Q?ByjZRB+gdeYcX63sdJd813e9iRgHNWxl5X6QmzW3c1e16DUPQx7XvrsoVGiq?=
 =?us-ascii?Q?qcxV31ujWpjvjhZOjrEuoa48aEWo+2fr2BBGvwp+3q37kqvWBcFhnvMWD+NH?=
 =?us-ascii?Q?5BpmKXNwoB8E7D1z2taJtJYRnbqcoD1ckOvXLucguXdmICcQ4Jg5jiwsxWUZ?=
 =?us-ascii?Q?VO//BKHbvi8iJBYrWgRu3qXc9krGihUVMsexO+SY3J5kfIZaYkzVx67QJqH9?=
 =?us-ascii?Q?K9VIVDoEXGn/rwWl+4cAHowIYY2bdxlgM1aCTRCALDW/MW07reIoTAPu8xll?=
 =?us-ascii?Q?SuX9HvfYmd5CbJZGuT9IHfooEA7ECWuHX1LPia4m5MgnfDQGJHw5xNfSB7wR?=
 =?us-ascii?Q?MhxJbn1U/uHv1XjdjLp9S7br3oPoGpTlbajAQgJfL86GNzHIw8PGAxmnXDwl?=
 =?us-ascii?Q?PhRDNI0Cqdj8IRnWw4eSmDjFTC4XFLDS8nw4eh9L59HK7DVyrxhawpwpTwMp?=
 =?us-ascii?Q?s2TUEwTRoz6aZOBJ+TYDaKILHkhIfIwNs8G2YCoTmDVRHctXXfRcztyubTwA?=
 =?us-ascii?Q?7yiOdpgnLVIEs+t7aCi4fxwMYRNX0/oqKhG19SVwaKrJafhvsQLew79hGaSR?=
 =?us-ascii?Q?1P/TrRKGijAOioJ67oO9XSBJZB/KoCq7aRLLtdSDzAl8pX7lVOcAHkxVNzqx?=
 =?us-ascii?Q?/VwdSv5+fT+zwkcxsk1MsL4mQRoW6PQP0MVnQ0WVnx20e7LvryBWBEmJxa7Y?=
 =?us-ascii?Q?w79FJwVCNK4P3N7SBbujHL/4gpPakXormFKJsUg4eURPhs77JPoW056nNLuI?=
 =?us-ascii?Q?5A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8336d201-a502-4eab-58c3-08dc39f97a2d
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 14:11:24.0415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3CWgxJTBghRWvkWwvkKD4epe3rFPy8E/2d18lYYqYTGVN4Dk+/IGAEcJ/QDYX3asAXsZ7RvTghhW4E1n6FvgOpf+WjlxC1TPW08FKmJJCCg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7083
X-OriginatorOrg: intel.com

On Wed, Feb 28, 2024 at 07:05:56PM +0800, Yunjian Wang wrote:
> This patch set allows TUN to support the AF_XDP Tx zero-copy feature,
> which can significantly reduce CPU utilization for XDP programs.

Why no Rx ZC support though? What will happen if I try rxdrop xdpsock
against tun with this patch? You clearly allow for that.

> 
> Since commit fc72d1d54dd9 ("tuntap: XDP transmission"), the pointer
> ring has been utilized to queue different types of pointers by encoding
> the type into the lower bits. Therefore, we introduce a new flag,
> TUN_XDP_DESC_FLAG(0x2UL), which allows us to enqueue XDP descriptors
> and differentiate them from XDP buffers and sk_buffs. Additionally, a
> spin lock is added for enabling and disabling operations on the xsk pool.
> 
> The performance testing was performed on a Intel E5-2620 2.40GHz machine.
> Traffic were generated/send through TUN(testpmd txonly with AF_XDP)
> to VM (testpmd rxonly in guest).
> 
> +------+---------+---------+---------+
> |      |   copy  |zero-copy| speedup |
> +------+---------+---------+---------+
> | UDP  |   Mpps  |   Mpps  |    %    |
> | 64   |   2.5   |   4.0   |   60%   |
> | 512  |   2.1   |   3.6   |   71%   |
> | 1024 |   1.9   |   3.3   |   73%   |
> +------+---------+---------+---------+
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
>  drivers/net/tun.c      | 177 +++++++++++++++++++++++++++++++++++++++--
>  drivers/vhost/net.c    |   4 +
>  include/linux/if_tun.h |  32 ++++++++
>  3 files changed, 208 insertions(+), 5 deletions(-)
>