Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp333360lqg; Fri, 1 Mar 2024 06:38:08 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVKNPZiWCwmGS7Uixr8Lvcbcevt8YU5nxYlODDG0fnATOlrqETTPflep1OwX5B7hhXgXJQ2hkWway6aDL7/TIQ/FPsVGMutbCZCMj/UvA== X-Google-Smtp-Source: AGHT+IFm8M/X/Uv9bWDauMT3YvfoQ6h5fqPSzEGiDE9v+715grrk4G/Jf/Dp1drc6uvss1NHhFWJ X-Received: by 2002:a17:903:28e:b0:1db:c536:803c with SMTP id j14-20020a170903028e00b001dbc536803cmr1884802plr.33.1709303888540; Fri, 01 Mar 2024 06:38:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709303888; cv=pass; d=google.com; s=arc-20160816; b=lijAJl83wpCjl9eJq+16rMkPIDp2B6xlyY9ca8AUqgBY8MsM4zKH/JYJt0YbDeCKdW 2pnEpJnt/TU7+p2XthFGlZ4wMpFNs0gXKehroEGR1rPQ7o5tN0k2NAL0lbqLiT1I0Uqx 5x+eSDx001YeYAz6q+WIQJEgh8uF/Qj3RlizzjYFttQ4vwOzcUDmhiSFunh3+1RBO3Fv cdIBLFGRtU6TpRFFetnE7Ef9Drje6JMVb9sByaOqEYH1i+UD6QCA8hUSOfgK2OoTQIhx m8FG9Xe+OX9WCG//NVyVXsBu8rP1yX+kEhHxQk7+bV0XH5yxDvGrQi7yt/ZdKm6aANjx SMng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=NTAwoRrQzLprmNez/+puDmyeUtQ49VPPM3QSNKKkIHU=; fh=Ul9EaZ5TwTBI89DZB8SqxYc+MOJSeDCCQ8yYnLte/2Q=; b=Ld05qmqNneS0EIDjVrvSERBogsNxk7wCANt3dxHKcJoC9WRWWFNvTEx/i0hqgQhEqA wQ5ha0JYRSxhewPZ0i23gUYKuTYvFwz0ix1lngdNn4kyF9avHeC1xFx5bA2K05JgVmsP C4X7ztF/oqn1OkQQhHa0v+KYd2yPT5qVgAGfriQ0jxkDEA0Pogd4Bk+1XrI7HlMaT2xT GBkgOpEISogEghLUzuNYlb/bDrO58yMA0LWcDCDwn+U4QKuJ9SCA0LAVG4SYwRDaMbs2 14tPpKK0wKWAcsSAqQlratYZqggekADumt7skUadnPkR1QJe3v9Tif5WhLSP4xbV2Bf3 ahhA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jLcMwXej; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-88558-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88558-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id e12-20020a17090301cc00b001d93f31a19bsi3801520plh.345.2024.03.01.06.38.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 06:38:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88558-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jLcMwXej; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-88558-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88558-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 24FDD283BE9 for ; Fri, 1 Mar 2024 14:38:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 359E7381AA; Fri, 1 Mar 2024 14:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jLcMwXej" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 484751FA1; Fri, 1 Mar 2024 14:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709303876; cv=none; b=VXJW1sLvHCXIdKt+hylyWboOTdQz1NhWFXczWvsbMpTSOMrSPLhV43oaH+80ItWJCzHkQc5PqPFvLMjyQ6AXv71gxcqfWxm9I+pwzc5Z0bmiqUsltU7iCarne6Lb6QwJ2s6MQ4RicYxvtsyDttJdjq5inBZZ3X3atWpVP8D+0/A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709303876; c=relaxed/simple; bh=2r1Wp3rYCpQCXBRXRGrQRKnkowj3xl49dA+H2NJnMBU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FsLOdZJnR0DV8Qve736fQ5+A0a6YjzsgbW0lMYHFdmFo8EqzqABdcPjgUst+jTKh6QWoPgIvVFgi0wrpAor2x6mbZt7trGSQ8Y0a7/jgC8CmcB3ur6oNYKxLgSkDDhbTajXOFQ0TnGI3n0hnFsarBhn8Ubs5k/gVxnQIJBMr0+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jLcMwXej; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4500FC433F1; Fri, 1 Mar 2024 14:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709303875; bh=2r1Wp3rYCpQCXBRXRGrQRKnkowj3xl49dA+H2NJnMBU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jLcMwXejD/CL3+8qjIs5Xj3U6dmo915+bS91i0UNfhbY253V+tu4oVODlVblYPfIK kBbJyaJFzSnPbMfHsBljKPLYaDqhB5LDPn9cjmmFucHfOs97juG4NLacHkyaeXJFnq KRzG2NgL8sxQCK8gpLrl56up+kw9N55G/Tw7S1zvNyQomdVACQLEaeAahE2nupVWHp Yt/4BL5t28vLoTWaClOc+rBGN1zQqc0b29ciA5scV8eXufEMsPJvjdKioJRV4fyHew 6XY8fr7/coD3tETytB8GrViKeA/CBmmcZ5a0/ZuEjsCBnL3FrneePy4UPD8aV11hWZ Yb523th9q7o6Q== Date: Fri, 1 Mar 2024 06:37:54 -0800 From: Jakub Kicinski To: "Matthieu Baerts (NGI0)" , Mat Martineau , Paolo Abeni Cc: mptcp@lists.linux.dev, Geliang Tang , "David S. Miller" , Eric Dumazet , Florian Westphal , Kishen Maloor , Shuah Khan , Peter Krystad , Christoph Paasch , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net 10/10] selftests: mptcp: explicitly trigger the listener diag code-path Message-ID: <20240301063754.2ecefecf@kernel.org> In-Reply-To: <20240223-upstream-net-20240223-misc-fixes-v1-10-162e87e48497@kernel.org> References: <20240223-upstream-net-20240223-misc-fixes-v1-0-162e87e48497@kernel.org> <20240223-upstream-net-20240223-misc-fixes-v1-10-162e87e48497@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 23 Feb 2024 17:14:20 +0100 Matthieu Baerts (NGI0) wrote: > From: Paolo Abeni > > The mptcp diag interface already experienced a few locking bugs > that lockdep and appropriate coverage have detected in advance. > > Let's add a test-case triggering the relevant code path, to prevent > similar issues in the future. > > Be careful to cope with very slow environments. > > Note that we don't need an explicit timeout on the mptcp_connect > subprocess to cope with eventual bug/hang-up as the final cleanup > terminating the child processes will take care of that. Hi! There's a failure in CI under debug after merging net and net-next in diag.sh. Maybe because of the patch which lowered timeout? https://lore.kernel.org/all/20240223-upstream-net-next-20240223-misc-improvements-v1-8-b6c8a10396bd@kernel.org/