Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp381475lqg; Fri, 1 Mar 2024 08:00:37 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUOAl+09IiTEBEf1QNVCuGGbsqOJW0rbPuJlf4h58D8L2pQ1UZs6PFOZ3moZt6PZJ3/s0ieYeODsVBrdmk2uCTS7i0PM64qFn4i5T7TKw== X-Google-Smtp-Source: AGHT+IET9pUGp4kENhmPq4T8nvf6Yb7Aj4yet88d/VezVk15lNufrUzjWe5AsjTkvb2+pH6QWkwc X-Received: by 2002:a05:6a20:7485:b0:1a1:440c:1c9c with SMTP id p5-20020a056a20748500b001a1440c1c9cmr114935pzd.14.1709308836227; Fri, 01 Mar 2024 08:00:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709308836; cv=pass; d=google.com; s=arc-20160816; b=htkYL3/qC/G9IbkmmIKcxzSik9Uvtd2GivWSwDFWpIt01dpJNjtgtxej7ywN8NAPDs 7ppSsDebbwNj8/behegw4vyiyziAdcYtUUFysXIEFQP0bxH6W4xUF4eCsu0zvlpqzcRv C6T+aNkHPIoqmL9pIo4xTsB6CTqxiZQe4Z7wJWyrEDBTCYadpbIxiT2ptNVP8qslkwtc 9D1qt3ZjrLIUFthrjHziB2U/cxSAuJqDlMrWMj0IRhqe1oH3WrfjKnX+17muB7Fv2PdO gw1PSgT/4B4mD2+ea7giRsv52MU3rku/ISSTFZVcRfsEFmrsNP0aCHiIqBiPlRD8r/qR 3rqQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HCoomt6/ov7g5YLGcc04xqqZ/wiVmak9ahrqYttYqtU=; fh=7AkZtiF/1+VLVo/ZBEhpBPpzpe8ZIkzVB535JfEirIA=; b=EnJCTFlHBSYBk30pEf+bk7sn0NNbcdZrNgImn//qK2W94P8FgFtuMiBPRxUzQCHqvx GlNCjRJ4nXuYWebvcPmjBs3xNBVlib5X2YelmaPcDmgmZ5f7RbkWG20xU657IzGfP0D6 7BSK0slEQo09/wbk8JnFQmFl6HmbUPzpT/BXmdA2pncAZ8sHOwrv3zJYFZnG00ydtzoE Jfku9SG5mqjjq5YwmG5NHGNf8eoA+HeRH5c9QOzGj+D3yolAC2wjFnpVe1VrIFtzFhei LniaRZIwF+G3caevvD4AweL1v3HN3GcEaU7dq05bLvlLKheRVI8bLv3kuug1u0XRFX7R FL8Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z0dtOfbh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-88651-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88651-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id ft18-20020a17090b0f9200b0029a3c01e4a1si5863021pjb.139.2024.03.01.08.00.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 08:00:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88651-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z0dtOfbh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-88651-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88651-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 7AAA0B239E0 for ; Fri, 1 Mar 2024 15:59:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5C72270CA3; Fri, 1 Mar 2024 15:59:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z0dtOfbh" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84B7A6F514; Fri, 1 Mar 2024 15:59:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709308770; cv=none; b=LpW+KiVanSknrJvelQrPY1t9Y57R7yMzhc0E3jAdKbO6tql/b5Tc6m0eKNjPoQo8j2nn0ubih8y8w+f/bly5KjCU65j5Kv6tlXTtZJSeKSEVbD9xnjGukZSKlyS14957GbEsJPlajSIf4yCUOLY+cObG5D9fPMHuV5U3tsoYWUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709308770; c=relaxed/simple; bh=AW5LPaRLd2WNob7gDn7GgQ9g+WbaQ19KIWIJ95J0jgc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TaT4NmSHjPCnqMT7uco2It7uXTMfM+Rc+cw7Cj/atIfhZhV/nQtx2UKpa4x1Xw4S67k7BDp/5ZER+eut9CrTzUpyiWo+jl3v/FHv/FnUcBOIznx9ofhbryO9A5NIAzPsmExn90ikUsJ06Uq1XSC5vonQytc+65vP4E4/OBj0wRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z0dtOfbh; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5374FC433F1; Fri, 1 Mar 2024 15:59:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709308770; bh=AW5LPaRLd2WNob7gDn7GgQ9g+WbaQ19KIWIJ95J0jgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z0dtOfbhaO8lem7tDOvoCmQfcsywj82P6xs0moIMHwJdDz/wwyq9ZzQO1uxJ52mrm 63JDKTQw9TDJlF3OijmdMN7RM6r1k9lAF6Twa/BAhXJjtw0X4CRvCJ/h5gcrWDTHn2 b+uVf4HzFZJFXz6hf5Lq8zQ/o3cSu2U0sXeKXa0jH9wuBpGXQ3Kf9xk7ruMW08ZF1H bAVRp90X9v8Zp9BIGul4llRyV4Il700lBGlIgLuh7K2SlmLuK8bRgLfRqclXi+b9rC /wnZz4yoeiXFZuHzVYahqAh0E5dtZHI2yhFFz8F8rjTChKje3uRxM9vAIsEJA4iB3W hU0953AmDlIXQ== Date: Fri, 1 Mar 2024 15:57:56 +0000 From: Simon Horman To: Breno Leitao Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dsahern@kernel.org Subject: Re: [PATCH net-next 1/2] net: bareudp: Do not allocate stats in the driver Message-ID: <20240301155755.GD403078@kernel.org> References: <20240229170425.3895238-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240229170425.3895238-1-leitao@debian.org> On Thu, Feb 29, 2024 at 09:04:23AM -0800, Breno Leitao wrote: > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core > instead of this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > Remove the allocation in the bareudp driver and leverage the network > core allocation. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman