Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp387657lqg; Fri, 1 Mar 2024 08:08:24 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXcDptDVNTun4AVfKTfQqBh59WCy9z3/CecoL0Xh07CCsI21iKQOwXjbcsWWKfYU0paN+p71Dk6/CCdp08fzRjtM+jGDuQ2dq/hmZNRFw== X-Google-Smtp-Source: AGHT+IEAGXRsiogG9c2x6yi6aE4lAtHv3RMXBcfMuFhGE1/4kOZhAElIQ9HNMM+EgZ9QJBCIoliK X-Received: by 2002:a05:6a20:3c8e:b0:1a1:20c0:907a with SMTP id b14-20020a056a203c8e00b001a120c0907amr2985086pzj.29.1709309302567; Fri, 01 Mar 2024 08:08:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709309302; cv=pass; d=google.com; s=arc-20160816; b=OpMS3vKm6highv1wDuBYO8eeppzftU5xSopI40NXgmSYrzCtJvYkB1/F2u5LApO1EC W84FIvuXwuwOKA06v1l8MM7n6+neN8FMCxgeD6FtPBGYAUPVXnkVTeZMksIQbvl1GkOP bRUjUlyFKBaJFcjWCW1pirjL1ieuV+Bw+RItldB8gKoLYDLdqtm5DSGmy3EAuUWVWgSr rf5PeVwPyGXbI7IUzTD62Wzx/SHLKaCzLHuDhEcjKqh5pTwIQRcpcNSxFEGKaL538Pyo xrbmeY3ij36Nq9Znovam1CDf/GUP+GhdDNLK+ZRztn3C7ND26QVRbCYKfG33lIpeHqZM 96+Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CMAUzh1WTbCvCoj+McFML5yGKFdIP8sZLBH4A5Tb+ak=; fh=7AkZtiF/1+VLVo/ZBEhpBPpzpe8ZIkzVB535JfEirIA=; b=cwKqZ8v2Ew7gh2dRneHPA7LzzfOxKdp8N5+ge4wgi0vn4IukibehcqNyMPXyDpilj0 RExwR4wLAeqdvx0+WISraQ1uD7l6shrJ69oBJ6pkZwAnAknh8VqAPJbDWdpFKCpaCV2w 8EnHoPneGJAePh4O4ahDURrMZohnon6Of9WwzmYoUhRTWG6Jccda1jCNaue8eRdJKGan JtaYMDV53F7UVMo/60so2C171H1rsnTOT7uBa531Ca7+wVqq4Z0a9VGmBRO5iWjOVr25 PA+nVwg5Tzf3QnpfOPyfHYdoj9/qkbgwTE40w887UR1k8ouzy9NfWh/OsW8E7U+SOjX1 wTSA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PSjmfp8H; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-88665-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88665-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id fb23-20020a056a002d9700b006e544ff9109si3800987pfb.318.2024.03.01.08.08.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 08:08:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88665-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PSjmfp8H; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-88665-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88665-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A7D44282051 for ; Fri, 1 Mar 2024 16:07:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B361670CBB; Fri, 1 Mar 2024 16:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PSjmfp8H" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE3C62B9A2; Fri, 1 Mar 2024 16:07:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709309266; cv=none; b=QZpCODaQqWabBTTEVz9bwNKmxNZRocdIlRBO++I2d2quA1hXSpOv7oPtvCHCS9EHssROFcOmnZSIMyEc2AZokHHFhz3bj+0DsLO1UOHyKXyzX5NWxeFh71VWqsc0HVrYWGMuBBlYc0gFjq9ASZSsiV7vuvYHunFUfAw8QI+NuGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709309266; c=relaxed/simple; bh=r5ZXzcZeCkOjmfND/rIB79uZUfs9DOwUBsUxs0F34pk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GY+4dXCGAPuvRwao+TfpIdgbjFO3Mr80wqOpsLYNKR7T553ojhvQtBTq/npyVtSTgYBV4jGeCjBNuvTv/HlA8yxOLQ/p+t5tzB8cEWeO5BPgTI6mZ4ea6GCXdvJPVvupgqhdo2rXhbcn4VcCqBAWl5j/z9uxudJODuUDw2WG9Ro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PSjmfp8H; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA63FC433F1; Fri, 1 Mar 2024 16:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709309265; bh=r5ZXzcZeCkOjmfND/rIB79uZUfs9DOwUBsUxs0F34pk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PSjmfp8H0pdD32qN+AgFaOhrTjCOYBN+hCoB8PA/YMsW53+LJpfd3sNctK9X4cQbE KnYMOFAdugGjT4jvwMsHuNMRCdO/RwJ/ApUGlffcc5y9D1mM1Gi8JoSnkfEj1+i/8G sy7yWvEaNolOeLD/Y+4RZx8aS2Z/HJQ1E9CdMT1t0WvRWOhHHPDGVUHZJJtQRet7/c HvSGv6JzBHsU2XTHAE8Kv8jjbmI5CV1n+3TSgDi4McsZltepmUPKx5JKTRLhAmxFTh Ip0c1lZiuo4pDTF816V/S+QoFTr+8JbAwchqBmPmvLfs+/2mecflAeeK4JMbJtbHvn 8aQsfD47hTwUg== Date: Fri, 1 Mar 2024 16:07:41 +0000 From: Simon Horman To: Breno Leitao Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dsahern@kernel.org Subject: Re: [PATCH net-next 2/2] net: bareudp: Remove generic .ndo_get_stats64 Message-ID: <20240301160741.GE403078@kernel.org> References: <20240229170425.3895238-1-leitao@debian.org> <20240229170425.3895238-2-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240229170425.3895238-2-leitao@debian.org> On Thu, Feb 29, 2024 at 09:04:24AM -0800, Breno Leitao wrote: > Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is > configured") moved the callback to dev_get_tstats64() to net core, so, > unless the driver is doing some custom stats collection, it does not > need to set .ndo_get_stats64. > > Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it > doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 > function pointer. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman