Received-SPF: pass (google.com: domain of linux-kernel+bounces-88675-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 29 Feb 2024 20:33:04 +0100
From: Larysa Zaremba <larysa.zaremba@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: Jiri Pirko <jiri@resnulli.us>, <intel-wired-lan@lists.osuosl.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Mateusz Pacuszka
	<mateuszx.pacuszka@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com>,
	Lukasz Plachno <lukasz.plachno@intel.com>, Jakub Buchocki
	<jakubx.buchocki@intel.com>, Pawel Kaminski <pawel.kaminski@intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>, Michal Swiatkowski
	<michal.swiatkowski@linux.intel.com>, Mateusz Polchlopek
	<mateusz.polchlopek@intel.com>, "David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, "Pawel
 Chmielewski" <pawel.chmielewski@intel.com>, Jesse Brandeburg
	<jesse.brandeburg@intel.com>
Subject: Re: [PATCH iwl-net 0/5] ice: LLDP support for VFs
Message-ID: <ZeDb8Dr8mBvov9fc@lzaremba-mobl.ger.corp.intel.com>
References: <20240228155957.408036-1-larysa.zaremba@intel.com>
 <20240228084745.2c0fef0e@kernel.org>
 <ZeBMRXUjVSwUHxU-@nanopsycho>
 <20240229072813.5d7614c3@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240229072813.5d7614c3@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0xGeJ5r1XtYQU7QYhgdSNL7z1ZwrElx/jd+0KhS2w8uql8YELYQ8NQ5b1Ghu?=
 =?us-ascii?Q?O3gHC69t3YTKSPL/GTpCQmg3AsanzeIIZ42QJWyuhoCr8s68ePbf+owTGudE?=
 =?us-ascii?Q?ajU6al0W54sVkOOMRb/X7KtBMFHa/ZxMImxg55HLTBQz1DBQUn1OB8jeCuyB?=
 =?us-ascii?Q?wSS9vX5WMeNKHB2YjYk8HxIsCz/v+dA9GLRs8sfSp8QyZfHq01cZhIAv/39M?=
 =?us-ascii?Q?dzPNVCiM8dOLQnlQXQ4jvdI2YPuGi+4cQsmjzZ0GvekmZ/3sC2iLyDQMKwyb?=
 =?us-ascii?Q?F//Y5hSMrUh04wSGoTWDZ/DCq2+ZFiGS6KL8xtIbY+QTQsm+Z3ulH7QlwqWf?=
 =?us-ascii?Q?hRsQ9FFLR8DJ9vxHlD7ILLMDJgbOTueSsdE00rl7JDZjA0Z44Eq1OHRItCVi?=
 =?us-ascii?Q?fyAYhPm17jxBgthS8e96USPhMMpqDk4y8iJ99QEr6KuEU3dgolE/niR2zVin?=
 =?us-ascii?Q?39mC5i8IXlzZ2bzWsUcsuP0leAzRb8zJrOrfNI56eeGedq1x+ecAjcOFGLT6?=
 =?us-ascii?Q?F5bGtNKrlQDVShkMWLQXY/98TrVF+gLZQm04k10ZXI5ZQpSI5S6g7FQBJbTR?=
 =?us-ascii?Q?HuY+wzV09LBMNEZ4RGK87j30OC+Iw5HUNOcZgdDFBzA//U4gkVsnyueRkoLq?=
 =?us-ascii?Q?jpIqw3thfQovISOEva5wgVXiHYpVKCMw65IQ7Cmzfn0xoz+LRmm4Q0umLuWK?=
 =?us-ascii?Q?3PZxGh6fYDiM8/8bVqSQuZl6fjgA/VFsM8zMz2pTjTd56CF9oVDBvsjLKc1F?=
 =?us-ascii?Q?qkNyGw2ELmSN1SbCB3xDIyUlCks30SB4d9ko4qLJUNnvG2rNiDWXX60RTZeS?=
 =?us-ascii?Q?vPmDQvFPdNYoUin9U3gLZsjdgp59zP4uI32uRCBCaMRT2Y57kqtJopOx7LaO?=
 =?us-ascii?Q?SZBZV9Uaqvkqfz3+uTLq4DgxqA3HlS16Vl5wQ5155jZYouGRebndfOL19iIW?=
 =?us-ascii?Q?os2Gp/o9+slSF3yRD+bq51TSi6CMkaAdYY1TaI6ZFU3D+mBdJn7nXCRaWSpN?=
 =?us-ascii?Q?x8elwAPTsqUzq+H5ibv0XQIb06GB308hZ28LZcboVDr8D3R/72QDiDLInnUz?=
 =?us-ascii?Q?yQCm9DHycO19M9fAqbUEqAfj2KNpGFaQIvJIlNLJnDKUd0g6pDcAmXAds/EK?=
 =?us-ascii?Q?VMwHJbGM7ga7dLkweZ92ETvSWVUbZ//Fo7k+HzdnSGuD/1sjB0smuyn6TyOW?=
 =?us-ascii?Q?mHR23vOahA+EQYC6Fqwcpt/wMOu7R4Agye2Sa0EcbEpBdm7gkISd2AvAachJ?=
 =?us-ascii?Q?ELd2aeMcEJYS4I9r/h1WYkYiAv4hlY+oMr9DTh4j6YLscilae+OxyRY367h3?=
 =?us-ascii?Q?y8iaFcWwbitsDCSDEKuIf5N0WsdkIy2yTDlPIvRZwjcjUXtrbrQYZ8wJH/8a?=
 =?us-ascii?Q?0vAyGOXtKiC3hgVw2STDfj4BcDxK0Z8MtdrfiFNtRb9yWyTbupyKOzMtoJFY?=
 =?us-ascii?Q?4wo/thtn/uIBrjO/LZ83Fquhk/zp9CTifg7Mz0X2TD2evFKTaC9/Zf7BfZbb?=
 =?us-ascii?Q?cL0urNuZHnlxyZmR1kzJDGBmJ4AlnRLK5VvYiuqRGRXswitJSU/1ZX/UdUZJ?=
 =?us-ascii?Q?YOi5kSgLXPKwitR6IJltuiwA6Et+o5jFjWfRJABxQkzRUGqlWUD3fGpbV6Lo?=
 =?us-ascii?Q?OA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c81c8ebc-c3ef-4205-bc85-08dc3a0b1058
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7540.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 16:17:17.4860
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2GU6bDOz71QMG3I7wpaVAlO/77sSkafbYy1YMLt7TIzGBMQer1zfwW1hNEa7IJ7caow9fFvBaP4J6WrkxLZy6YzGSsHowRJly0zAn3C5M/M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5270
X-OriginatorOrg: intel.com

On Thu, Feb 29, 2024 at 07:28:13AM -0800, Jakub Kicinski wrote:
> On Thu, 29 Feb 2024 10:20:05 +0100 Jiri Pirko wrote:
> > But isn't it a matter of eswitch configuration? I mean, the user should
> > be free to configure filtering/forwarding of any packet, including LLDP
> > ones.
> 
> This is an LLDP agent which runs as part of the NIC FW, AFAIU, not about
> forwarding or filtering.
> 
> They already have the priv flag, so best to reuse that. If not possible
> we can explore options, but as Larysa mentioned herself in the cover
> letter sysfs is probably low on the preference list :(
>

FW agent is disabled NIC-wide, so only PF should be able to set such flag.

The lazy part of me likes the private flag direction, because just replacing 
sysfs entries with corresponding private flags would make patch look better
while not changing the implementation much.

I guess, treating it like a normal eswitch configuration would be ideal, but 
it would not be purely generic, as there is an added level of complexity because 
of FW Agent interactions.