Received-SPF: pass (google.com: domain of linux-kernel+bounces-88690-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 1 Mar 2024 16:23:30 +0000
From: Conor Dooley <conor@kernel.org>
To: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: mdf@kernel.org, Wu Hao <hao.wu@intel.com>,
	Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-fpga@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: altera-fpga2sdram-bridge: Convert to
 dtschema
Message-ID: <20240301-uphold-numerous-305c3702805b@spud>
References: <20240301161648.124859-1-animeshagarwal28@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="YxSL1ja5VovT/CjZ"
Content-Disposition: inline
In-Reply-To: <20240301161648.124859-1-animeshagarwal28@gmail.com>


--YxSL1ja5VovT/CjZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey,

On Fri, Mar 01, 2024 at 09:46:43PM +0530, Animesh Agarwal wrote:
> Convert the altera-fpga2sdram-bridge bindings to DT schema.
>=20
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> ---
>  .../fpga/altera-fpga2sdram-bridge.txt         | 13 -----------
>  .../fpga/altera-fpga2sdram-bridge.yaml        | 23 +++++++++++++++++++
>  2 files changed, 23 insertions(+), 13 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sd=
ram-bridge.txt
>  create mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sd=
ram-bridge.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bri=
dge.txt b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.t=
xt
> deleted file mode 100644
> index 5dd0ff0f7b4e..000000000000
> --- a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -Altera FPGA To SDRAM Bridge Driver
> -
> -Required properties:
> -- compatible		: Should contain "altr,socfpga-fpga2sdram-bridge"
> -
> -See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic b=
indings.
> -
> -Example:
> -	fpga_bridge3: fpga-bridge@ffc25080 {
> -		compatible =3D "altr,socfpga-fpga2sdram-bridge";
> -		reg =3D <0xffc25080 0x4>;
> -		bridge-enable =3D <0>;
> -	};
> diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bri=
dge.yaml b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.=
yaml
> new file mode 100644
> index 000000000000..88bf9e3151b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
> @@ -0,0 +1,23 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fpga/altr-fpga2sdram-bridge.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Altera FPGA To SDRAM Bridge Driver
> +

You're missing maintainers: (shouldn't dt_binding_check complain?)

> +properties:
> +  compatible:
> +    enum:
> +      - altr,socfpga-fpga2sdram-bridge
> +
> +required:
> +  - compatible
> +

Missing "unevaluatedProperties: false".

> +examples:
> +  - |
> +    fpga_bridge3: fpga-bridge@ffc25080 {
> +        compatible =3D "altr,socfpga-fpga2sdram-bridge";
> +        reg =3D <0xffc25080 0x4>;
> +        bridge-enable =3D <0>;

This has not been documented in your binding. You need a ref to
fpga-bridge.yaml. Did you test this patch?

Cheers,
Conor.

> +    };
> --=20
> 2.44.0
>=20

--YxSL1ja5VovT/CjZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZeIBAgAKCRB4tDGHoIJi
0iJAAQDDJuMdfxauTAhhp+iYirA+jQjOuNlPeCK7ClcoTKzb3AD/fBRU/wSm7y0r
1NKqN+OtLuM7C+Cjrtin6Sr+PW2A+QE=
=zspR
-----END PGP SIGNATURE-----

--YxSL1ja5VovT/CjZ--