Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp400858lqg; Fri, 1 Mar 2024 08:29:52 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVLsYOaTujBxvzodJ+Sjv9d7F5h/zmZH4xbJSrb8cNB3TQpunoSEvnFYhVwdreLyXK96g2YSCaSSxbna6TkmwCiFD17Qi3HaFM8f9TWCQ== X-Google-Smtp-Source: AGHT+IHJCLgiW+73Nc04V6nr33Ojw2bv/naAfdNMqT0E+EoPFLTJeund0IrqQNxBnBTsjvUMWV+2 X-Received: by 2002:a05:6a21:189:b0:19e:cf1a:5369 with SMTP id le9-20020a056a21018900b0019ecf1a5369mr2574328pzb.24.1709310592123; Fri, 01 Mar 2024 08:29:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709310592; cv=pass; d=google.com; s=arc-20160816; b=DFRbYIkXgaUNkH81jm/eNxTcdsh89yOg54dWhnT7pdqY5niBUx3OEM3dA1X9e9Ydy8 t4AGdsiklxdhyoqW7u1IrxiZTysQHohI39pBrV/FDGllQ0q5zbQgS1Uls0U5heQLL7wh LGq6QsPbgZEEYcDojjGBJlVUoB5LmY1rNIDQyHfNQwCTIaJSK+v19ntb8hRO0/NK/ZEF v0iS8DS6C/JZlLWbRYeW5qrGrz3A70lUkSnQWjUU6zcrE0OT2Uqgvb3W01vyEmIyXvZz pxsaY1Kz7gqyHATdwszC+ZhL53sgxH1MscnPUiBnTg2zquB4Muo1t6aPyyLbQI1CQEzj FHsw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:subject:from:cc :content-language:to:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=eoZZyI8e7jrz0cojRu3ARnsKIT7oc8fBBTiekXMUsUU=; fh=F5HsA1he7y3KrF91pRXMSlhjvlGysjY+6rk9bugBUD0=; b=vJI/ZkynGoAF4YIWm161uOW/UNqR8qksIQMGxxMDEFJjuwdjbD+OR0mhR40RqUvMq4 5k0ELk7B//KM5UMqawSYUwfQnEbrmlQB4rueovbKEIP44/wAS0hq/BU4O6D8Gm2rQkNm 76xjJ3F2UfcOgINssbl4wP3cA4eu7wCcxQrvqbVRLenBLr+ftaEXy/u5xKMMRTpeemLE Clha048eICQrZCi53lsRWcxA80fNCR1WVjhGxMUO6Syst4+KKdIY0eftwMDhQuUP40hk kmpXnWhd5Kcj+TxRe9CQTukW84KTKtIFcI2SmzwBqHeA14C6W+B10tTCgizIHAFfY5Rv kbnw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=ZQvK6iOT; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-88691-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88691-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id i4-20020a63e444000000b005dc4202b402si3883454pgk.173.2024.03.01.08.29.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 08:29:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88691-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=ZQvK6iOT; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-88691-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88691-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D740CB241A9 for ; Fri, 1 Mar 2024 16:25:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2BC8E71EBF; Fri, 1 Mar 2024 16:24:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="ZQvK6iOT" Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5F2871B43; Fri, 1 Mar 2024 16:24:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709310246; cv=none; b=pF1dHwa6ywz0E2RYrXaHtW4/sKCMYi5M69hbRI4W3NVGdcBJymwKJqrgkcxgcw0IqUfS4ERsaKOiLGsG+ZbrY4kDjUydBmvU6bKUkmBY/naLxL/vxXW9rUbvegAo9L7tZhDRNZ5Kyrx5UhBR8d5yd8Zgt3f/+visiomWxuMT4oY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709310246; c=relaxed/simple; bh=nq+dTB9sZf2knTv8a3VS+AYoILhfpagAL7MZwhJ2pmE=; h=Message-ID:Date:MIME-Version:To:Cc:From:Subject:Content-Type; b=VBQlQXXa3JkzLOvAydCY9Kj5BIqRsbVH3WxY5wpVtFr6AvVuwUhrxpB9XoqlQkR80vgazH4FVbeluOsUrJ09ewyP0ft+Tc1kyp0M1eeDQqs+1mzuarkbgi9ZIho4MO9KKUAB2wDVken7KaklYwA9sC98590bXyNsflOhw0nyQdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=ZQvK6iOT; arc=none smtp.client-ip=212.227.15.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1709310212; x=1709915012; i=markus.elfring@web.de; bh=nq+dTB9sZf2knTv8a3VS+AYoILhfpagAL7MZwhJ2pmE=; h=X-UI-Sender-Class:Date:To:Cc:From:Subject; b=ZQvK6iOT+bO4tPhYEnabsP9Xu4NuWKZALwGjgVtKfDNkBimaFc1j75CeTokSIHMX TA7lfeNKK8zYRfMu6CfukWcyWBYTQ8pjL07uhrn9xzb7/qxGWgYA5oJeTf1OMX4lg IBI/NNjcV4ooxaF+sVo2kKm8GR7TbYeOvpPkQ7SzrBiN7cBwKNCMurfiEiLDTAbic XhE55G+pyxzYVDqx64R4vJ5MsnZ0ANCIV250WNE1ylhXo48WiH8JaW+eDP7g7QGoM 4R2M7H9eiPty88Gb7IwLop/KAOvrbunEbqGaVYNfD9SMZusNJ+98rvYHhgkwvtrdH JSAzTrsoyEiDUWg0dw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.86.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MKMA7-1rRbDv0YaF-00LuRI; Fri, 01 Mar 2024 17:23:32 +0100 Message-ID: <0b89e175-47da-4e66-bb3b-a45a400dc3ae@web.de> Date: Fri, 1 Mar 2024 17:23:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , Heikki Krogerus , Krzysztof Kozlowski , RD Babiera , Rob Herring , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Yu Zhe Content-Language: en-GB Cc: LKML From: Markus Elfring Subject: [PATCH] usb: typec: fusb302: Use common error handling code in fusb302_probe() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:o7GcYrUfVXrYS2ZCPe02m7WMplSN24/yNpO+Dv2Zv7dcHv5XFlE 15XhwzGS0OyPzBxck2FX65wbryPxGYv3vLUpqdTi9n/qNhVWghgdTzOnkgLnDYrXgAm+CWf 0nxH0Fd4Or8KrPaAKyLXSVrwDdNdRuwYoMHLq1WH4Hpf0ZAXdEepTBfgsyUqYvo95B/hs6c R2wFjcDaj9Bu41DxZWCOQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:XMDho9cx+UU=;b58AOzK5r9e5ujBhpUnW+QTrDF0 af00PfU+SJcQuUSRd2WXaqjA+9JhPY62tJ4czPaQZZEyNSnF2r8A1cMYCB0OqjEWN8x/UbKHR n/EI4JZOhELQcvnF+IScPTH/dwEV31E4iUIdolKQGsdkVRc8IKsaRXykZPpFkDerl3QrRzTAq 1jApWXH7esPKjcqzaL7/Frn4Itj4TX/IVcbZDdifgN6fw+WB78D491AvPyZ72AbnaFBw3sUjv /4dLAcANQAoZmlP/JldAfoIQfYTRhHN1t0mUTrKCGP+XfjDIIdf7MlG6P/KikWWSndqNjr9jx Qcc4VUVXcJOfp0+qLuAxGo5G/VbygPezXoU/tpwnbYmUWWKKAxnLpDoSA7h4dta9J5kWGQ9Te sNydATeYIJh1hkc1GvMs16cYD52RtLjNgCxwWJp5AAk+jVRR7fddVl4ZrUWOCHu6UBqIMiIr3 bdD55UqrmL+3AxZJvmzkP0OQ8Dz/OTkKObNv9XuSbAcw+xKKeEAHclXgMZUuTp2P1EHk1ZsMH wi1OzpMqvOFSiyjeaZEDJdf8IzerMZ4ZEyexnrOMZ2l7gDWwoH148dj4ULoTPEa9fWxNGUeZK kTgzbIhi3OhlSSilbqbpnTff6D41V2yRE4QxuvSQH1LsaQUMy6WORheU/hMglm5OtWprF4ch5 vzfLJZeJtMMYJ9TqZBOI9HwE5r/PYTIHoWCoR4dZlfLvAIpZtgzZ/Pcn9cr67J46y4BP08F53 i+SnzS6GokXepWVkqZlIYmOsHUgzqAio9QZRn2UxBW4vXB4vOzsl1s+DoADgQRaJIcOB5JgYl 9VAVFqnlB11s4d2rF41EguskBOHPbEv56nRxIZJbYfXvY= From: Markus Elfring Date: Fri, 1 Mar 2024 17:00:23 +0100 Add a label so that a bit of exception handling can be better reused at the end of this function implementation. Signed-off-by: Markus Elfring =2D-- drivers/usb/typec/tcpm/fusb302.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fus= b302.c index ef18a448b740..e1e030da1dec 100644 =2D-- a/drivers/usb/typec/tcpm/fusb302.c +++ b/drivers/usb/typec/tcpm/fusb302.c @@ -1741,10 +1741,9 @@ static int fusb302_probe(struct i2c_client *client) chip->tcpm_port =3D tcpm_register_port(&client->dev, &chip->tcpc_dev); if (IS_ERR(chip->tcpm_port)) { - fwnode_handle_put(chip->tcpc_dev.fwnode); ret =3D dev_err_probe(dev, PTR_ERR(chip->tcpm_port), "cannot register tcpm port\n"); - goto destroy_workqueue; + goto put_fwnode; } ret =3D request_irq(chip->gpio_int_n_irq, fusb302_irq_intn, @@ -1761,6 +1760,7 @@ static int fusb302_probe(struct i2c_client *client) tcpm_unregister_port: tcpm_unregister_port(chip->tcpm_port); +put_fwnode: fwnode_handle_put(chip->tcpc_dev.fwnode); destroy_workqueue: fusb302_debugfs_exit(chip); =2D- 2.44.0