Received-SPF: pass (google.com: domain of linux-kernel+bounces-88734-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240301133829.346286-1-james.clark@arm.com>
In-Reply-To: <20240301133829.346286-1-james.clark@arm.com>
From: Ian Rogers <irogers@google.com>
Date: Fri, 1 Mar 2024 08:38:37 -0800
Message-ID: <CAP-5=fUWL56Hi716DPa6Q_VXQoGh6Ed1WoNfSHow3+9qzSaMbw@mail.gmail.com>
Subject: Re: [PATCH] perf version: Display availability of OpenCSD support
To: James Clark <james.clark@arm.com>
Cc: linux-perf-users@vger.kernel.org, al.grant@arm.com, 
	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Namhyung Kim <namhyung@kernel.org>, 
	Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 1, 2024 at 5:39=E2=80=AFAM James Clark <james.clark@arm.com> wr=
ote:
>
> This is useful for scripts that work with Perf and ETM trace. Rather
> than them trying to parse Perf's error output at runtime to see if it
> was linked or not.
>
> Signed-off-by: James Clark <james.clark@arm.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/builtin-version.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/builtin-version.c b/tools/perf/builtin-version.c
> index 1bafe5855ae7..398aa53e9e2e 100644
> --- a/tools/perf/builtin-version.c
> +++ b/tools/perf/builtin-version.c
> @@ -84,6 +84,7 @@ static void library_status(void)
>         STATUS(HAVE_LIBTRACEEVENT, libtraceevent);
>         STATUS(HAVE_BPF_SKEL, bpf_skeletons);
>         STATUS(HAVE_DWARF_UNWIND_SUPPORT, dwarf-unwind-support);
> +       STATUS(HAVE_CSTRACE_SUPPORT, libopencsd);
>  }
>
>  int cmd_version(int argc, const char **argv)
> --
> 2.34.1
>