Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp409676lqg; Fri, 1 Mar 2024 08:44:42 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXJmSzoU6+RgLXU4CSc4DEk4N/w7EIfXj/8xjNA/8r8jGWFnucFlh3sHnfSeSMNYuU6gbnKzS82EFfpVNXmrGeZlZtKRZM4+XfgQRCvWA== X-Google-Smtp-Source: AGHT+IFHJ3WZ0yoW/cD9dlj+6jkaJhVqk6SID40oRxL4vgL8BcAjJQHPHpqgRStIBS5lhA+YPH56 X-Received: by 2002:a17:906:ca46:b0:a3e:8223:289a with SMTP id jx6-20020a170906ca4600b00a3e8223289amr1712407ejb.31.1709311482520; Fri, 01 Mar 2024 08:44:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709311482; cv=pass; d=google.com; s=arc-20160816; b=cHx9OPUrFZv6a/AbXZnbxBGxXWLMaHkKdVGADb9Yd40VDYaVm3eSLgn1RrPbhIPgVs JYVD7RMLnW5wUTrN69DrBLFXeqiVfDdaAjcG+wudRpCDZRaAS7eBjavOZremCF0/AjO/ Hs4+y/U11Jp9//xb9H5dLZNnjcZzewgCAsfwFl4zjTuqFBok56N5S4J70uQ8ZgGwFvum RTp/OAGMXs7zNm9+ZrYEWZavOgE/tC2lbXXKgZ1/IrzHIbT9e2Wv8gMH/rtvj+md2Bp6 zd60RTKRtUWtLFKxN5Xl/ria8gDMpwq2X4IR1gqsPnpk+kfadiZPzAinBND7SXdEL+Dv 0OXw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xF6ky7oGAXgVDPcd5CPKgoDjtno54lJ8yY7B4W/SIV0=; fh=0qm7fv6cwYglIfilZaz33dFLlYPmtQCOJvxTTh4ppFk=; b=VBJ9e1XoilwxjPy22ukCmbUpvTVWm3YE8tH+oAtV4b4yLjUGi0B96nfcAQbrTRhP9i OFn4iDqxEZDIUo0YWzdCBJ1ir/6aXN6iB/3SuznOyL1uhhjZV1chlaQ78aDj68REfp0S yIF1S/3LbYob/krFp8QNjLnkKZQi/TZ8lOw3ScL+Vew2O06BY76Hi6RsJvTWCJuYjAaI hgEMcj/z1E2E9a7lcD3akCsFOhriREvWPIUdc9EGSLSI1+YoJflUfP7KWkqHj5sA2Apq 15f0QrRFOiv4FjkO0vz3TvIRIDbw1kIAzlrJ8jBGUulFpSU+/izQ8kKKxzjt1MTevB73 aeGA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=3YIQ5ysi; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-88735-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88735-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id v13-20020a1709060b4d00b00a3ea7faf05dsi1529618ejg.16.2024.03.01.08.44.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 08:44:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88735-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=3YIQ5ysi; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-88735-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88735-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3296E1F269CA for ; Fri, 1 Mar 2024 16:44:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A5DDD3E483; Fri, 1 Mar 2024 16:38:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="3YIQ5ysi" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 730203D3A5; Fri, 1 Mar 2024 16:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709311132; cv=none; b=bH7v/8yhu3KTQb8vHdtywovflEhSxlqGpcZXW+mdrPN3K9XxRG3NLUfqzdmZdcV855EAHX4jWXIONaXEIsJFhzAYfXEdChVjKx6K84+t8H7IOjVcQPNHm0B/WXXXta+P/gx3coGkIU4mugGvFGVfesk6pL8lF+Z8Ysjnt5QZNbs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709311132; c=relaxed/simple; bh=eL5TPpLNmcEF7z0b5oJm33J07+5avJ6cc/lCJ6PzZho=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XF30BKT9jHpIxMXyOcdQ8XQwzg3Y0F/DkOr/w4jT9qg/caR5Jerw1d/tQZAsQbxVJ0afV7qbycBagn8QdzSjUMMEdX2UCJ0midJ/39DE2RfSl96YQ8PmNWDktPAYsppkepYzCMowfmcC3ML4MURHTgziYcvVykNfiNnZTmA/NPU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=3YIQ5ysi; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=xF6ky7oGAXgVDPcd5CPKgoDjtno54lJ8yY7B4W/SIV0=; b=3YIQ5ysiupGcrc8xo42VBnaT79 x4yFp4+0mNY9jAn2RkFxS5FMXLbF27o+73niCZhgoHwbKhuyStc1I5vwGAcNBq99krOB7wfV6eeBx DKIPEHDZTnnSOPUXdB0kztGSw+DDhdqjL/jpQYK67rqOqnOcAFEbvocSpreTUBFv2uH0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rg5uS-0099W4-Ff; Fri, 01 Mar 2024 17:38:56 +0100 Date: Fri, 1 Mar 2024 17:38:56 +0100 From: Andrew Lunn To: Julien Panis Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v2 2/2] net: ethernet: ti: am65-cpsw: Add minimal XDP support Message-ID: <356f4dd4-eb0e-49fa-a9eb-4dffbe5c7e7c@lunn.ch> References: <20240223-am65-cpsw-xdp-basic-v2-0-01c6caacabb6@baylibre.com> <20240223-am65-cpsw-xdp-basic-v2-2-01c6caacabb6@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223-am65-cpsw-xdp-basic-v2-2-01c6caacabb6@baylibre.com> On Fri, Mar 01, 2024 at 04:02:53PM +0100, Julien Panis wrote: > This patch adds XDP (eXpress Data Path) support to TI AM65 CPSW > Ethernet driver. The following features are implemented: > - NETDEV_XDP_ACT_BASIC (XDP_PASS, XDP_TX, XDP_DROP, XDP_ABORTED) > - NETDEV_XDP_ACT_REDIRECT (XDP_REDIRECT) > - NETDEV_XDP_ACT_NDO_XMIT (ndo_xdp_xmit callback) > > The page pool memory model is used to get better performance. Do you have any benchmark numbers? It should help with none XDP traffic as well. So maybe iperf numbers before and after? Andrew