Received-SPF: pass (google.com: domain of linux-kernel+bounces-88741-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240301084431.646221-1-sandipan.das@amd.com>
In-Reply-To: <20240301084431.646221-1-sandipan.das@amd.com>
From: Ian Rogers <irogers@google.com>
Date: Fri, 1 Mar 2024 08:39:52 -0800
Message-ID: <CAP-5=fV49j-fMSF5PcAXP7hoD4guqy8DnQs_uJWcgVM7fKxLhQ@mail.gmail.com>
Subject: Re: [PATCH] perf vendor events amd: Fix Zen 4 cache latency events
To: Sandipan Das <sandipan.das@amd.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, 
	peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, 
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, 
	eranian@google.com, adrian.hunter@intel.com, ravi.bangoria@amd.com, 
	ananth.narayan@amd.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 1, 2024 at 12:44=E2=80=AFAM Sandipan Das <sandipan.das@amd.com>=
 wrote:
>
> L3PMCx0AC and L3PMCx0AD, used in l3_xi_sampled_latency* events, have a
> quirk that requires them to be programmed with SliceId set to 0x3.
> Without this, the events do not count at all and affects dependent
> metrics such as l3_read_miss_latency.
>
> If ThreadMask is not specified, the amd-uncore driver internally sets
> ThreadMask to 0x3, EnAllCores to 0x1 and EnAllSlices to 0x1 but does
> not set SliceId. Since SliceId must also be set to 0x3 in this case,
> specify all the other fields explicitly.
>
> E.g.
>
>   $ sudo perf stat -e l3_xi_sampled_latency.all,l3_xi_sampled_latency_req=
uests.all -a sleep 1
>
> Before:
>
>    Performance counter stats for 'system wide':
>
>                    0      l3_xi_sampled_latency.all
>                    0      l3_xi_sampled_latency_requests.all
>
>          1.005155399 seconds time elapsed
>
> After:
>
>    Performance counter stats for 'system wide':
>
>              921,446      l3_xi_sampled_latency.all
>               54,210      l3_xi_sampled_latency_requests.all
>
>          1.005664472 seconds time elapsed
>
> Fixes: 5b2ca349c313 ("perf vendor events amd: Add Zen 4 uncore events")
> Signed-off-by: Sandipan Das <sandipan.das@amd.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian