Received-SPF: pass (google.com: domain of linux-kernel+bounces-88810-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Mikhail Lobanov <m.lobanov@rosalinux.ru>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Mikhail Lobanov <m.lobanov@rosalinux.ru>,
	linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] media: v4l2-tpg: Fix division by zero error in color_to_hsv
Date: Fri,  1 Mar 2024 12:08:36 -0500
Message-ID: <20240301170838.57421-1-m.lobanov@rosalinux.ru>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

In the color_to_hsv function, division by zero is possible due to
attributes r,g,b are equal so diff_rgb =3D 0.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 54fb15348385 ("[media] vivid: Add support for HSV formats")
Signed-off-by: Mikhail Lobanov <m.lobanov@rosalinux.ru>
---
 drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c b/drivers/medi=
a/common/v4l2-tpg/v4l2-tpg-core.c
index a366566f22c3..943aab3ad97c 100644
--- a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c
+++ b/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c
@@ -597,6 +597,11 @@ static void color_to_hsv(struct tpg_data *tpg, int r=
, int g, int b,
 		third =3D third_size * 2;
 	}
=20
+	if (!diff_rgb) {
+		*s =3D 0;
+		return;
+	}
+
 	aux *=3D third_size / 2;
 	aux +=3D diff_rgb / 2;
 	aux /=3D diff_rgb;
--=20
2.39.2