Received-SPF: pass (google.com: domain of linux-kernel+bounces-88821-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 1 Mar 2024 12:25:44 -0500
From: Frank Li <Frank.li@nxp.com>
To: Conor Dooley <conor@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] ASoC: dt-bindings: fsl-sai: allow only one
 dma-names
Message-ID: <ZeIPmGG7+5cKZkO3@lizhi-Precision-Tower-5810>
References: <20240227-asrc_8qxp-v2-0-521bcc7eb1c0@nxp.com>
 <20240227-asrc_8qxp-v2-3-521bcc7eb1c0@nxp.com>
 <20240229-husband-penalty-8c1ab0f57f55@spud>
 <20240229-rundown-isotope-954ba9ea4c57@spud>
 <ZeDdMJlxBL4SGkws@lizhi-Precision-Tower-5810>
 <20240301-crudeness-resale-3c0a1228850d@spud>
 <ZeIGXEJ3l4tgjmxT@lizhi-Precision-Tower-5810>
 <20240301-deluxe-tiptoeing-741af7d620b9@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240301-deluxe-tiptoeing-741af7d620b9@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?fWP4zpLsWifhf8lgclJrOAANBqPcujfxIUAb/F/HsYpUO5HrXZDfxCsSXyWd?=
 =?us-ascii?Q?g1rkxQVCalSBs9Y3EGtNqq+0MWrddVOqLvuDtO2Q9g3DnfvOyWYSP8QGoatc?=
 =?us-ascii?Q?MIKzkpWdD3mcTDkknti7LLxvoeOgg0xsOY8xtEX0rPR3jYJIHZJUFi9/c8PV?=
 =?us-ascii?Q?xsRfa2qakDxLEqzD5GEUIhhl5+zpoR94JDSQToc5VWdvG0zfGPkEG/CCQl3d?=
 =?us-ascii?Q?u6QwkKY2v4h1+FFZbPlJt2NJUZ++3S/sdgdxrLYuEsgspwZ0ADVYg0tere/E?=
 =?us-ascii?Q?g+CTWXiRmKuh51k2MtG5O1mIKz10FlIMKr4nICG1CRcqPmnJ6gQNzKidYglW?=
 =?us-ascii?Q?z2OVyHek4Cup1f9P+Q1Mm8qwOaujlZ/n2KlchXUCau1zvNTF4b4LY9S2QrPA?=
 =?us-ascii?Q?KwPcnD8IuowFvb1GPgNnxeIdudsWL+GNQej8PvFHry8yqPDiUYb4MN09KqeF?=
 =?us-ascii?Q?uEI/fdCT//PSOl/hobRMczAIceZh/B59yOYGq8QT0yIpH5t1+EPLyCIv6tKq?=
 =?us-ascii?Q?m9t7WBO9R/r/D/Es04ulGh+zpwJpO/q4wo4p5/Nc18FbUwz6LNTQoZFniBu0?=
 =?us-ascii?Q?YY8wNkrblXAD/VctGnBERuFsLI5/AhuwOmUf8t/F1vkxFHWSi2kcOfeOepdD?=
 =?us-ascii?Q?axS4ETVTvObrtSAdl+0CesCCPbBLqEXPhiNAYsTQdQzExaGFrxEJaTEwxH92?=
 =?us-ascii?Q?Irbk1UY10m4fQ04QGlV91QxOiQO1uqIQDodLtTpiBu5TjVVDzLbjiz9IbT6l?=
 =?us-ascii?Q?PMIr1UN1mhzP5onWtLBEcWC96E20ddghsIRj6pWjQ4nabmfn8j2/eIDakwxW?=
 =?us-ascii?Q?jie2TPF7m6XWWj9apbTuVgkO8BgtffanJNvZtlkqrgrGDOrEnlsJugoHkXRA?=
 =?us-ascii?Q?yA3uGdO7lqhEd+lfBiF5UD9G7FE0aKXR5Sv6c+D3iXTGd6lujY33dbpYZU39?=
 =?us-ascii?Q?iovws5lZwnkCAHzxQp+M+84qXtcKJjRKMH26dZpmCrPJE82rzzD4T61V3Qux?=
 =?us-ascii?Q?PFpkooey/YW4xQgPGCMR4RF6ylQbM+3x3o0QI+r3fW23ZwJj75LBQQ4hVERV?=
 =?us-ascii?Q?QpmQHO0d8mpUpj+vbJFHhB8S9087fVo4JnFteli4VO/TJghQY53Q4WRCoZZX?=
 =?us-ascii?Q?2yOh02QNrKUu+t6PWKod/b89quipRPRzILMsvhzvqhyO4KJfVGU7VgS2FWsZ?=
 =?us-ascii?Q?1j2de2Tu8JUAqXcy1k2Xh5lEwg5e6NWew7/cAqs8AdcOcOZRpvj2gQ9cnR+m?=
 =?us-ascii?Q?nhCdNTkpJ0Rj6zHeANj6BaLi/FN1Ldm/Mxi8IasnVBC7lIDufTSyOZcG5Xmz?=
 =?us-ascii?Q?RViHG8Tvle4UcPVd/4s2ok/slHlCxamUOTvB7UbFyskUO/F8iECi2pQ9DxI8?=
 =?us-ascii?Q?WCFyKvZ66ELC96B3LTj/TSLTjRmonFviWGfhNKuUEG39aSpshvg6if5Wj4x5?=
 =?us-ascii?Q?N0q/mv2bqAZJl1jFLWjTQG8UqjNge7ZkOgszxtda80SCr5qn/gXH267FSfjC?=
 =?us-ascii?Q?Gy+McL/Ipnuoyr+SxjER6cJQubz8+sirEua2wo3xcO/Xr6xaT/moCb7gykok?=
 =?us-ascii?Q?ncVqAAaHjiCZtVnWHtp8GQ5Rx4evM7TDiUeNALLO?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41265402-e84a-4579-0cbc-08dc3a14a5aa
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 17:25:53.3832
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jqHYtZbc1OzE1Fpin4Gtp8tcgNEmNGSMmKuEc62vyjjl64IQ0LSHUeS3qPLR0yUHbUTybdfxHr+qoy41QMS2Vw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9308

On Fri, Mar 01, 2024 at 05:07:07PM +0000, Conor Dooley wrote:
> On Fri, Mar 01, 2024 at 11:46:20AM -0500, Frank Li wrote:
> > On Fri, Mar 01, 2024 at 04:05:25PM +0000, Conor Dooley wrote:
> > > On Thu, Feb 29, 2024 at 02:38:24PM -0500, Frank Li wrote:
> > > > On Thu, Feb 29, 2024 at 06:57:29PM +0000, Conor Dooley wrote:
> > > > > On Thu, Feb 29, 2024 at 06:55:58PM +0000, Conor Dooley wrote:
> > > > > > On Tue, Feb 27, 2024 at 03:54:11PM -0500, Frank Li wrote:
> > > > > > > Some sai only connect one direction. So allow only "rx" or "tx" for
> > > > > > > dma-names.
> > > > > > 
> > > > > > Which sai? Can you restrict this per compatible please, so that someone
> > > > > > cannot add 2 dmas for ones where only the tx is supported.
> > > > > > 
> > > > > > |  dmas:
> > > > > > |    minItems: 1
> > > > > > |    items:
> > > > > > |      - description: DMA controller phandle and request line for RX
> > > > > > |      - description: DMA controller phandle and request line for TX
> > > > > > 
> > > > > > The binding already allows only one, but it documents that the first dma
> > > > > > is always the RX dma, and that doesn't change with this patch..
> > > > > 
> > > > > I said "doesn't change" - but I don't think you can change this
> > > > > trivially, as something could rely on the first dma being the rx one.
> > > > > You'd have to check that there is nothing using these using indices
> > > > > rather than names before making any changes here.
> > > > 
> > > > Linux driver and dts with tx only work well. Only issue is dtb_check will
> > > > report error. I want to eliminate these DTB_CHECK warning.
> > > 
> > > Linux is not the only user of these bindings, citing linux as your
> > > evidence here is only sufficient if no other users exist. Do they?
> > 
> > But, 'dmas' should be common property for all these bindings? I don't think
> > they use 'descriptions:' property, which should guide dts writer to write
> > dts file. actually words 'DMA controller phandle and request line' just
> > nonsense words. let 'regs', it'd better descript at 'reg-names' instead
> > of 'regs' if reg-names exist. Only meansful words is "RX" and "TX", which
> > already show at "dma-names".
> 
> None of this matters. If there's a documented order for these, which
> there is, software is not obligated to use the names and can rely on the
> order alone. You need to check that there are no other users which will
> be broken by your proposed change.

As my best knowledge, only linux use this binding.

Frank

> 
> > > > And it also reasonable, only rx or tx for a special SAI.
> > > > 
> > > > Can we remove 'description'? dmas should already descripted at common place
> > > > and 'RX' and 'TX' are listed at 'dma-names'
> > > 
> > > Removing the description has the same problem. The existing binding has
> > > set a fixed order that you now want to make flexible.
> > 
> > Actually original set minItems: is 1, which means allow 1 channel. but
> > set items to force two channel. 
> > 
> > Does it work
> > 
> > oneOf:
> >   items: 
> >   	- description: TX
> > 	- description: RX
> >   items:
> > 	- description: TX
> >   items:
> > 	- description: RX
> > 
> > > 
> > > Thanks,
> > > Conor.
> > 
> >