Received-SPF: pass (google.com: domain of linux-kernel+bounces-88880-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To: Takeru Hayasaka <hayatake396@gmail.com>, "Brandeburg, Jesse"
	<jesse.brandeburg@intel.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@intel.com>, "David S. Miller" <davem@davemloft.net>, "Eric
 Dumazet" <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>
CC: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"vladimir.oltean@nxp.com" <vladimir.oltean@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"laforge@gnumonks.org" <laforge@gnumonks.org>, Marcin Szycik
	<marcin.szycik@linux.intel.com>, "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "mailhol.vincent@wanadoo.fr"
	<mailhol.vincent@wanadoo.fr>
Subject: RE: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS
 hash options to ethtool.h
Thread-Topic: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS
 hash options to ethtool.h
Thread-Index: AQHaXVfYPrQaFDDbUU2tyu9IZKEtzLEjR9cw
Date: Fri, 1 Mar 2024 18:01:14 +0000
Message-ID: <CYYPR11MB8429FCD568EE2AF90AEE2CABBD5E2@CYYPR11MB8429.namprd11.prod.outlook.com>
References: <20240212020403.1639030-1-hayatake396@gmail.com>
In-Reply-To: <20240212020403.1639030-1-hayatake396@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZRwN+TGb1PaHBaXB00oE3vf+FkXKYWmhxBEcwTBQNvQx9t/fCJzzOLJ3Ulfq?=
 =?us-ascii?Q?lE7MhieSfUoT+UgxQLkRtBSo1iycL0drxcT3nwHuUaiJ2iLFB31j6pmSKz/U?=
 =?us-ascii?Q?E8TLaekPZMkmQh4mM3I6i0xiGLmH1O00C+WAC5GLYKXaXYf0qHOQQ8v9QyRA?=
 =?us-ascii?Q?mOxY6ro0zX/fLdrZc56c6N3YZULly5Xg4WfxF4oi79fXyXsTgzhhqIe0MMVO?=
 =?us-ascii?Q?YRj+3xLZmZgTVxwuUAfMh2cEQ+PRUi3Q3Qugwq1Puv9CLxONZUQIXxho1+Ku?=
 =?us-ascii?Q?JEQGeIlGYU1sezp5un08iLJmNGRwFAvpjZr+rXprfjmEUzFnmlt61FjSUpsj?=
 =?us-ascii?Q?OhY6FwFo6eVlL65XjtHdngjPwofpUDhIG6wMMVqWMYqr3bJ6jEUP78jE4X0S?=
 =?us-ascii?Q?rD5yd4cEFahs2bcUgQpuEsn/CWAj0P8FFy/1JnnDzadwTNM6JfBRSemPFVJH?=
 =?us-ascii?Q?6jMcCjY/ZzRdrlYFPExd2SrEwn1MxXOh6JjPgcSfOH5bG9bQ2FOj80LjrrlC?=
 =?us-ascii?Q?aj9/XoykHl1o9MP7BL1wvtOwPoetZwZzgU52f4tr5TWetUGdauSwhouL5e/n?=
 =?us-ascii?Q?KWnfUAZ9q2WEFOfhqEVowuRVSQ0uODA3zsiOGl+Lr+sQYw+m0EvLqPs/X8As?=
 =?us-ascii?Q?AL7VqngPPUU1nTikEf3dEXe8KMd1BbcATAOIGh+bYb/1Mj/855xYtHAH5ciJ?=
 =?us-ascii?Q?gOFFqkKPcC6Q4psqLe3RPD9eXIL++tWfN7Wp5lIchOyts2EQCYoexwomA8kh?=
 =?us-ascii?Q?1qGUJ5ceCEvZ4l8ndGePalaZz9E9n1gCsdKd5aPmT+XMIY3dll9ZzxOTeTDf?=
 =?us-ascii?Q?RUCJF876tOoSixdQuBExNWx5ByCDTpJlL6sig3i2iutbBSQtTWIJtPXIsj9X?=
 =?us-ascii?Q?eAc6s0IX/2PSpp3QppZ2M2J5zbOUGQbze+D0ZODMkf89w/glXfBVQkZbUYU1?=
 =?us-ascii?Q?vLAvecPQi3/3mbn1SVDGWIgnx6gfaQueoNCj0sPF0vPBNptkwNGweevu67OA?=
 =?us-ascii?Q?xcS38DAXkJ+Yic1L+/0xht75OY9kub2e6h85WRe3wEtNRV2KLZG1E69sc7NR?=
 =?us-ascii?Q?IEFpkM/OGt3XKfraKwP9InfYBNvKYTZ6UUVV5e9DAXzJEzlFuirTBu4l2cJc?=
 =?us-ascii?Q?JI9Ng8x6MC9tUNPBZQjZ3pM5X6zRLA4mpxBcYQo77WZl57GqRQ5TmBqdkWcf?=
 =?us-ascii?Q?fF+K0Eppxdv1qZkB95KvvdHZcGKSTg7ZozbAqMyMRacwgoZoOPHIHx5TksK+?=
 =?us-ascii?Q?VEl91YeW+tGPJ8axC9/TIqzPn+lleV2d1dWtcSyGq531+IozprurDgizKcR7?=
 =?us-ascii?Q?7eWMnWlz/Ar268YwaMglFlA3isu6y3ZHLW5IbmQrsFH38Kg99YOfb6uwM628?=
 =?us-ascii?Q?scNXKxcOu7N+Gi84TiCZy6ZICSWUkn2b+n+VWWf89vSsfzbbD+uxC0iFje01?=
 =?us-ascii?Q?T90LkfEWn/OdIr0VlvRV1iTaHjDlQ8kTcLaAqXl5QLIG0384765n9KAP6A+2?=
 =?us-ascii?Q?JOsOgL1D38m4z6chEjnHWKuOLQu0LpnnrTZesbOpaGttDVNtl8pApIpyB+JP?=
 =?us-ascii?Q?+Uj05iMopCjaVXN8mWDIqMMDkSKqlGX8HMsQUQ5hG6YrlfuxE6U8MPb8VFvc?=
 =?us-ascii?Q?KQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CYYPR11MB8429.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3533fb3-782b-44fa-0b0b-08dc3a199602
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2024 18:01:14.4737
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4qXoezBoizyVrzQCkFSTUg2QRPkeIpvBZvFBZHoub3rPiesgf6JamK73c0kPD6eTl+iwlsNsJ68ypttBadeNc2+S5g1VS7H8JEB7nMeJ8pNmnqbzBfuDR20KE/AuCdll
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7823
X-OriginatorOrg: intel.com

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of T=
akeru Hayasaka
> Sent: Monday, February 12, 2024 7:34 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <an=
thony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Duma=
zet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <p=
abeni@redhat.com>; Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org; vladimir.oltean@nxp.com; linux-kernel@vger=
kernel.org; laforge@gnumonks.org; Marcin Szycik <marcin.szycik@linux.intel=
com>; intel-wired-lan@lists.osuosl.org; Takeru Hayasaka <hayatake396@gmail=
com>; netdev@vger.kernel.org; mailhol.vincent@wanadoo.fr
> Subject: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS h=
ash options to ethtool.h
>
> This is a patch that enables RSS functionality for GTP packets using etht=
ool.
>
>A user can include TEID and make RSS work for GTP-U over IPv4 by doing the
>following:`ethtool -N ens3 rx-flow-hash gtpu4 sde`
>
> In addition to gtpu(4|6), we now support gtpc(4|6),gtpc(4|6)t,gtpu(4|6)e,
> gtpu(4|6)u, and gtpu(4|6)d.
>
> gtpc(4|6): Used for GTP-C in IPv4 and IPv6, where the GTP header format d=
oes
> not include a TEID.
> gtpc(4|6)t: Used for GTP-C in IPv4 and IPv6, with a GTP header format tha=
t
> includes a TEID.
> gtpu(4|6): Used for GTP-U in both IPv4 and IPv6 scenarios.
> gtpu(4|6)e: Used for GTP-U with extended headers in both IPv4 and IPv6.
> gtpu(4|6)u: Used when the PSC (PDU session container) in the GTP-U extend=
ed
> header includes Uplink, applicable to both IPv4 and IPv6.
> gtpu(4|6)d: Used when the PSC in the GTP-U extended header includes Downl=
ink,
> for both IPv4 and IPv6.
>
> GTP generates a flow that includes an ID called TEID to identify the tunn=
el.
> This tunnel is created for each UE (User Equipment).By performing RSS bas=
ed on
> this flow, it is possible to apply RSS for each communication unit from t=
he UE.
> Without this, RSS would only be effective within the range of IP addresse=
s. For
> instance, the PGW can only perform RSS within the IP range of the SGW.
> Problematic from a load distribution perspective, especially if there's a=
 bias
> in the terminals connected to a particular base station.This case can be
> solved by using this patch.
>
> Signed-off-by: Takeru Hayasaka <hayatake396@gmail.com>
> Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> ---
> v2->v3: Based on Harald-san's review, I added documentation and comments =
to
> ethtool.h and ice.rst.
> v3->v4: Based on Marcin-san's review, I added the missing code for GTPC a=
nd
> GTPC_TEID, and revised the documentation and comments.
> v4->v5: Based on Marcin-san's review, I fixed rename and wrong code regar=
ding
> GTPC
> v5->v6: Based on Marcin-san's review, Undoing the addition of unnecessary
> blank lines.Minor fixes.
> v6->v7 Based on Jakub-san's review, Split the patch.
> v7->v8: There are no code changes. I've resent the patch, including Marci=
n-san's
> patch, because PatchWork did not interpret the patch correctly.Simon-san =
told
> me. Thanks.
 > include/uapi/linux/ethtool.h | 48 ++++++++++++++++++++++++++++++++++++
 > 1 file changed, 48 insertions(+)
>

Hi Takeru Hayasaka,

Functionality wise its working fine. But the ethtool part (tab complete doe=
sn't show GTP)=20

Please find below logs.

[root@os-delivery ~]# ethtool -N eth4 rx-flow-hash
ah4    ah6    esp4   esp6   ether  sctp4  sctp6  tcp4   tcp6   udp4   udp6
[root@os-delivery ~]# ethtool -N eth4 rx-flow-hash
ah4    ah6    esp4   esp6   ether  sctp4  sctp6  tcp4   tcp6   udp4   udp6
[root@os-delivery ~]# ethtool -N eth4 rx-flow-hash gtpu6e sdfn
[root@os-delivery ~]# ethtool -N eth4 rx-flow-hash gtpu6u sdfn
[root@os-delivery ~]# ethtool -N eth4 rx-flow-hash gtpu4u sdfn
[root@os-delivery ~]# ethtool -N eth4 rx-flow-hash gtpu4d sdfn
[root@os-delivery ~]# ethtool -N eth4 rx-flow-hash gtpu6d sdfn