Received-SPF: pass (google.com: domain of linux-kernel+bounces-88990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Michael Kelley <mhklinux@outlook.com>
To: Rick Edgecombe <rick.p.edgecombe@intel.com>, "kys@microsoft.com"
	<kys@microsoft.com>, "haiyangz@microsoft.com" <haiyangz@microsoft.com>,
	"wei.liu@kernel.org" <wei.liu@kernel.org>, "decui@microsoft.com"
	<decui@microsoft.com>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "gregkh@linuxfoundation.org"
	<gregkh@linuxfoundation.org>, "davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>, "kuba@kernel.org"
	<kuba@kernel.org>, "pabeni@redhat.com" <pabeni@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: "sathyanarayanan.kuppuswamy@linux.intel.com"
	<sathyanarayanan.kuppuswamy@linux.intel.com>, "elena.reshetova@intel.com"
	<elena.reshetova@intel.com>
Subject: RE: [RFC RFT PATCH 3/4] hv_nstvsc: Don't free decrypted memory
Thread-Topic: [RFC RFT PATCH 3/4] hv_nstvsc: Don't free decrypted memory
Thread-Index: AQHaZTRYyLuO6L4H/k6p47hU50Sf0rEjRGOQ
Date: Fri, 1 Mar 2024 19:01:08 +0000
Message-ID:
 <SN6PR02MB4157DBE049E6628D0B7CBADBD45E2@SN6PR02MB4157.namprd02.prod.outlook.com>
References: <20240222021006.2279329-1-rick.p.edgecombe@intel.com>
 <20240222021006.2279329-4-rick.p.edgecombe@intel.com>
In-Reply-To: <20240222021006.2279329-4-rick.p.edgecombe@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?0k2xh09BIVmzOxsiAeIev2XfkTiZGqywl7pWt1LZx79lSNu6kMQEhOCiT92E?=
 =?us-ascii?Q?HFV1yCgb6RJp+Ffc2u391Nfjl5d1/89HcoW+0bvgJoiryoZr3oWfHXNuV9EV?=
 =?us-ascii?Q?UnIgthiMn9x7P2o+8dyu5kMmzfDS6JNOLnBsLBWywrL/k95AUDEVCJNpaaBG?=
 =?us-ascii?Q?0PRkMShI/l2M8KeeAUpsVq9+p34hPAGTWt5zSkwCn/wbXprYzp8dV2lneF31?=
 =?us-ascii?Q?SfnIpdEBjy4c9OJLf1nVXPqLKtdr3mLzzXwh1bidmRdAErDizVQPx+o4vYk/?=
 =?us-ascii?Q?DECJUsOtK/2rVuQqhxiwAiR8ejbKdFMa4ALvN20fxjP+GHEEhQbeQoiYjDHv?=
 =?us-ascii?Q?x4QEDauP74Hk7qf7xmVfOuRA9sNc3NIlDKw9I1Iiyte8dPSoI2rf6Yw/urR+?=
 =?us-ascii?Q?nARRj45pT7G9BFBVnjjmZtg/TmwwjDxdr/4cwOlmfEekAKw2n3BbIxLk3UFT?=
 =?us-ascii?Q?RElyf1YkW0VLR1DNSIZZ+tM591OYwDpihWtHM52D4fbWXlnmWkVSgKlTHMh1?=
 =?us-ascii?Q?FcB0gVQuUjT2mnwqJzscB2lC3OzthAe62bA8YxIZIa1W4pC37wOdR/eGxWqj?=
 =?us-ascii?Q?uKv9m+FBR7+Ov/vZy9RqO7LBgj587uk1s3suXxj4pg6u4SpgrZvy8tXHdfjf?=
 =?us-ascii?Q?FuAXsWCgv6KjISZ20R0YCo4lqOIR7uKW7g2tXcJQ3jatbMluVZf/AdAJvX3R?=
 =?us-ascii?Q?ruRueq8jiEjZL38K+xqrLoX2B+AZ9gwgAcMPIkslUQ8bXOG4FnmNUyYDKkDP?=
 =?us-ascii?Q?GaMppoWCqaES4u5tGRWHYrnP8caAuNWwIz9VGmlHYpOvatHQEWKPdYwGbUnu?=
 =?us-ascii?Q?B6Hp7vOYvSAFTVOHp695izv25yWx/j5KGYnObVUXQ8ibpYq7V/XIgp2N1Xzk?=
 =?us-ascii?Q?M/ER1mKljh27lebYD3O4X4a24QLyMB3Ea64cEt40hioGZUvsbrCalWWW+4EC?=
 =?us-ascii?Q?OXzcXwxBj/xOs8y+R5wu5LRl5eEa/IevMLK7z3/UtLJSgYVkZdvXjEf3YjRU?=
 =?us-ascii?Q?TNIBJAGtWlxOgpj3sZHt4C4YXCWLJFlx8BVOW4LcSUHGAMFUC0PCCakTm69F?=
 =?us-ascii?Q?vOtLpV6zFvOuZGIAa0ppssFjY/wzIzOK5FlFSgSSsGpcQo5ma1we+lrRIcoO?=
 =?us-ascii?Q?TMGjhaiJNaWQq5a88Thp+6iSYMzNMnQY1czyKqW8ZDG/ZO9GDBkZDeGH/LiN?=
 =?us-ascii?Q?9GSHjLr3bH7Ptjtq+9V+S2982Z+jSTcfWlxXPQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 732d9606-8282-41c6-4c33-08dc3a21f46a
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2024 19:01:08.8190
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR02MB8941

From: Rick Edgecombe <rick.p.edgecombe@intel.com> Sent: Wednesday, February=
 21, 2024 6:10 PM
>=20

"Subject:" prefix should be hv_netvsc:

> On TDX it is possible for the untrusted host to cause

Same comment about TDX vs. CoCo VM.

> set_memory_encrypted() or set_memory_decrypted() to fail such that an
> error is returned and the resulting memory is shared. Callers need to tak=
e
> care to handle these errors to avoid returning decrypted (shared) memory =
to
> the page allocator, which could lead to functional or security issues.
>=20
> hv_nstvsc could free decrypted/shared pages if set_memory_decrypted()

s/hv_nstvsc/hv_netvsc/

> fails. Check the decrypted field in the gpadl before freeing in order to
> not leak the memory.
>=20
> Only compile tested.
>=20
> Cc: "K. Y. Srinivasan" <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: Wei Liu <wei.liu@kernel.org>
> Cc: Dexuan Cui <decui@microsoft.com>
> Cc: linux-hyperv@vger.kernel.org
> Signed-off-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
> ---
>  drivers/net/hyperv/netvsc.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
> index a6fcbda64ecc..2b6ec979a62f 100644
> --- a/drivers/net/hyperv/netvsc.c
> +++ b/drivers/net/hyperv/netvsc.c
> @@ -154,8 +154,11 @@ static void free_netvsc_device(struct rcu_head
> *head)
>  	int i;
>=20
>  	kfree(nvdev->extension);
> -	vfree(nvdev->recv_buf);
> -	vfree(nvdev->send_buf);
> +
> +	if (!nvdev->recv_buf_gpadl_handle.decrypted)
> +		vfree(nvdev->recv_buf);
> +	if (!nvdev->send_buf_gpadl_handle.decrypted)
> +		vfree(nvdev->send_buf);
>  	bitmap_free(nvdev->send_section_map);
>=20
>  	for (i =3D 0; i < VRSS_CHANNEL_MAX; i++) {
> --
> 2.34.1