Received-SPF: pass (google.com: domain of linux-kernel+bounces-89000-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <8521a07a-b8c0-e653-e5a1-852bc3adbaac@amd.com>
Date: Fri, 1 Mar 2024 13:13:47 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v7 2/9] x86/startup_64: Defer assignment of 5-level paging
 global variables
To: Borislav Petkov <bp@alien8.de>, Ard Biesheuvel <ardb@kernel.org>
Cc: Ard Biesheuvel <ardb+git@google.com>, linux-kernel@vger.kernel.org,
 Kevin Loughlin <kevinloughlin@google.com>,
 Dionna Glaze <dionnaglaze@google.com>, Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>,
 Andy Lutomirski <luto@kernel.org>, Brian Gerst <brgerst@gmail.com>
References: <20240227151907.387873-11-ardb+git@google.com>
 <20240227151907.387873-13-ardb+git@google.com>
 <20240228205540.GIZd-dzFYIBbtfIAo3@fat_crate.local>
 <CAMj1kXGhZU+FE2gE262Q8_vZEFHicsRtVPzXT-dhhCvBuiMjUA@mail.gmail.com>
 <20240301160921.GBZeH9sZhp73xX40ze@fat_crate.local>
 <CAMj1kXFJwEUExy7+Snh3QHVn-ATj0C+sYje22Qmc+y=cCtAV7g@mail.gmail.com>
 <20240301173323.GDZeIRY_BVBqpudkEo@fat_crate.local>
Content-Language: en-US
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20240301173323.GDZeIRY_BVBqpudkEo@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?alg3MHV4eTZBeWdSeWt1MHV5N1BWQlVPc2cybTFMaW9Wd1R6QSswQWc3MFUx?=
 =?utf-8?B?b08yemIxN0l2YS8zWVBQd04wZEdZUS9zTzZBdk1PUSs0QThLd3FhMFZmWS9u?=
 =?utf-8?B?b1k0LzFINk9ad1QyK1ZNQ0hFYTJHN25NSUVxd0RHZzY5NHh4NTg2ZG5YNHZG?=
 =?utf-8?B?eWxaWXZlS0h1Ny91Nko5WDNsY1l1YjVuRFducU5hUy9STFNRTXdYaE45SHdW?=
 =?utf-8?B?MnMrY2Q1Qll5K3pQMDlNc3VQSjdPV205WXJMa1FTbm5tc3liRnhJMjhiM0I4?=
 =?utf-8?B?Sk9mWTQxdk1yT28zbWNFVjBtNklxeVFWbzlPS3FMWklQMjFlazFJdXYyNnJ2?=
 =?utf-8?B?YXVoU1hZTGxML01aWVhsczFkUy9VS2FwcW1mOEhtWXRLc29ybzJhcFBMV2pD?=
 =?utf-8?B?SCtkdU40d29wZW1yMHZESStvUTVMUDJIRVZzaFhkRUFKZEJkNFRWSVlzWXpF?=
 =?utf-8?B?dVBaWGJhTkRDVGdtRzFrUzNYSHM3TGJiM3BleExzamZzMU5EdDN2R05kdlJE?=
 =?utf-8?B?Uzl0VWxmVXlSbngrVldIeGpUZDNRSUkwYWU1MWJyUFFWVm1rdHpkLy8xZW1H?=
 =?utf-8?B?d0QxOEMwRGlWZk1rVU02MDEreForZEpleWFCM0VOY1dEM0Z1WGtubFF6N2NU?=
 =?utf-8?B?am0rS1NHNVY5MzZER042UGFJWXkwSXowaWJQNG4xTS9TSGhDd0g4QUE3YlRj?=
 =?utf-8?B?VzFQMEU4MjU3QUNVWFVsQWVuUVVFU1diSGNLTlNLTDN5VjlMUCt3MlpwZnRl?=
 =?utf-8?B?ZkJTWm5FYjN0YU93elZRdVR6cVRJMy9McEpWd1V2Mytmd0VMS3pqTjRwZE1C?=
 =?utf-8?B?a3FvU3J3NmtKL3N3dlhVb0w5QlIrS1R2ZFpEWCsyY25xWEpybC8xdVdJaDg1?=
 =?utf-8?B?eStEZFlPazhTbTQveU83dk5vR3lQQ0JzQjczdFh5UWp2Q2pwLzZtSktuT2Nz?=
 =?utf-8?B?bzhYSmhuTVBLejdrdjR6b09jM0Z1bkNWVllQR2J2b05OSzdIanplMTlmZ2s2?=
 =?utf-8?B?a1pmWG5aVWtObEZiWEZTampHdHFmMHVNY2FBZWNhZDN5Ulpub0lxMFNMeE85?=
 =?utf-8?B?anFwbTRrY2piRm1QNCtncmJKdUlNVVRRQ1FhTElTamY4aTJGNHYyWVZGemlq?=
 =?utf-8?B?eTdtbW9nVXFiZDlxL01NZmx5UXA4alR4Umg4TlRXU29ueVF2Z0lXRUJUM203?=
 =?utf-8?B?THVWZVVnMlhKOU5uYWZldWhuSGd4YUVZWHNRZ3V3clZ0cVZrY0o3bjZXSitK?=
 =?utf-8?B?ODJqWmJrOHhCL2ZiWExvNkV0WkNMNXBwZCtxaHlrRVA4TkVVTkE0UUkwVGhI?=
 =?utf-8?B?WjZKUjhLNlljdExMUlNZNmprTzhmakw3LzVMS2FvL0V4TnZRUHYzYmY0WU9l?=
 =?utf-8?B?WWc4QnZ3bnBQeG1ndk1oZUtPOG5pREFIVmkwR2ZNN2V0bnpRMTRQRnk0cWFW?=
 =?utf-8?B?SzR0QVQxeUo3ak1UaCtwbEdhOE85M1gvUC9kM09zVjZlb3BvblZzTVRYZG5v?=
 =?utf-8?B?clBreGxSNVVxTURUMGZNQXZrOCtPOVJPSVlTblJpbVEydnZ4eUI4SmZlQU5t?=
 =?utf-8?B?TmdkLzNkWGkyR2pOQm1GQlNyZ1VQZEtrcWtZUXRDRWVmdVhERnpqQWVNKzJV?=
 =?utf-8?B?Q1VoeFEyd0ZVL25kN0FOcDNuRzF6WWNuQ1VXdFp4V1RoOUc0TXU0TVAzcUxp?=
 =?utf-8?B?R0FqalBZS1pkVzlGL0dyVlNyYS9Sa0s2TU0yYnp1bjZabVNBYTRPTE9WRnlF?=
 =?utf-8?B?UDNUdXdJR2FLUzdjdWJZcXZmRU5WZ3hzbllORmZBckpUQ1hpM0VTK0dJN05Q?=
 =?utf-8?B?d0ZVYlh6TFRmL092bEdUWmtmR3A1ZnlVdGtFWGhqOEt0Q05EWTBrVWhqKzFI?=
 =?utf-8?B?L011RXg2R2ZFdjhrVVFNTFFuT0lpSU9lQmxBZXpPSU1iVERWSUk3d3VaS3g1?=
 =?utf-8?B?ZVdnMzNlbU5URXdnWEMrcTBJbkNtQUJsbGRFcVA1b0JkcDNKL0VudVJSUmNu?=
 =?utf-8?B?SlRLNXB3QkVGWENTbHo4Z012VnNEUTV6NTh1RGNYRVU0a0drbWs5bytjZVJs?=
 =?utf-8?B?R2xSWktzdzhxSXpMTEFwejhKRjhaVmhTVWhqblV4RndlMG00dFJ3bTl3UEEz?=
 =?utf-8?Q?ceuBWjUdfJNEdljaWabEyq5/g?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cf21590-fdab-41a4-09aa-08dc3a23ba4d
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 19:13:50.4638
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rQDgsPjw5jKqp4nX1UqT2GhLAxcE/fVm6zjduyxLpM1tNvQr+cZsnqxLV3lG8KqiEvpRja3eedDsQ/WI2hEs8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9089

On 3/1/24 11:33, Borislav Petkov wrote:
> On Fri, Mar 01, 2024 at 06:09:53PM +0100, Ard Biesheuvel wrote:
>> On Fri, 1 Mar 2024 at 17:09, Borislav Petkov <bp@alien8.de> wrote:
>>>
>>> On Fri, Mar 01, 2024 at 11:01:33AM +0100, Ard Biesheuvel wrote:
>>>> The scenario that I have not managed to test is entering from EFI with
>>>> 5 levels of paging enabled, and switching back to 4 levels (which
>>>> should work regardless of CONFIG_X86_5LEVEL). However, no firmware in
>>>> existence actually supports that today, and I am pretty sure that this
>>>> code has never been tested under those conditions to begin with. (OVMF
>>>> patches are under review atm to allow 5-level paging to be enabled in
>>>> the firmware)
>>>
>>> Aha.
>>>
>>
>> I've built a debug OVMF image using the latest version of the series,
>> and put it at [0]
>>
>> Run like this
>>
>> qemu-system-x86_64 -M q35 \
>>    -cpu qemu64,+la57 -smp 4 \
>>    -bios OVMF-5level.fd \
>>    -kernel arch/x86/boot/bzImage \
>>    -append console=ttyS0\ earlyprintk=ttyS0 \
>>    -vga none -nographic -m 1g \
>>    -initrd <initrd.img>
>>
>> and you will get loads of DEBUG output from the firmware first, and
>> then boot into Linux. (initrd can be omitted)
>>
>> Right before entering, it will print
>>
>> CpuDxe: 5-Level Paging = 1
>>
>> which confirms that the firmware is running with 5 levels of paging.
>>
>> I've confirmed that this boots happily with this series applied,
>> including when using 'no5lvl' on the command line, or when disabling
>> CONFIG_X86_5LEVEL [confirmed by inspecting
>> /sys/kernel/debug/page_tables/kernel].
>>
>>
>> [0] http://files.workofard.com/OVMF-5level.fd.gz
> 
> Nice, that might come in handy for other testing too.

Be aware that additional work will need to be done in OVMF to support 
5-level paging for SEV VMs.

Initial SEV implementation happened when there wasn't a page table library 
and so SEV support had to roll it's own page table modifications. A page 
table library has since been created and 5-level support was added, but 
the SEV code hasn't been converted over to use the new library, yet.

Thanks,
Tom

> 
> Thx.
>