Received-SPF: pass (google.com: domain of linux-kernel+bounces-89007-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 1 Mar 2024 20:20:17 +0100
From: Borislav Petkov <bp@alien8.de>
To: Ard Biesheuvel <ardb+git@google.com>
Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
	Kevin Loughlin <kevinloughlin@google.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Dionna Glaze <dionnaglaze@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>, Brian Gerst <brgerst@gmail.com>
Subject: Re: [PATCH v7 9/9] x86/startup_64: Drop global variables keeping
 track of LA57 state
Message-ID: <20240301192017.GOZeIqcbI9S69zdBYW@fat_crate.local>
References: <20240227151907.387873-11-ardb+git@google.com>
 <20240227151907.387873-20-ardb+git@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240227151907.387873-20-ardb+git@google.com>

On Tue, Feb 27, 2024 at 04:19:17PM +0100, Ard Biesheuvel wrote:
> +	asm(ALTERNATIVE_TERNARY(
> +		"movq %%cr4, %[reg] \n\t btl %[la57], %k[reg]" CC_SET(c),
> +		%P[feat], "stc", "clc")
> +		: [reg] "=&r" (r), CC_OUT(c) (ret)
> +		: [feat] "i"  (X86_FEATURE_LA57),
> +		  [la57] "i"  (X86_CR4_LA57_BIT)
> +		: "cc");
> +
> +	return ret;

Yeah, I said this is creative but an alternative here looks like an
overkill.

Can we use a RIP_REL_REF(global var) instead pls?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette