Received-SPF: pass (google.com: domain of linux-kernel+bounces-89011-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <361ac881-60b7-471f-91e5-5bf8fe8042b2@moroto.mountain>
 <CA+fCnZd_eNHes56x3edzcYWeDKW2WRJYqrz_FyCks5wxtLdFdQ@mail.gmail.com> <5d74dbd9-99e4-4ebe-a9a0-bd8f571d0f56@moroto.mountain>
In-Reply-To: <5d74dbd9-99e4-4ebe-a9a0-bd8f571d0f56@moroto.mountain>
From: Andrey Konovalov <andreyknvl@gmail.com>
Date: Fri, 1 Mar 2024 20:23:05 +0100
Message-ID: <CA+fCnZdubN6xDS2adjX5jEgBOWy5KRBaHrs3COa_CG-ePFHkuQ@mail.gmail.com>
Subject: Re: [PATCH] lib/stackdepot: off by one in depot_fetch_stack()
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, Alexander Potapenko <glider@google.com>, 
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, 
	Marco Elver <elver@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 29, 2024 at 8:22=E2=80=AFAM Dan Carpenter <dan.carpenter@linaro=
org> wrote:
>
> I wrote it on top of that patch...

Ah, right, my bad.

> Backports will need to be adjusted
> to handle it, I guess.  The "lib/stackdepot: fix first entry having a
> 0-handle" commit has this note:
>
>     This bug has been lurking since the very beginning of stackdepot, but=
 no
>     one really cared as it seems.  Because of that I am not adding a Fixe=
s
>     tag.
>
> I don't really know the code very well so I can't respond to that.

Your patch looks good to me, thank you!

Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>