Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp502102lqg; Fri, 1 Mar 2024 11:30:11 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUXjWMgJHxP8TF9Ybb0JE42zYzKporee82GiiO2v+tQ2NApptTrRcKrJHOyBJk8Mr90bbC8hz0XcV9PoN8vRZKbFWw4qimh3/Pr/EkW2Q== X-Google-Smtp-Source: AGHT+IE3PZKcLdxkHIr9jOKQh94ek/ZwlLlptLP33FqVT6Maj6+1iLH/GSSJt4wIQ1FExP3sanqb X-Received: by 2002:a05:6e02:1564:b0:364:2239:a89b with SMTP id k4-20020a056e02156400b003642239a89bmr3256387ilu.11.1709321411400; Fri, 01 Mar 2024 11:30:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709321411; cv=pass; d=google.com; s=arc-20160816; b=pV3blyOIVaniD01hBn3Wd0scBYQBfDA8XoYOYKOEGNs5Vdiz+AT+c+8rCsgfyEe+0k TfxMW5jzhH7E/wG5UgGsTVUNrIENuzW+jVqGn6mOKq0oslaKiLJ5wJpMS9uSXpQMtke/ weaClVeTc6RuhGwoXZ+GD9vA2c6rxJ9j8T9t74XbD0oqBCY1KvgdKcV6QRS91Y+47DY6 ccB6A/gF9XmIxRbht/Z7C9KYfDvhqdfhwKXaimql/+B0qAY+CczD5rB3Dsxa9EoAqLsV jZBE7yBYURGwoUOKwU3Gbpwb/V8gzessSfL+bhaxgiPaodnOkhP+KtLxJ82i6Ea8jbXg JRwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:to:from:dkim-signature; bh=2AhZsMrT/cryyq1x88Ctm8CkJQJlar6AhvbnEXUNRu4=; fh=ktR5+JRjESM6fP5H6FHRdgO6PIRc/mQsnXTbf3Oim60=; b=HidiXAvPekcmsxN/hUSkCWkzhxVLt6fC/WSD5XVtxchn0qIrMcxssOwudTg094KW/b U2tZ7XnXSg6hHznl1bhp0KSObZGFRwny6DtQvmNBQrOLhcfIDEKe+WDNY8xd11H7iQXZ ywFK6STfCX+yLbeeMjPwKHmz1+TI77pvd7phf7uZ0+KF3gLZf26zRy9wPXAyYCP7Kmzh E6XlJFaxFOhdkUDRfdRz5kYKADJlBwrTjwq11zcgeudsDy7BnoHiqhrWjR1QVat+v8tZ v7VEM5SEw+X1NF2qzHz95RaHNod6kfu4F5Ar6zUsPyy7ii+9jc/l5tW+6lgm9Xo2PElq E0PA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LkwHzMHW; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-89020-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89020-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id j6-20020a63fc06000000b005e49cde1b64si3999019pgi.190.2024.03.01.11.30.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 11:30:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89020-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LkwHzMHW; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-89020-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89020-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DAE46284B10 for ; Fri, 1 Mar 2024 19:30:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E4B5C3AC16; Fri, 1 Mar 2024 19:30:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LkwHzMHW" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1847F24B23; Fri, 1 Mar 2024 19:30:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709321402; cv=none; b=fo6mwAvqyO5qhEqJAJeMU20PXaQxKQcwqH1zTnCaxhuSPPlHOvCPmc7l6fYZ+yDSAUhLeSGunmZkcv1h55MDOWCIdXms1+8G//FMTxJdC04xhP7vYEBgtBgss1FdVcHbOTeMdQMkOCiPR1d8y9nQD9tmU1FKMFBOAt95ZP+e7Yo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709321402; c=relaxed/simple; bh=Nz/QJoLkzoB8iob4rLnHiOlC6nJlTAcZG95r3IJ/SQg=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XES+PH1VTKT5wz1kyrGhSM6Ts/u5S8ZOtVWXk50lmFKlA0Hd8UCGTkA/WdDUkWvDfKFg9YCPK4LX9ODHrv0oro37y7k9szbXujwt9X/o4p/5pYCbNsNxZJfrodXeScxThAOW9TdeQpnBJ3OB7FTmHJaajzof35jc8989pHh7wkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LkwHzMHW; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B9AEC43390; Fri, 1 Mar 2024 19:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709321401; bh=Nz/QJoLkzoB8iob4rLnHiOlC6nJlTAcZG95r3IJ/SQg=; h=From:To:Subject:Date:In-Reply-To:References:From; b=LkwHzMHW7J5ryZEQ6R/I2NywAst5D0BK3bTWlg1/FFURtJzFvI1MOvIszWXqtYLJc ZvxGGvY2ngbuAkEO/qmenBtGMgefko9ngZwrYZEcShZd2meakPFhYMEBKa6eQ2irII JfpOusSREUIwlgJs4+sJAKcKcK5L5dTrsYU+E9DyoejTgwJ2J6heV7kfR87MzH/bnc eSGzikvSBUURFmHBlvQcY8AnLTHApQH0GzGCGal+Vw+GRPZf/z3xnJ2pRRwfoET3Ib KBqhDAjKcwtDEzJueRFzG2wlT8OTxwOXYpm5B/B4TumAqbLEidpP0lUG4Jc18f0mO0 xRVVHlch9NJtA== From: Namhyung Kim To: Ian Rogers , Peter Zijlstra , Alexander Shishkin , Mark Rutland , Kan Liang , linux-kernel@vger.kernel.org, Jiri Olsa , Arnaldo Carvalho de Melo , Adrian Hunter , linux-perf-users@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH v1 1/2] perf metrics: Fix metric matching Date: Fri, 1 Mar 2024 11:29:58 -0800 Message-ID: <170932136986.3731358.13745527193899618886.b4-ty@kernel.org> X-Mailer: git-send-email 2.44.0.rc1.240.g4c46232300-goog In-Reply-To: <20240224011420.3066322-1-irogers@google.com> References: <20240224011420.3066322-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Fri, 23 Feb 2024 17:14:19 -0800, Ian Rogers wrote: > The metric match function fails for cases like looking for "metric" in > the string "all;foo_metric;metric" as the "metric" in "foo_metric" > matches but isn't preceeded by a ';'. Fix this by matching the first > list item and recursively matching on failure the next item after a > semicolon. > > > [...] Applied to perf-tools-next, thanks! Best regards, -- Namhyung Kim