Received-SPF: pass (google.com: domain of linux-kernel+bounces-89030-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 1 Mar 2024 14:33:21 -0500
From: Frank Li <Frank.li@nxp.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: lpieralisi@kernel.org, bhelgaas@google.com, conor+dt@kernel.org,
	devicetree@vger.kernel.org, festevam@gmail.com,
	hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de,
	krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org,
	kw@linux.com, l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	manivannan.sadhasivam@linaro.org, robh@kernel.org,
	s.hauer@pengutronix.de, shawnguo@kernel.org,
	Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH v10 03/14] PCI: imx6: Simplify reset handling by using by
 using *_FLAG_HAS_*_RESET
Message-ID: <ZeItgeQuv8fZXJNC@lizhi-Precision-Tower-5810>
References: <20240205173335.1120469-4-Frank.Li@nxp.com>
 <20240301190931.GA403500@bhelgaas>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240301190931.GA403500@bhelgaas>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+UIyjwFWII4ywRNPthbOCKm4ouuyBOstqqF/ZOpHoaTYzFdeQQ2/a4IXCdWm?=
 =?us-ascii?Q?yyjMRZ6eNmfdkjmtNkj5lZzD1XQihgfFJ13jm855kaf907jwztHBDLDUY1Sn?=
 =?us-ascii?Q?AP5Vs5xvFDejavXvbJU53p9GUBMLBVGzrtKkUi1h14Ac6iPC1etm1flTLqEp?=
 =?us-ascii?Q?Cs7XO4kqtNBoNLEj07CRBFjIWu2WsK+rsOaOSGjc1QXC+KSxh43DukFpIJmz?=
 =?us-ascii?Q?03RM97a3c2k8y8VZJPeHj5GcU+JeT3Rk/r35C1dBBFYXI8o48Di+inmhLauf?=
 =?us-ascii?Q?cLhdyMqFa8c/DBARR5kb+SAHSPGiZHlfBQ/ptrirrVgeh4c6wMMES1j4oRW/?=
 =?us-ascii?Q?al80YvbQ43ZGoaFS4jmFUqQNvaovMjD5BHu3XkRnwxNE+N7Le7aH/nMl0p8v?=
 =?us-ascii?Q?z3KYMXhxlWEGfZWlJMFD2yLtVYLAjbRrNGP1q2koadCyW6phuxMKb55Sk9cY?=
 =?us-ascii?Q?qRDzAljxAOx9mav9OQAtvGLXCMXWzl3MtXkEYVNvZcbgUGVPBQ+G9NHXM0uD?=
 =?us-ascii?Q?YuICAqw1KqH8nlObBNRCo7L5S+uZgyqJav4Iy/+zwa8T3wJ/XgpinqGvk4+T?=
 =?us-ascii?Q?jnM9VONF9SnZSFm37WPUSFWFWkrUUYo5zi9gzPLohVNUZ+h6inArkHkDMUPC?=
 =?us-ascii?Q?zHJ5XXlyAyqRuAFlZ4+V7oGJ7roJdU0Hs3ouN5iiCPLMYBc4U7ee+9MD0Oob?=
 =?us-ascii?Q?LLLgnYfY9V8C0cEdv/dy2yB53vSj+RziML0n50F4M/VBEIz6avDcK8F+WaIb?=
 =?us-ascii?Q?nUz1OCco/9qFqPzqSm3/VDWBoJXT1yV/C+zhTwxvEB4pUivk19vwW+F547Rh?=
 =?us-ascii?Q?MsFlSW4KN0FmO8qi8jQccNatHr3IoA6FRUXBDUcpmu31oRex6ePNgkRyqe3F?=
 =?us-ascii?Q?3mskwJTswCT0JcmBNL3H7yW/+p7SuenrOl64HZOAPOJuVZybj2qmUPsVM0tq?=
 =?us-ascii?Q?clrGW+bfDK74LndgENbOaHG3tUcZgjpmOZkcmS+BVm55yT/ii2hl5I/aePRI?=
 =?us-ascii?Q?KLqESWNGXmbtxkM1fFWKFuGyiYbQkfCdSpQH6MXCjht7q7E+lwW5MmRA1W0V?=
 =?us-ascii?Q?yCXNWLMLZV+SbDKFvBZw9SpHe0dQuL1b0Rxl/tkMyp0//g/Xxd/DIicuxetP?=
 =?us-ascii?Q?7HbK9xVolQVYxKViFx2zHO1q62c8a169TM7nbR2pIDXZ2i11EIC3CALXO7Ql?=
 =?us-ascii?Q?p98pLGEeZK5xkQfEKkRmnfumuHjt3pYRPwYo/8BK0Whm3T/tvSpAirsJXguU?=
 =?us-ascii?Q?YtRMf/f2lHtSyuP+itfTdbecsfsD+361AMZKDo2njVTBloGvF5tUQt3+yhI+?=
 =?us-ascii?Q?Tq+8mY5W9C87ybDHcio6f/JzBVsLBLa9WPYxGq2TeTnr6b6nDQM7qikFMLK2?=
 =?us-ascii?Q?NdCm+Gbe1H05U5duIkdKCBEm1d24yMITSWipvJ3Ny5+rFdchYG9vaMxcXi8Y?=
 =?us-ascii?Q?sjua0GnUI9G9noES5ws8iblINS9iJ20+rX7DB8uJb4q+vbqWeurOvssF1Vee?=
 =?us-ascii?Q?Jic7UtfXuMsq2UfWrgxBN6MWdgHrn1XI0iynSVHgajH5GaVMsXaoubwX+QvM?=
 =?us-ascii?Q?VW9c1Jb1Tf3YycrDOVpjLCo8ayQ411154SQsik63?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83341ed4-8c1e-454e-49f0-08dc3a267ac3
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 19:33:32.3618
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fJeL/i26FFDFrjRqjOYlr5M5kq1R8EMY6kgryt+4YYr0xWNI9mgNfIVpHn07f0HLBr+d/siFge80Qd6o7i30aw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA2PR04MB10213

On Fri, Mar 01, 2024 at 01:09:31PM -0600, Bjorn Helgaas wrote:
> [+cc Nathan]
> 
> On Mon, Feb 05, 2024 at 12:33:24PM -0500, Frank Li wrote:
> > Refactors the reset handling logic in the imx6 PCI driver by adding
> > IMX6_PCIE_FLAG_HAS_*_RESET bitmask define for drvdata::flags.
> > 
> > The drvdata::flags and a bitmask ensures a cleaner and more scalable
> > switch-case structure for handling reset.
> > 
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> Lorenzo, would you mind squashing in Nathan's fix from
> https://lore.kernel.org/r/20240301-pci-imx6-fix-clang-implicit-fallthrough-v1-1-db78c7cbb384@kernel.org?
> 
> Also, the subject line has a repeated "by using by using".

I think that it is good to squashing it.

Frank Li

> 
> Bjorn