Received-SPF: pass (google.com: domain of linux-kernel+bounces-89053-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 1 Mar 2024 15:01:53 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: LKML <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org, Masami
 Hiramatsu <mhiramat@kernel.org>, Mathieu Desnoyers
 <mathieu.desnoyers@efficios.com>, Cong Wang <xiyou.wangcong@gmail.com>,
 vaclav.zindulka@tlapnet.cz, Jiri Pirko <jiri@resnulli.us>, "David S.
 Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Coco Li
 <lixiaoyan@google.com>, David Ahern <dsahern@kernel.org>, Jakub Kicinski
 <kuba@kernel.org>
Subject: Re: [PATCH] tracing/net_sched: Fix tracepoints that save
 qdisc_dev() as a string
Message-ID: <20240301150153.36e5bf60@gandalf.local.home>
In-Reply-To: <CAM0EoMkOgTezVLnN7f1GoXTURQ73LmXjHnBjQBSBRPnv58K-VQ@mail.gmail.com>
References: <20240229143432.273b4871@gandalf.local.home>
	<CAM0EoMkOgTezVLnN7f1GoXTURQ73LmXjHnBjQBSBRPnv58K-VQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 1 Mar 2024 14:24:17 -0500
Jamal Hadi Salim <jhs@mojatatu.com> wrote:

> > Fixes: a34dac0b90552 ("net_sched: add tracepoints for qdisc_reset() and qdisc_destroy()")
> > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>  
> 
> Should this be targeting the net tree?

I was going to say that I need this for my work, but my work is aimed at
the next merge window, but this should go into the kernel now and be marked
for stable. So yes, it probably should go through the net tree.

Do I need to resubmit it?

> Otherwise, LGTM. Just wondering - this worked before because "name"
> was the first field?

Looks like it. See commit 43a71cd66b9c0 ("net-device: reorganize net_device
fast path variables")

I wonder if there's anything else that uses a pointer to struct net_device
thinking it can just be switched to find the name?

> 
> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>

Thanks,

-- Steve