Received-SPF: pass (google.com: domain of linux-kernel+bounces-89056-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240301-class_cleanup-power-v1-1-97e0b7bf9c94@marliere.net>
In-Reply-To: <20240301-class_cleanup-power-v1-1-97e0b7bf9c94@marliere.net>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Fri, 1 Mar 2024 21:04:25 +0100
Message-ID: <CACRpkdbVUUTh+VA0Tjp6Y=L5nx-p6YKuJ5XjWYTm_Q_Kfmz9ig@mail.gmail.com>
Subject: Re: [PATCH] power: supply: core: make power_supply_class constant
To: "Ricardo B. Marliere" <ricardo@marliere.net>
Cc: Sebastian Reichel <sre@kernel.org>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 1, 2024 at 6:46=E2=80=AFPM Ricardo B. Marliere <ricardo@marlier=
e.net> wrote:

> Since commit 43a7206b0963 ("driver core: class: make class_register() tak=
e
> a const *"), the driver core allows for struct class to be in read-only
> memory, so move the power_supply_class structure to be declared at build
> time placing it into read-only memory, instead of having to be dynamicall=
y
> allocated at boot time.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Looks good!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij