Received-SPF: pass (google.com: domain of linux-kernel+bounces-89063-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <1d6c298a-81d5-4ffd-becb-3a796690f4be@ancud.ru>
Date: Fri, 1 Mar 2024 22:53:29 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Nikita Kiryushin <kiryushin@ancud.ru>
Subject: [PATCH] staging: sm750fb: Remove unneeded setting of
 info->screen_size
References: <>
Content-Language: en-US
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
 linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
In-Reply-To: <>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


In lynxfb_set_fbinfo info->screen_size is set twice, the first value is
never used and then overwritten.

Remove the first time the value is set.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 81dee67e215b ("staging: sm750fb: add sm750 to staging")
Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru>
---
  drivers/staging/sm750fb/sm750.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/staging/sm750fb/sm750.c 
b/drivers/staging/sm750fb/sm750.c
index 04c1b32a22c5..70d1c8292df0 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -845,7 +845,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, 
int index)
  	info->pseudo_palette = &par->pseudo_palette[0];
  	info->screen_base = crtc->v_screen;
  	pr_debug("screen_base vaddr = %p\n", info->screen_base);
-	info->screen_size = line_length * var->yres_virtual;
   	/* set info->fix */
  	fix->type = FB_TYPE_PACKED_PIXELS;
-- 
2.34.1