Received-SPF: pass (google.com: domain of linux-kernel+bounces-89046-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Zi Yan <ziy@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>,
 Aishwarya TCV <aishwarya.tcv@arm.com>,
 "\"Pankaj Raghav (Samsung)\"" <kernel@pankajraghav.com>, linux-mm@kvack.org,
 "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 David Hildenbrand <david@redhat.com>, Yang Shi <shy828301@gmail.com>,
 Yu Zhao <yuzhao@google.com>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 =?utf-8?q?=22Michal_Koutn=C3=BD=22?= <mkoutny@suse.com>,
 Roman Gushchin <roman.gushchin@linux.dev>,
 "\"Zach O'Keefe\"" <zokeefe@google.com>, Hugh Dickins <hughd@google.com>,
 Luis Chamberlain <mcgrof@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
 cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge
 pages to any order.
Date: Fri, 01 Mar 2024 14:41:33 -0500
Message-ID: <F3804804-160E-4333-A856-FEEF486BECDC@nvidia.com>
In-Reply-To: <dda99ee0-87a2-482d-bf28-bd5e5a97b46e@sirena.org.uk>
References: <20240226205534.1603748-1-zi.yan@sent.com>
 <20240226205534.1603748-9-zi.yan@sent.com>
 <082e48c8-71b7-4937-a5da-7a37b4be16ba@arm.com>
 <0dab0c69-2eac-4e65-9efe-e0b037499abc@arm.com>
 <08703C70-DD6E-446A-9ABC-BC2C8E33B8CD@nvidia.com>
 <f7a3d07d-290b-46d6-884e-fa288901c3c6@arm.com>
 <3D5A5D18-0A20-4BB3-B667-0CB5799BA665@nvidia.com>
 <6003865f-2c85-4dd4-9803-6204f9018f50@arm.com>
 <dda99ee0-87a2-482d-bf28-bd5e5a97b46e@sirena.org.uk>
Content-Type: multipart/signed;
 boundary="=_MailMate_8DC0A61B-BE87-4E39-B867-2FEC0960BDE0_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?dd5pw+s82kdS1pJiJ/SDJLVVUFDhmb7igfie6iQGIDxRIWajqmRDmGH0x8eZ?=
 =?us-ascii?Q?X3/bheIPSDio0eitU/06Aa27WzgmSI+VP2bOLTOvt56gi1CM/PAqEvaKWVDe?=
 =?us-ascii?Q?NRtXl+jvwOZxt5RF2pDJFbW7bda2TU2reuQGbRa3U4o6oESfxuQ7G0glvwQ6?=
 =?us-ascii?Q?oHG3dyc06VpheDtTFaW92XS9qo8jHUSEo5XIvXlRcesM3/IIv1DkqreVk2RI?=
 =?us-ascii?Q?K8YJwCy9S28e3QC1vHtEWAjhoguEv7h9tNaXOwKSJx5ClYLAStjNaURh1+ti?=
 =?us-ascii?Q?wrndFwaOgjeKhlkCidxZgQLAOtI1sGA+oiwBt99T4AF9mIQoTaKqugQyDl/R?=
 =?us-ascii?Q?tsDSnZkfYregysyqW0lPIPWUXMEybaRLvA5k3IzmecmgDUY22uTCaG/V1dzF?=
 =?us-ascii?Q?6K2tT6xMF4BmV3yZEBSXho+xWFblviZdyFiJCeqLEmQBUXTB0l7X2P2TsYii?=
 =?us-ascii?Q?IBeX14WVWZcyUZo7HY6hhbbQ37ffHv45nO2CQvu7HM8ZA+kgNcASiHVBpwcd?=
 =?us-ascii?Q?jFKLfd5GpeMOydceu3qQYB7DACtw6qKSK0KwRXNszzZTjcUjrspfFCHNw/D0?=
 =?us-ascii?Q?D4sZOmQguzc21FK9qs8DhhLofAPu4FpDOgUF0m+BJEHpK/Z8akhFkZRJG7oJ?=
 =?us-ascii?Q?HKuZzY+D5dBRRZUxGVvamT59Nc1DqnInR65RljD/hb9wMMM0KQm9oM1lrmOi?=
 =?us-ascii?Q?4FgFreRhfBndDrbgLRPY59d7NPJzSqxNO8zzXim/vuUENK79Op6VWNvELucz?=
 =?us-ascii?Q?TsSX32/EWrv4ukzqXuX26dRviauVW0TbBRkj96jbR5vpb9JC7Yn6GxywzRi9?=
 =?us-ascii?Q?6G6e253ZC6+BR+gCMVv3eqyEJtqH6mmdLx4YKD+2HejHYTTySz4ZJfmai/bz?=
 =?us-ascii?Q?MVjfqN35OmLIr1cj6fc/ttdD9B4U60l+8jiwHMMzYQ2fh1XxcLoCgT3E1Bhy?=
 =?us-ascii?Q?b5hgCpP4c0UKr6PTBjGnq72wXDP5in+3ur5KLuOza1U2AvexOorQsm48h5A/?=
 =?us-ascii?Q?+O87jngyMbgAybom+E6Y/C3fp+QJ0Q3zmudyLCNuWKh9AZTl5GL5qlvdjrhb?=
 =?us-ascii?Q?9nz9ODOVZWCAy5JKER3R0zJbFJ7H+F0u2YzyAk1JsJzcnJMjUmQAM60auodw?=
 =?us-ascii?Q?2cYTSURMSCb7y/GD0jr6Hianj2QeOREWUP7fvRYcjH6ILqUW2Yvq0lIIAsLi?=
 =?us-ascii?Q?MkpiRrtcAaZNkIY+nVBzThBPV43Co53mkuslnVz5Bd5lr1lX/MTrkT1LuROL?=
 =?us-ascii?Q?D5+je/jpNWTOsboCS9OgclX6rJkIAiEHBlofJslwKJdYbNGdQIbeOE6oV3+6?=
 =?us-ascii?Q?+m28w6fdZHf2yraJ5o9aqmuDt/T3aYLMkXLIXCjMd2WKA0KFMYQPTiskHKWs?=
 =?us-ascii?Q?2+VQ8Sawyl+sMI/fchPlqVWu3/MJ+/tbDX+zpd+3Bov/wWGvYTysqU7WSYMj?=
 =?us-ascii?Q?F9666aA2Ozlx/Scf6dx1Zb8BytJuQhe83kPoRu0OkZxuc8HsTCwQzpwE7qj2?=
 =?us-ascii?Q?doA4nGvHWl9kuoNi6niggXz4mnyW0CGiCl81W6z/TJZdoerXCTvtedFT3AdO?=
 =?us-ascii?Q?tA2YBJXIlC5Uu00Bx/NEkryZFMPXW1duC2t/ZUbb?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c74d5d2b-5304-4d66-d8b3-08dc3a279b59
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 19:41:36.5475
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kKOlzZokI8Qhddu2EBGrngXa7T5K7alfCRn+NPMjwA5O0oGA2aZA5g1sOKDGgVAt
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6843

--=_MailMate_8DC0A61B-BE87-4E39-B867-2FEC0960BDE0_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 1 Mar 2024, at 9:27, Mark Brown wrote:

> On Fri, Mar 01, 2024 at 02:18:16PM +0000, Ryan Roberts wrote:
>
>> Although I agree it might be a tall order create and mount an XFS fs i=
n
>> run_vmtests.sh. Perhaps it might be good enough to add an optional par=
am to the
>> test to pass a path when running the test manually, and if that's not =
provided,
>> just try to create a temp file in the current dir and skip if its not =
the right
>> sort of fs?
>
> Yeah, if it needs to be a specific kind of on disk filesystem then that=

> needs a lot more integration with CI systems (a lot of them run entirel=
y
> from nfsroot by default!).  Being able to specify the location via an
> environment variable would also be good, it could fall back to the
> current directory if one isn't set up.
Hi Mark,

I have changed the test[1] to:
1. accept XFS dev as an input,
2. mount XFS on a temp folder,
3. skip the test instead of fail if no XFS is mounted.

Let me know if the change looks good. Thanks.

[1] https://lore.kernel.org/linux-mm/A111EB95-0AF5-4715-82A4-70B8AD900A93=
@nvidia.com/T/#u

--
Best Regards,
Yan, Zi

--=_MailMate_8DC0A61B-BE87-4E39-B867-2FEC0960BDE0_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXiL20PHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUu+IQAJxy3sXUUsiuly0NQICwy4zzCJRny3MlJ/ax
Wgzc5vBLrJ4qXzvuYKQnatMq8kWLN4u9FN7sOwBQq0yo7uWypT9F4iV6s1ijbn+z
CA4DVTGvWXpFSSDCG6AFMJYiKsCVIPXj7bfKv3Q8vxbrUIK+Jd5aYhAFocG44xu2
m91TnDKMMRiLgC7fFHWpVivbKCQo3zWWEcGKlU9CXQ9iB4sDf3VKVC+48QXjH2MX
JJhYlaxYjaxNELmnKekjAE5sZ46v1ZEEKH+Buk9xTNGyMVttITBl2BG949YSxk0V
tTmcQvXYB7Rm3+crW6X8tfwHi4BTZD14wqPdUqY7204ghh2wEkEfEpu2JwA0YXtv
io/2u2hCzLLEQnYAKh4Yw1Xc4orXFPWVEOwxuI6iMJzezqZn9vwgjyYvG0kMToGd
K0TYZzI+z7bJbIV8SBnjfRxmSlLsE/MXXEV/W78ac8DmfSSI6HsojHRJClBk4ojb
XPinXnXf9JL8K5ABbIjGMSQWZP6SsTLTQOH40GzKze+rKMwsDGcH7aFVQqmaLmac
2c7VhLlxsLqw7TAwaiXKMhYtnSEgbxYBTIhTVXWCxyuS7g/QsP5hKSPMtCPNboGn
AFWW3xfuxh+S+oUsvo7hJYbPHzWCuGRWTo45df+5nilzktL4mP8IVaJ8ABqrCQG1
rwwisIVf
=us7i
-----END PGP SIGNATURE-----

--=_MailMate_8DC0A61B-BE87-4E39-B867-2FEC0960BDE0_=--