Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755988AbYACXnQ (ORCPT ); Thu, 3 Jan 2008 18:43:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752073AbYACXnA (ORCPT ); Thu, 3 Jan 2008 18:43:00 -0500 Received: from wa-out-1112.google.com ([209.85.146.180]:13618 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435AbYACXm7 (ORCPT ); Thu, 3 Jan 2008 18:42:59 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=VvBuO9C1JFZqZiyrF5Y4Ql3bhsRzfyfCS5nJQpI9mSgSHD6m+ocuFUgKLDoCqv8BEIzfLcDbi5TICZQELHTLgnhfeYCzADfrYGxlF1PtSPmmCDYuzCNbZv1aJtgtGUJqC5iixH4p2F0+nypsnFQy/QXw8I5u8PfLPNC4vDKokYo= Message-ID: <9a8748490801031542m1f640731m12c96c59df967416@mail.gmail.com> Date: Fri, 4 Jan 2008 00:42:58 +0100 From: "Jesper Juhl" To: "Paolo Ciarrocchi" Subject: Re: [PATCH] This patch to printk.c fixes a few errors reported by checkpatch.pl Cc: linux-kernel@vger.kernel.org, bunk@kernel.org In-Reply-To: <20080104001446.66f0c110@paolo-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080104001446.66f0c110@paolo-desktop> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1049 Lines: 25 On 04/01/2008, Paolo Ciarrocchi wrote: > This patch to printk.c fixes a few errors reported by checkpatch.pl > [...] > - for (a=console_drivers->next, b=console_drivers ; > - a; b=a, a=b->next) { > + for (a = console_drivers->next, b = console_drivers ; I would say that if you are modifying this line anyway you should make it read for (a = console_drivers->next, b = console_drivers; (the change is the removal of the space before the ';' at the end of the line) otherwise I think it looks sane enough as a small style cleanup. -- Jesper Juhl Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/