Received-SPF: pass (google.com: domain of linux-kernel+bounces-89125-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <21ee5e7e-bddc-48ae-82f8-c8fb611d0a12@amd.com>
Date: Fri, 1 Mar 2024 14:54:26 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] ARM:dts:aspeed: Initial device tree for AMD Onyx
 Platform
To: Paul Menzel <pmenzel@molgen.mpg.de>,
 Supreeth Venkatesh <supreeth.venkatesh@amd.com>
Cc: Andrew Jeffery <andrew@codeconstruct.com.au>, joel@jms.id.au,
 andrew@aj.id.au, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org,
 linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, robh+dt@kernel.org
References: <20240110033543.799919-1-supreeth.venkatesh@amd.com>
 <572d53516dee6db5af7089090056185abb4e78c7.camel@codeconstruct.com.au>
 <74cd8a61-3d9f-437e-8e3a-22139e23bda5@molgen.mpg.de>
Content-Language: en-US
From: Supreeth Venkatesh <supvenka@amd.com>
In-Reply-To: <74cd8a61-3d9f-437e-8e3a-22139e23bda5@molgen.mpg.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N1JScCtDRFczZXJ6NHF6MXhFN0l1SERsQjRCSGp2NFdnS0lnRDBrQUhId2xu?=
 =?utf-8?B?czI5UmtTS3dKT3l1aWVZQUJHK3dVb0E4RUdHWUlnUnM3RUJSOHREOGNVY0Zs?=
 =?utf-8?B?KzZNVmJhOUQ3dUltSlUxNVhDSkN6RUU5dWRCc3B0dTkrMktMVnFtcEJmdTZD?=
 =?utf-8?B?TzJhZk1Sd3pHRkhPUVoxUDUrZ2dGaEM4SFFVYnJxYVY3ek94WW1RdFFFTzcv?=
 =?utf-8?B?NFg3YmFVM1NkUm4xTnFNYk51K3dodUJXTWhEZnVmd2tDZldVeCtRWS9Ma2xh?=
 =?utf-8?B?V2crdzFQOEk1M1R2cmtzcldLVWVmYS9lYmdTakdXUmFkMU0zNDlWNXdGeDZZ?=
 =?utf-8?B?QmpMTktaenVaNFRvc0lhZlFiYXo1SmtqaG04VmY1TUlFNEZGQS9PU1lwV2Mz?=
 =?utf-8?B?VmhaMFNFRDdvRDlyeU8wOXBpUDAzcEFITzk3YWtHcmdITUROaE0yaW5XNDFv?=
 =?utf-8?B?L2k2UTVYSHZ3WVFWQXlOYSt3SHZaNnRVcFR2czdxRTdhYjJYRUJSVXp0L3Qw?=
 =?utf-8?B?TVBtakFoYyszYU5OcEJIUWlRbXRKeldjcDB5U2F3U0tiS1N5VnZCbTJlY0Qr?=
 =?utf-8?B?N0xoREowNG9EWUhITlZmeW14Y3lDdzdHZmJHYjk5eVgrOVFSanBCa0g2YnVB?=
 =?utf-8?B?YWZKMDQ4d0J4Y2RoQ1B1S2wweGpyRkl3MjJ5eU53cm16UlRVVTZoY1NyQ1BN?=
 =?utf-8?B?T21xNThEeTJ4VU16WEgwWGtGZ3RRaHlVd2dndHlmbzlsN1VFR3dYWEtRVGxY?=
 =?utf-8?B?R2wxVE51UzYrWVUxKzMraGkweThlT0hqc09mTEJpK2VtRzBwVTlMaE9ueEd0?=
 =?utf-8?B?VlhiSWp6a01kYXNRMGlUTGJaY2djT012dW5TZVRtc2N3a01aMHZUTnYweXdk?=
 =?utf-8?B?anR6NzZoa3lZZUl5ZTU2N2hicllXU3c3cmcycGo4M05BZXp0aUw2blBTVFVU?=
 =?utf-8?B?bGVDdHhGOVZwWjc5RGFSNUtaa1FTUzZFd3NLenU5L3JKdTNmYm56YVJZd3Zl?=
 =?utf-8?B?OVpmOWQySGdISGFSMW1ieXFNNkNZcWtXT0V1SEd0QzNicWl1V0hUZVd6V0Rk?=
 =?utf-8?B?QllZc3JFRmN5cFBRNEZnUGlxcFBKczBOWEdhcDVFN1BySGZwcndqc1VqUHNl?=
 =?utf-8?B?b1VFUUFqN2RBL3R1VVpBYTJ4Zi9LMTNYNCtmMXVWVEE0eDZPV3NLNVpESUIw?=
 =?utf-8?B?RkJLdTNYM29ma3l5MkhWKzBzUzJQWTZhSkh1N1VDbzJHSkZsRlpTYWYwVFFx?=
 =?utf-8?B?V3pTOEw1SHhXc1VNcjFIZGJTNUp2QWZTb0ExZm94WjhFVGpmNGd3YTdpU2hL?=
 =?utf-8?B?VWNjNnVjSnQzQ2RCUTgyazhicmxvcHJHRmdYdUxSRkRIN2Q2Z1QwZ1B3WWFI?=
 =?utf-8?B?QzhUdEw0TXNwZmNrV0Jodnl3Y05VZFE1eUNjMTlFczlTbmMxOTFtOFcveVVJ?=
 =?utf-8?B?b1cyRnJJSyt2VVlJTWExc2VaZ0w2VGNUNkxVNXRSb0JYZmIrQVk4eXVzdWk2?=
 =?utf-8?B?bFNudXE0TGxoa2g1aEVJNWdpYzNmQjJQSUJIb2N1WDZucG9oUnNLNGVMbThx?=
 =?utf-8?B?cEZIQVIrMEFiejFOOUdIeUkwUWM4dnh2c00xam8yMC9NQ3VjbkNBMnEvZkNh?=
 =?utf-8?B?c3p3K0h6NlNXRG1FcHVDbDVLTVY3MXptenB3OHh6WmhyTjJFN2JISCtHNC9M?=
 =?utf-8?B?QVovcTVURTBvdFU4SDdIc2ZIT1JrdzZ6RlpYMVVkdnpCQnZhejhMbmJsVXhl?=
 =?utf-8?B?b3U0UERuUndDdmNpcllleFVyRnVkNU9jVG1obGtmQ0J6VC9zKzExWGo0MzFV?=
 =?utf-8?B?RFNldDd3YnY0anpNTDlEeDFieXhsRDdJR0VyMkx5a1AyNG5oellQY0k0bU44?=
 =?utf-8?B?c2k5UUdaTDRvc2VMUGJqOGpLNjEweHR2aVBXRlhjTitZYjBiVW9najVzYjRt?=
 =?utf-8?B?UEs5RlFURDRrd1VLZXgwcnZ1Q1EyNDNlWmtTMGVjcHM2YzRHa2YveXVVcE5E?=
 =?utf-8?B?dkdUWnhXdzFZbk4rNWpYUmZKL2J4YjlKRXBXTDJ5UGlDL25KdkpwenYyWjRy?=
 =?utf-8?B?V3VzMVNxYU41Q3RsQUUxVWFGS1JRSGVZTXgybzNlSUQybWhhak1aNmQ2QTMx?=
 =?utf-8?Q?unHQDJdId0Towl8bHtPggwmu+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6885683a-a454-4eec-1c8c-08dc3a31c95d
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB4752.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 20:54:28.7124
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /Oo/ZKBih0jKHYztNUWuC9YEod9vR/G0vNypXldL6H/JBlNAJHBLawCAl7JnkP8RyFlZBqwjxa5WLIIB2lmfpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4212


On 2/26/24 01:10, Paul Menzel wrote:
> Caution: This message originated from an External Source. Use proper 
> caution when opening attachments, clicking links, or responding.
>
>
> Dear Supreeth,
>
>
> Thank you for your patch. Should you resent three more nits.
>
> Am 26.02.24 um 07:55 schrieb Andrew Jeffery:
>> On Tue, 2024-01-09 at 21:35 -0600, Supreeth Venkatesh wrote:
>>> This patch adds initial device tree and makefile updates for
>>> AMD Onyx platform.
>>>
>>> AMD Onyx platform is an AMD customer reference board with an Aspeed
>>> ast2600 BMC manufactured by AMD.
>>> It describes I2c devices, Fans, Kcs devices, Uarts, Mac, LEDs, etc.
>>> present on AMD Onyx platform.
>
> I’d capitalize I2Cs, UARTs, and MAC, but would write fans.
Thank you. will incorporate in v2.
>
> Also, could you please make the summary a statement by adding a verb in
> imperative mood. Maybe:
>
> Add initial device tree for AMD Onyx Platform
Thank you. will incorporate in v2.
>
> I’d also add spaces after the colons in the commit message summary.
>
> […]
>
>
> Kind regards,
>
> Paul