Received-SPF: pass (google.com: domain of linux-kernel+bounces-89128-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <023f6f6c-dadd-4933-ac2c-15dfe77bd90e@amd.com>
Date: Fri, 1 Mar 2024 15:02:05 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] ARM:dts:aspeed: Initial device tree for AMD Onyx
 Platform
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Supreeth Venkatesh <supreeth.venkatesh@amd.com>, joel@jms.id.au,
 andrew@aj.id.au, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org,
 linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, robh+dt@kernel.org
References: <20240110033543.799919-1-supreeth.venkatesh@amd.com>
 <d4fe8b55-a1ea-4ce7-89ac-ce17e8ff4e45@amd.com>
 <dda6c22e-8f35-4c18-9fea-6a6295dee3a1@linaro.org>
From: Supreeth Venkatesh <supvenka@amd.com>
In-Reply-To: <dda6c22e-8f35-4c18-9fea-6a6295dee3a1@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dzd6OHRyL1JsNGgxMllsbXVUQUFTQy9NTEdjcVVpWVVxVzFBckNFLzFTK0tk?=
 =?utf-8?B?RDVUMnJQam83M2U5dlh5b1djWjFQWkN6aStyQkVrTXlIWmUzTjNZTHJLeEZs?=
 =?utf-8?B?S2d6NGQ3dDZEN0dadC9Uc25yMUNHa1FmQ3d2QWUvR3U2YkhRVGtiT29wa0lB?=
 =?utf-8?B?Y0Q5L0VnT3pjZ3loK1MrRWRhamVSaFkxY0VVN3YwaGhJMEdodUl6MXBVZGQ4?=
 =?utf-8?B?dDdqWnAyYU5kYk9PWnhCOW05YlNXMDVSdnhyTkJKdUJJSU9QNGprbWlLK3ZY?=
 =?utf-8?B?Q3VsVjZPekFGUmx2ZDVSUnlCOCtteWFwR1czeWZwV05wTEJ3U1BGa01WTlBm?=
 =?utf-8?B?MzRHN1AzaFYyQzF3aE1PN3pQU0ltWGZTaGpOTnBndWpZY25vR2U3cEV0Rksr?=
 =?utf-8?B?VWFlcHNDYUI1eG45V2dYUk80UWs5cnRJRGR1OG1BTWtoWmFFZE4vWjNtY3Rh?=
 =?utf-8?B?ZGRMSVNMam5ScXdBaUROWGVRVlBGMFRkVGNTKytBUmZBVVZXd0kwamNocFk1?=
 =?utf-8?B?K0F6NFltUW1sM0YrT0RMdkIwS0NNWW94MENmWTVHZGN1U0tFVTYrWjdIUEEv?=
 =?utf-8?B?bEZ3eUlmNnB5RC9VelpNMkdGNmhaczFWSUk4c282R0RNUUFIejFISWRyOE5l?=
 =?utf-8?B?WUM1cDJoQWZmQy9mSGUwV0NuR1pOQWwycHlzdXFjL2RoTVM2TUNvZUM3NVZE?=
 =?utf-8?B?b3VKN2RYanpHNWdVMU9KOXh3YjI0Q1BiWHhlRXRFL2Y2Yi8wOXN1QVk1N3Zr?=
 =?utf-8?B?d3JKdkhYOFFsQ0dJWnRNemZYaWdGV0hVVjBvV0RJK0VyWENEVCt0eEVJUEcv?=
 =?utf-8?B?WHBGc3o5WEYvbEQxU2E2TXZTemVHM2gwNS9uM0crb0lxSVNWMW5wWnRiUzFP?=
 =?utf-8?B?TWVCaWE3NXlLeVphQ1VxamszTURKeWFpaFRNK0dGRW9mU3QxQXJuWGlTNnFO?=
 =?utf-8?B?TzBJUlR3ek41L05MWDI5L0xUMTh3QTExZUh1Kzd0VnIzS0JjRk1XL0J1R2tr?=
 =?utf-8?B?RzdLTkRvQWRORlFmUG9QamJ2ZDdUZ3Rkd3hKdXpZQ1FCNEljSXR2RWw5R1V0?=
 =?utf-8?B?ZlcvN1FQcUhGSE9ib0VybFA1QlUyc0Z6eTBkVG43UUdqdkhWZkNheGFHMGwz?=
 =?utf-8?B?em5YMUtXWEcvMSt2eUM2Nnh1eTVQbkJQcmlYQ09va1l2bTV5NTgyZVdqYjhU?=
 =?utf-8?B?czVnL0dQSThTTnovQjlhcG9jbW5aUTFuYzVsZTVSZURrQ2tMcGl6V0RySUZt?=
 =?utf-8?B?WWF6bDhscDYzaXU3WmZxSjlNdThaOUkvb1VLQjExb2t1bTNaakxQOXdDblBy?=
 =?utf-8?B?dVErRzFsa2JKbExPM2FTRWNTYnVyRHNEQ0tYUHFpRm90b0ovOUNQa0ZQcVBM?=
 =?utf-8?B?b1hYKzczVjVxK0NoYlp0d1FvNEt2VmFERUYzTk9ia2FmbGNEMktONGJSb2hQ?=
 =?utf-8?B?dlgvVmJab0lkMVFGcGMwQTFrUVpHS1FYKzRjYmgxazFUVlBWZnYrQjBrb3Nr?=
 =?utf-8?B?QXRJU1dONkVoaUpFdXlXWmtBcjFsSUQrZDJQUDFhaTdzWlNLMitJVDlHM3Rj?=
 =?utf-8?B?eHp3RnZNMXJ6a2loblFod2VobWtTd3V4S3g4bEhVVjN2OU9xN2pMTWJnZkZo?=
 =?utf-8?B?R3NiOWtJT2RlY0w0ZlNKM3owSjlmYUwwSWt4aXMyU0dCV0psTFFrUzFPZjVF?=
 =?utf-8?B?M0xQTk5wUHJCdGVQNkE0U2xoWlVEWm9WSDd1R01LN0x0b0VUZDVsZndFeXMy?=
 =?utf-8?B?QWVmWUhCUUk0dGtSNFdldEczbUNtUjVNL3RMYWhrUHkwZVhESDZ6VjF4ZjI5?=
 =?utf-8?B?RVMyWTJuU1lMblhIcDBWZTA2cXFIeW4xM3VjZkd2d093TFFVdlV6RGhUcGFQ?=
 =?utf-8?B?Q2o2L1JWVHVzTFBXdFBRS0xhTkQ3aHh3WFhWaXhRODV5ZFRlNlhuVy91SVhF?=
 =?utf-8?B?ZkFpVUdWU2hkbURXb282M3ZjM0hoaGlIYmpNaFpibEdscitXUFlKUXFvdS8w?=
 =?utf-8?B?a011N01sTENzd1J0NnZOclo0c3FkNEpNS21kUjhLVnZyV1gwQjQ1dGZtZ2ly?=
 =?utf-8?B?U0dLSkV4YmUxS1hJRDhyNGJrUzJuRVFWa0ZpcndYMWlRclJkM2diS3NLaG9U?=
 =?utf-8?Q?1H/CqqgNuWLIC+KZ9fXHnU9Q/?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71459798-a8f5-4df3-dffc-08dc3a32daee
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB4752.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 21:02:07.6759
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7/RgR4jmW4z7CzqPIgjWvfaQ+ikqipJKLlxrW+bV08ca2uUOwsFezZ+3OOInHkHwnTmIjeCHHrq0I6k4F0VePg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8758


On 2/9/24 06:38, Krzysztof Kozlowski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On 08/02/2024 15:57, Supreeth Venkatesh wrote:
>> This patch is pending for a month now.
>>
>> Can DT maintainers please help review this and provide feedback?
> I don't have the original patch in my inbox anymore, so probably you
> should resend. Anyway quick look points to obvious issues (comments below).
>
>> On 1/9/24 21:35, Supreeth Venkatesh wrote:
>>> This patch adds initial device tree and makefile updates for
>>> AMD Onyx platform.
>>>
>>> AMD Onyx platform is an AMD customer reference board with an Aspeed
>>> ast2600 BMC manufactured by AMD.
>>> It describes I2c devices, Fans, Kcs devices, Uarts, Mac, LEDs, etc.
>>> present on AMD Onyx platform.
>>>
>>> Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@amd.com>
>>> ---
>>>    arch/arm/boot/dts/aspeed/Makefile             |  1 +
>>>    .../boot/dts/aspeed/aspeed-bmc-amd-onyx.dts   | 98 +++++++++++++++++++
>>>    2 files changed, 99 insertions(+)
>>>    create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts
>>>
>>> diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile
>>> index fb9cc95f1b60..2b27d377aae2 100644
>>> --- a/arch/arm/boot/dts/aspeed/Makefile
>>> +++ b/arch/arm/boot/dts/aspeed/Makefile
>>> @@ -5,6 +5,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>>>       aspeed-ast2600-evb.dtb \
>>>       aspeed-bmc-amd-daytonax.dtb \
>>>       aspeed-bmc-amd-ethanolx.dtb \
>>> +    aspeed-bmc-amd-onyx.dtb \
>>>       aspeed-bmc-ampere-mtjade.dtb \
>>>       aspeed-bmc-ampere-mtmitchell.dtb \
>>>       aspeed-bmc-arm-stardragon4800-rep2.dtb \
>>> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts
>>> new file mode 100644
>>> index 000000000000..a7056cd29553
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts
>>> @@ -0,0 +1,98 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +// Copyright (c) 2021 - 2024 AMD Inc.
>>> +// Author: Supreeth Venkatesh <supreeth.venkatesh@amd.com>
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "aspeed-g6.dtsi"
>>> +#include <dt-bindings/gpio/aspeed-gpio.h>
>>> +
>>> +/ {
>>> +       model = "AMD Onyx BMC";
>>> +       compatible = "amd,onyx-bmc", "aspeed,ast2600";
> Undocumented compatibles.
This is a new device tree file.
>
> Please run scripts/checkpatch.pl and fix reported warnings. Some
> warnings can be ignored, but the code here looks like it needs a fix.
> Feel free to get in touch if the warning is not clear.
>
Will do.
>>> +
>>> +       aliases {
>>> +               serial0 = &uart1;
>>> +               serial4 = &uart5;
>>> +      };
>>> +
>>> +       chosen {
>>> +               stdout-path = &uart5;
>>> +               bootargs = "console=ttyS4,115200 earlyprintk vmalloc=512MB";
> earlyprintk is debugging, not for mainline, so drop.
>
> Console should be encoded in stdout-path.
>
> vmalloc looks like OS tuning, so also not suitable for mainline DTS.
>
Thanks. Will remove vmalloc. However, I will check whether existing 
device trees for BMCs to check

whether existing DTs have earlyprintk.

>>> +       };
>>> +
>>> +       memory@80000000 {
>>> +               device_type = "memory";
>>> +               reg = <0x80000000 0x80000000>;
>>> +       };
>>> +
> Drop redundant blank lines.
ACK.
>
>>> +};
>>> +
>>> +&mdio0 {
>>> +       status = "okay";
>>> +
>>> +       ethphy0: ethernet-phy@0 {
>>> +               compatible = "ethernet-phy-ieee802.3-c22";
>>> +               reg = <0>;
>>> +       };
>>> +};
>>> +
>>> +&mac3 {
>>> +       status = "okay";
>>> +       phy-mode = "rgmii";
>>> +       phy-handle = <&ethphy0>;
>>> +
>>> +       pinctrl-names = "default";
>>> +       pinctrl-0 = <&pinctrl_rgmii4_default>;
>>> +};
>>> +
>>> +>> +
> Drop redundant blank lines. You can open existing, recent DTS from
> maintained platforms like Qcom or TI and look there at coding style.
ACK.
>
>
>
> Best regards,
> Krzysztof
>