Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp550320lqg; Fri, 1 Mar 2024 13:11:44 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVaiuAl+rtFGsXk/MppNuolX6WmRBw16Ae8vtvZ3yANUcqy02V07ybBGDGAnLGtfhHxK53psBi2h8yrmwwErbPkY4H3SuBXFx0s5vyONA== X-Google-Smtp-Source: AGHT+IHcqgL4uX7yEBItbwK1QUToXaiavnDL/KJ+lQi5UJ751iDYOnOXB0ga/uwTs0oSHa2mGZkF X-Received: by 2002:a05:6a20:2a1f:b0:1a1:2fdc:d213 with SMTP id e31-20020a056a202a1f00b001a12fdcd213mr2087475pzh.35.1709327504297; Fri, 01 Mar 2024 13:11:44 -0800 (PST) Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id lp7-20020a17090b4a8700b0029b2a45ce16si1366813pjb.180.2024.03.01.13.11.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 13:11:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89126-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=uVd7N91f; arc=fail (signature failed); spf=pass (google.com: domain of linux-kernel+bounces-89126-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89126-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6D977B21F5D for ; Fri, 1 Mar 2024 20:57:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0D73256777; Fri, 1 Mar 2024 20:57:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="uVd7N91f" Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2043.outbound.protection.outlook.com [40.107.220.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B99655798; Fri, 1 Mar 2024 20:57:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.43 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709326640; cv=fail; b=t5mNd0X7t1jEv5YaZ0G+0d5GRCLW8hcCDJWAUkIcCUmjdZDzlcYQCLGhSoCw8Viq6JvQDszeFw+X7cZP0TkFyaXtLW6J7NnXAS6zxnpaRY4wp2NmCZwTH2dkLZ5nXcqlVohklW58nUELvCZapM27X3HjtKUyo/HQwwFrung4Ieg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709326640; c=relaxed/simple; bh=h/GBE18pLAUMORJ25fqIx0baMYbv4QfcFqnkGA70pPA=; h=Message-ID:Date:Subject:To:References:From:In-Reply-To: Content-Type:MIME-Version; b=DiRmSdgg1SAryC5SAEUc58uyiYFKQGxYwWB2XniPsSdqDHxV99CS5OGiHcjjAHnwaW/N346lyZ8+m6vHv56pnG7atX2Y3XUk+eDoWn91XixjWhxhykPucAVe6QJVKYr1jQjTU6qh+7pPrHqXDusnCFofHQgWEEgNhxONEAU+RFk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=uVd7N91f; arc=fail smtp.client-ip=40.107.220.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Js0AOrkEUKjq5JbpUFdzpv/VvabTPpJyGpB2fRqXbv/sDWbURFoVR2/LZY7gbkzgxrtQuO6NR1MoNyHCmAxse6dzAr4VsjHqeen1B74YRFfslyHkDTFbJPYqCT9oPQVlE1wNLbMtq7phDWdvbtYua/Xq3ZW2XtJB3zl7DBaH/5jX0h4TmQudv9pOAsClpgR6YOkhxrq9l4Q+Sf4ENOugaaMDuPbDZeYlbL4e4LIoWoKxiykSHT2lmVr/f6ze6s+B4RxtoXEMT0uMRu3vS5e5ZSMG6YlgUm9Bg0cbEOWubjtc0MwbMPIQwhdDzIibkKedHiKdYEUNFPVae0W/e5D8fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TAyfhEUcScyUUQT3l8qULkSPFMMO+Cii9ExUn5uge+U=; b=b+v8L/+RBVljGG5eCXZy3aa8JjLkE8yCuUMyzkK7xRKSro7n4L/RgufZMLjA3uVvr8YL4lktt4furBqr1r31SgdYxRstyuxXZR2LvbCEg4OM6XyE0aJlRrw+16ZW83bCLCrgA9yPs93Z+gLwuqR12jdv4tacIOiTblZhuiuS2AjZSms6NNTpYkhfObf3yKhiVSkw2vL23Xz/e6yIlkoVM/NX//k3HnUzkkWP66IkjXTRMpWWPDW7LWmp2pg7A0mu2QHPzczGrnIQuwGHmvOC3beDLYdcopqZ1ygJ1erw3OGEIFuL+hx0PRMdNMQiBqsPOHvcuMPWwMls4vFVRCTyvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TAyfhEUcScyUUQT3l8qULkSPFMMO+Cii9ExUn5uge+U=; b=uVd7N91ftja8FPXwRfDkKndc0lhq7GwApCNcVu2Ixc+ztWpIQsK5a6fGsWgghIWfvfMHKcvt8PjXDVgvigVTSTS4dTrMpPrLKL6Xe0L24lwr4Npm3p7+3MNQxxUdBdFxTLQJBl8yv5zAnG6CLgeR7BQWNQf9404vE4pKapZXqC8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB4752.namprd12.prod.outlook.com (2603:10b6:805:e9::10) by BY5PR12MB4212.namprd12.prod.outlook.com (2603:10b6:a03:202::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.34; Fri, 1 Mar 2024 20:57:15 +0000 Received: from SN6PR12MB4752.namprd12.prod.outlook.com ([fe80::80ac:576:f125:1d72]) by SN6PR12MB4752.namprd12.prod.outlook.com ([fe80::80ac:576:f125:1d72%5]) with mapi id 15.20.7316.039; Fri, 1 Mar 2024 20:57:14 +0000 Message-ID: Date: Fri, 1 Mar 2024 14:57:13 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform Content-Language: en-US To: Andrew Jeffery , Supreeth Venkatesh , joel@jms.id.au, andrew@aj.id.au, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, robh+dt@kernel.org References: <20240110033543.799919-1-supreeth.venkatesh@amd.com> <572d53516dee6db5af7089090056185abb4e78c7.camel@codeconstruct.com.au> From: Supreeth Venkatesh In-Reply-To: <572d53516dee6db5af7089090056185abb4e78c7.camel@codeconstruct.com.au> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN6PR05CA0026.namprd05.prod.outlook.com (2603:10b6:805:de::39) To SN6PR12MB4752.namprd12.prod.outlook.com (2603:10b6:805:e9::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB4752:EE_|BY5PR12MB4212:EE_ X-MS-Office365-Filtering-Correlation-Id: 83955ed3-aa71-497e-8b74-08dc3a322c22 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w51nJHhKf+8ty0QJ6AYZ4QuVziiZRXK6DRzo4WT/mRBqzw5PqsQhaELyFR7tjf9ST96ls7PDhqpkQ/6BDZCU12iOcckT5aisjYI7lEOIBo3aZX2idUXDCRbclw8o22HVwjPoH04T6+XyDQ7fBCuS/LLtbsot7aY88br/9ZTwRwCFWtyaM/M9OBHt24Gucp2evGoNg41Z/1mr2NlXlJdWruvaTgNbH7btnmghIoEdZpt7HuZZnitpe4e3fs8GpOh3ssbTp+4RQxArD/IyDaiuNOZuJlXfm/7a1mJUUc7gG89h4SPtEk8bdlWWnGvi4sOWxOsA4s4nHNHgJecm0TEU6lWp37bJ85DBVchHFtvQ9/xDhoJQ7p6fzEO8asrigJx8RabpE0xROF1/dBCP8O55Mx25gJ4Ql6lQk/q0Yk+cNnCfXPhPREmAiAVwLooOVz2ga9gQxrGjpfw+4QtNmSiQn65m81E+A9hCy3S2REhFJh20qO42iw0r4VIw9sAwsWR8Haz2+UPOWo8vMXm4KmZyEpY7rDb1eMmXGh1bmtuS0hiGBTDOaa2mcCaX7a6446smaeJcwqQ5ubdp3iH+Tqc2yh0ZIEj/RbRAONtkWZL+RD2bkMHR9GmWvDLWmyJkFM5NE9TaQRrYSmjDFWRbcIiLKimwiysgZgYyFZlDglnb4VFkpzkjfnw37fZQbVzA3GsbYufk8YdOio0VdI3J+swfuA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB4752.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2VkWXY5QXV0SnZ2KzZ3N0szU1ZNYXY0ZDhCeVkyOGpmRWVVMStucW9vSDF0?= =?utf-8?B?ZWhUZFloYVYyRWRZNkNGa1RTMlpKN2V1Mkw1Y0dIeVAvdjZPQi84OFdmbjcx?= =?utf-8?B?RnBHRHlqWS9wUTV1eDhvaURyUjR2WGExbW9iNU5nRUN5OG5nN29rVDRKRnF3?= =?utf-8?B?QzBpMnBOSWpyZkNpb29DWU5kN0lRclNsbmE4Q1pqWFJoUlRPdTdGQXFRMVls?= =?utf-8?B?ZWV2UitMYmxGejdTWlkvUE5OajhObDFaV29UMloxWkl5NUd3MmE3YnRyOVRU?= =?utf-8?B?OXBYNjdjN1dqVkd1ejZTNFRraW54MDA5UytFNXcxMzlTTUNlRU9EV3hPbXVs?= =?utf-8?B?M1lwbmRHaFp2RHhteEJRRnh4Zkh0c3IrR045RGpLVnpxTDdubHBzNFROeXE0?= =?utf-8?B?eVdIQ1lYSXE5QTVTSENvQ0VKL1luR3gvbGZPdFBydXdwaHVHUzdLVXJGZy9x?= =?utf-8?B?d2FlU0N0YjlHb2FOMm9sVXlSbll4cWwxUDhPR3JtblJWdHBsSkJ3b0kwbFhF?= =?utf-8?B?SFQyeHFQMk40dUxxNUFKWWx4ZUdrNDRoU1NLZHdWOUhKM1lwWWxNbnFKODR1?= =?utf-8?B?bmcvdGE0YmxqYlZ1T0VtN3E5VXJidS9PVFNiSFA1RXJmdXpLQXlJNFNweHFV?= =?utf-8?B?MHUzdUZqcTRyUzBtUG9BVWpUV3cxNWczcm5za2RkYkI3dDFEKzRPNnJ3N3RH?= =?utf-8?B?d082OHlRcHJPYUdpQlpKb0U2SkhqOTZraUVKQ2prV2oxUGpPQ0xRUkNPLzY2?= =?utf-8?B?aVFpUXNqMkZBaXJPUUJKUTkrV1hUbFBjdmVKQkR5Rk56RFV5a2ZkV1BFNWJr?= =?utf-8?B?TzNjSHJ5VGxEdkpvNm93M1ZQeWRkZlBxQzd3MFhJd0ZDRnhTRnBWWG5ETW5C?= =?utf-8?B?dkRtQ2ZiaFE1UGZ1ZlMwMVRweU04dGtkZCtnYkFKWkIyV0d3NFhrT1ppeUE0?= =?utf-8?B?RlZla1QreWRaVTZObVZIVFJGV2NUdW5malBxMDZYdEt5aDZLZU9KdUVlczEw?= =?utf-8?B?UDc2S2FuNzU2YS9mTS9Damo3UDRBMTd6elhXZGlWQ1RUR0JvRmFkWm5BN1h1?= =?utf-8?B?ZlBzakNRWjBBblZlM0xNU0xMV1o4aWNDUk0yYk9ieWV1cW1ET2JoTk4xb1hH?= =?utf-8?B?UFJoR3VabU5TVDJwSmxuQ3RvaEhMYWFZSXNCK0pINzZRZC9IbVR0NFJNd2xM?= =?utf-8?B?S00rYlIrcnllZHZuM3JmMnkyRGtSTXhZclRLelY0WHBPY285eWNQaXA1T25w?= =?utf-8?B?aG5aVWNVTFp1S1VtOWVhekZNRWNxMU5xTzVJSjByajNhU2ViRnZlRnRpVk1l?= =?utf-8?B?NGtvTkxnaHVUZG5zT0pBanBVRTNYSHBWSWtvMmFTN3BxYTE1VWJnNy91NENu?= =?utf-8?B?RE9VYk40a2ppUTVySGxnbW84QWtqRy80dFh3WVlocFVVcmMyc1N0cHh4YWFz?= =?utf-8?B?OEhxWldaTG9sdWRSL1R2SXNETDZjQ1BlcWNRcnZFU2FDVGZmSW5kYW5weUFk?= =?utf-8?B?KytTRGRYMVhOVjFBMG5DUDFXajhCbmd5L0FjRmlROTUybjVTQWpHRy9IcVUx?= =?utf-8?B?ZjRieEdSMDZmZ1NwN3ZoZktTbmZ3aUNka1dhYW1CenlMWExheWJiRkt3UllQ?= =?utf-8?B?TjNtc00valh5ZjI4SnB3ZElqaVozRk1YTFhuMCtwVWhiSkJrSFlCMlhoSHla?= =?utf-8?B?ZzVYejBoYU9KN0JRTnJiQUlJeHdVdmZKN1loSHhzd1ErWlc0WTRaVlgwYmRz?= =?utf-8?B?Vm1pZFhST1ZYd3NpV2syMDd6KzBxRXU0U2V6NVlCYW5QY0ZOeGNRMUZBeTZm?= =?utf-8?B?TWxCMjR4dzh0RFlmRlJxMytRak1Sd2lsbkg3TFR6QWR1Z0RnNVU2R0dTZ3Z4?= =?utf-8?B?V0JvOGFXR2VMbEdQVTczUXdpZnd4RHkxY1g2ekZiSEk3cVZxZ1VxOE5PZ3pQ?= =?utf-8?B?OVVpNElkSlJEQWRYd2s1SzlxU3JXWHdtdmljalZJRGNXMHdtc2pQZDRCeisv?= =?utf-8?B?ekZVYVIwaTlLcWUxWGxjaC9PNUxJYS84eVRiaXRydGtFcE9TclU2eUFEejF5?= =?utf-8?B?SHNoS0o3ZVFlVmZSdGxtUjNpd2w4RlFveTY2Wmk2VzVja0gzN09IUVI4bjhX?= =?utf-8?Q?E2FV0T6rAaW+paWDnF5uiH8Bn?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83955ed3-aa71-497e-8b74-08dc3a322c22 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB4752.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 20:57:14.3891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7T+pn8wgmQHHF/6nhqwhK4ToiPa6XQScPOA4r88bKNETu9ii5QJWycUZ9XyYGmbEJNbQQkwnlOElSAuLWn8Ueg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4212 On 2/26/24 00:55, Andrew Jeffery wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > On Tue, 2024-01-09 at 21:35 -0600, Supreeth Venkatesh wrote: >> This patch adds initial device tree and makefile updates for >> AMD Onyx platform. >> >> AMD Onyx platform is an AMD customer reference board with an Aspeed >> ast2600 BMC manufactured by AMD. >> It describes I2c devices, Fans, Kcs devices, Uarts, Mac, LEDs, etc. >> present on AMD Onyx platform. >> >> Signed-off-by: Supreeth Venkatesh >> --- >> arch/arm/boot/dts/aspeed/Makefile | 1 + >> .../boot/dts/aspeed/aspeed-bmc-amd-onyx.dts | 98 +++++++++++++++++++ >> 2 files changed, 99 insertions(+) >> create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts >> >> diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile >> index fb9cc95f1b60..2b27d377aae2 100644 >> --- a/arch/arm/boot/dts/aspeed/Makefile >> +++ b/arch/arm/boot/dts/aspeed/Makefile >> @@ -5,6 +5,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >> aspeed-ast2600-evb.dtb \ >> aspeed-bmc-amd-daytonax.dtb \ >> aspeed-bmc-amd-ethanolx.dtb \ >> + aspeed-bmc-amd-onyx.dtb \ >> aspeed-bmc-ampere-mtjade.dtb \ >> aspeed-bmc-ampere-mtmitchell.dtb \ >> aspeed-bmc-arm-stardragon4800-rep2.dtb \ >> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts >> new file mode 100644 >> index 000000000000..a7056cd29553 >> --- /dev/null >> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts >> @@ -0,0 +1,98 @@ >> +// SPDX-License-Identifier: GPL-2.0+ >> +// Copyright (c) 2021 - 2024 AMD Inc. >> +// Author: Supreeth Venkatesh >> + >> +/dts-v1/; >> + >> +#include "aspeed-g6.dtsi" >> +#include >> + >> +/ { >> + model = "AMD Onyx BMC"; >> + compatible = "amd,onyx-bmc", "aspeed,ast2600"; >> + >> + aliases { >> + serial0 = &uart1; >> + serial4 = &uart5; >> + }; >> + >> + chosen { >> + stdout-path = &uart5; >> + bootargs = "console=ttyS4,115200 earlyprintk vmalloc=512MB"; > Why `vmalloc=512MB`? Can you add a comment explaining the need for > that? > > That said, setting bootargs in the devicetree is generally discouraged. > Thank you. will remove in v2. >> + }; >> + >> + memory@80000000 { >> + device_type = "memory"; >> + reg = <0x80000000 0x80000000>; >> + }; >> + >> +}; >> + >> +&mdio0 { >> + status = "okay"; >> + >> + ethphy0: ethernet-phy@0 { >> + compatible = "ethernet-phy-ieee802.3-c22"; >> + reg = <0>; >> + }; >> +}; >> + >> +&mac3 { >> + status = "okay"; >> + phy-mode = "rgmii"; >> + phy-handle = <ðphy0>; >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_rgmii4_default>; >> +}; >> + >> + >> + >> +&fmc { >> + status = "okay"; >> + flash@0 { >> + compatible = "jedec,spi-nor"; >> + status = "okay"; >> + #include "openbmc-flash-layout-128.dtsi" >> + }; >> +}; >> + >> +//Host Console >> +&uart1 { >> + status = "okay"; >> +}; > How are you managing the host console? Enabling UART1 for that on the > BMC piques my interest :) UART1 [BMC side] <-> UART 4 [Host side]. > > Apologies for the delay in reviewing. No problem. Thanks for reviewing. Sending v2 shortly. > > Andrew >