Received-SPF: pass (google.com: domain of linux-kernel+bounces-89163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 1 Mar 2024 13:49:50 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Ira Weiny <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	Jonathan Cameron <jonathan.cameron@huawei.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@amd.com>, Shiju Jose <shiju.jose@huawei.com>
CC: Dan Carpenter <dan.carpenter@linaro.org>, Yazen Ghannam
	<yazen.ghannam@amd.com>, Davidlohr Bueso <dave@stgolabs.net>, Dave Jiang
	<dave.jiang@intel.com>, Alison Schofield <alison.schofield@intel.com>,
	"Vishal Verma" <vishal.l.verma@intel.com>, Ard Biesheuvel <ardb@kernel.org>,
	<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH 3/4] cxl/pci: Register for and process CPER events
Message-ID: <65e24d7df3521_3651e29492@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240228-cxl-cper3-v1-0-6aa3f1343c6c@intel.com>
 <20240228-cxl-cper3-v1-3-6aa3f1343c6c@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240228-cxl-cper3-v1-3-6aa3f1343c6c@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E3nYE/mL61bX4DHX5a5FYBNmQSvsMW5FY5MCPEkgSKpVrWGdLxTFL1CGEFOg?=
 =?us-ascii?Q?i6HUPc6zkagOZ9uaQCS4ymdvShGUxedXBLqSslD+s/VdMGGmrvrS35D8/lSv?=
 =?us-ascii?Q?NcbWFb1eI22I8sqNah2tLDsk41znpBja6iwj/SqUovwI+0Z/2W7R0PagfDOF?=
 =?us-ascii?Q?ND8wbB6F1k4dGEyNavePBF5qMPxwcT85SLJHXOOvBcr41VN557719S6SfDOd?=
 =?us-ascii?Q?qTFTYtia/TRvuQtkuA89sYZFFmrhBSv8CjpFjlNmJLBrfUMZLZM4KHs1Vdo0?=
 =?us-ascii?Q?S4q/tHFNg4zC+KF72ebXQldJ3LQx3YJPwa0srM3YF+BQArf/iZy30Tn+Ntwx?=
 =?us-ascii?Q?Wl58mYAydkMdpRId4TqpoOIxbkjsflolbAkodOmfUbigiHoX/cApZ7w8dgca?=
 =?us-ascii?Q?QKWuW/T/qY+PcyvpCYyT96JqQ7DR8afc9btyL/He1ID1+MLYesvtas2EyM0C?=
 =?us-ascii?Q?K7XXQwsUJeMDCS7Lrp9CyyraOnJ1dPlxwMCTYrBjdx2aXlfBV8R5ZdZrv02q?=
 =?us-ascii?Q?rUTEah6CmYQT+EvdDnqFj8sECGYRW1WfEqWvhwmIEA7z11CQsaSz7AJGLjrh?=
 =?us-ascii?Q?VoDD1zf4IirzaV4R0ibPWj3Ygfv6ndMU/xdFnifo94IyyYp+yzG0R0+Z/f4n?=
 =?us-ascii?Q?NQkXuDD0dKUKE1nOIXHxGoSDJofDX2QgObpCeQAGdqg5/0R+8H+rjB+BZ/bk?=
 =?us-ascii?Q?3pGKe9meXNQnHBXGcJ5INJe4wDKOkX9bqOuaITq6dkvgeI6pXqNapswWFZvR?=
 =?us-ascii?Q?/+aH1KFMTcrtpyCR75r5ZWEFi5+oNgxeQC27zXGgQfBWj4KUGnBs+5qt7S8l?=
 =?us-ascii?Q?J679jZmYe+xiSBqz3nn5c4HRd0XtK22+fh0Jc05+MQzQBA8C5z42vNSN6XWF?=
 =?us-ascii?Q?8e6ajYRRxFHvrrO5T7w/sIM9zyEGPnCCONu1THPSBWkcwHLFJwBVr7hZyRlP?=
 =?us-ascii?Q?mbQEpuLobZOinkdG4QXT4UQF0y+m5G9GkbuygMDgEMzT3jK/A8c+swbJljte?=
 =?us-ascii?Q?6V0wSadqptd+gfDJu7c2leR4sW05hWpJ3AE3VxhZ2nK9CMygvrEuDMUnrfKV?=
 =?us-ascii?Q?y37hv+AxHs5YYzSv7gOQaIyVG/LAaZd1yBj7GmvynXasPW7oXnvFyX5EqBIr?=
 =?us-ascii?Q?qT7sSveb6GTNNf/8NDmTBph1n5BPMo5/cbFUvmbXcz0E5TMIM4INg3XKC1qf?=
 =?us-ascii?Q?6wQvluaq5vDR5alBPTOASHAUvTvGikeuKdZyG8CqF2kXubcgpFPKIX29PbJ4?=
 =?us-ascii?Q?bH8maWtDc570tTIOACLth6Y8P2ZvihrrHgNeNQqpFTewCKnNAQ9cTQU+Hcyw?=
 =?us-ascii?Q?6lZBjjEZ33Ide6w66/F42F9OazWUsMJfjr2GkIDgFse+kUMa3Q2H+ECJOnxA?=
 =?us-ascii?Q?Wii/Nu1TBbuON+bwnVKRq/6ivXDNlo9RohlDJ3k1BK0diCyzTzxXve6HhwUa?=
 =?us-ascii?Q?XuKZMWOm1Z/qgC0+hatiVWg6cxe44ITNhIvzvx5CrUYQAuajZDUsdPnjDBIB?=
 =?us-ascii?Q?1LH/20coLJMIX9HeLNFAxO0s98I6CMixe7mRID0Wwj5vRG76ZuUsElp1Y6ZI?=
 =?us-ascii?Q?tGhIkqIbPgHut0+WMVQ/Rk2uU7Q66yrSmUz2ETokpyJTD2nGdcST/29ryPUw?=
 =?us-ascii?Q?0A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: af7f0b0b-1dcd-48da-a1a0-08dc3a398703
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 21:49:53.3924
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5uLio9K/BnWyKEUQ8mrZ+9BgM4GxW9/wefv5/KyhI0Gzkl908l/ZWSFaeo+v86j8LtlehOWMKzljjqwuOhe722JPTU9KiHHzzVk1fzhA08U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5775
X-OriginatorOrg: intel.com

Ira Weiny wrote:
> If the firmware has configured CXL event support to be firmware first
> the OS can process those events through CPER records.  The CXL layer has
> unique DPA to HPA knowledge and standard event trace parsing in place.
> 
> CPER records contain Bus, Device, Function information which can be used
> to identify the PCI device which is sending the event.
> 
> Add a CXL CPER callback to process events through the CXL trace
> subsystem.
> 
> Future patches will provide additional region information such as HPA.
> 
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> ---
> Changes:
> [iweiny: Add back in after the revert in 6.8]
> ---
>  drivers/cxl/pci.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 68 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> index 2ff361e756d6..6cf8336d1b33 100644
> --- a/drivers/cxl/pci.c
> +++ b/drivers/cxl/pci.c
> @@ -974,6 +974,73 @@ static struct pci_driver cxl_pci_driver = {
>  	},
>  };
>  
> -module_pci_driver(cxl_pci_driver);
> +#define CXL_EVENT_HDR_FLAGS_REC_SEVERITY GENMASK(1, 0)
> +static void cxl_cper_event_call(enum cxl_event_type ev_type,
> +				struct cxl_cper_event_rec *rec)
> +{
> +	struct cper_cxl_event_devid *device_id = &rec->hdr.device_id;
> +	struct pci_dev *pdev __free(pci_dev_put) = NULL;
> +	enum cxl_event_log_type log_type;
> +	struct cxl_dev_state *cxlds;
> +	unsigned int devfn;
> +	u32 hdr_flags;
> +
> +	pr_debug("CPER event for device %u:%u:%u.%u\n",
> +		 device_id->segment_num, device_id->bus_num,
> +		 device_id->device_num, device_id->func_num);
> +
> +	devfn = PCI_DEVFN(device_id->device_num, device_id->func_num);
> +	pdev = pci_get_domain_bus_and_slot(device_id->segment_num,
> +					   device_id->bus_num, devfn);
> +	if (!pdev) {
> +		pr_err("CPER event device %u:%u:%u.%u not found\n",
> +			device_id->segment_num, device_id->bus_num,
> +			device_id->device_num, device_id->func_num);
> +		return;
> +	}
> +
> +	dev_dbg(&pdev->dev, "Found device %u:%u.%u\n", device_id->bus_num,
> +		device_id->device_num, device_id->func_num);

These print statements are excessive. The dev_dbg() already encodes the
device BDF into the device name. The pr_err() is not actionable and
somewhat redundant with the default cper_estatus_print_section() print.

I would just delete all of them.