Message-ID: <477D78BE.1060404@suse.de>
Date: Fri, 04 Jan 2008 09:07:26 +0900
From: Tejun Heo <teheo@suse.de>
User-Agent: Thunderbird 2.0.0.6 (X11/20070801)
MIME-Version: 1.0
To: Andrew Patterson <andrew.patterson@hp.com>
Cc: Greg KH <greg@kroah.com>, Andrew Morton <akpm@linux-foundation.org>,
       linux-kernel@vger.kernel.org, linux-hotplug@vger.kernel.org,
       bjorn.helgaas@hp.com
Subject: Re: Error returns not handled	correctly	by	sysfs.c:subsys_attr_store()
References: <1195683419.16019.225.camel@grinch>	 <20071126203116.0c93cdb9.akpm@linux-foundation.org>	 <20071127053321.GA975@kroah.com>  <474D1BD4.2050805@suse.de>	 <1196278300.5431.9.camel@grinch>  <474E10CF.7050009@suse.de>	 <1196716558.20124.179.camel@bluto.andrew> <1199404273.7025.21.camel@bluto.andrew>
In-Reply-To: <1199404273.7025.21.camel@bluto.andrew>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1976
Lines: 52

Hello,

Andrew Patterson wrote:
> It looks like this is a shell issue.  After looking through the sysfs
> code, I realized that this problem seems to be driven from user-land.
> So I performed some experiments:
> 
>      1. Wrote a simple program that just used write(2) to write to the
>         sysfs entry. This works fine.
>      2. Used /bin/echo instead of the built-in echo command.  This too
>         works fine.
>      3. Tried several shells.  Zsh and Bash both fail.  Csh works fine.
> 
> I then ran strace on the following shell-script:
> 
> #!/bin/bash
> 
> echo x > allow_restart
> echo y > allow_restart
> echo z > allow_restart
> 
> and got:
> 
> # strace -e trace=write ~/tmp/tester.sh 
> write(1, "x\n", 2)                      = -1 EINVAL (Invalid argument)
> write(1, "x\n", 2)                      = -1 EINVAL (Invalid argument)
> write(2, "/home/andrew/tmp/tester.sh: line"..., 72/home/andrew/tmp/tester.sh: line 4: echo: write error: Invalid argument
> ) = 72
> write(1, "x\ny\n", 4)                   = -1 EINVAL (Invalid argument)
> write(1, "x\ny\n", 4)                   = -1 EINVAL (Invalid argument)
> write(2, "/home/andrew/tmp/tester.sh: line"..., 72/home/andrew/tmp/tester.sh: line 5: echo: write error: Invalid argument
> ) = 72
> write(1, "x\ny\nz\n", 6)                = -1 EINVAL (Invalid argument)
> write(1, "x\ny\nz\n", 6)                = -1 EINVAL (Invalid argument)
> write(2, "/home/andrew/tmp/tester.sh: line"..., 72/home/andrew/tmp/tester.sh: line 6: echo: write error: Invalid argument
> ) = 72
> write(1, "x\ny\nz\n", 6x
> y
> z
> )                = 6
> Process 3800 detached

Eeeeeeeekkkk.... That's scary.  Which distro are you using and what does
'bash --version' say?

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/