Received-SPF: pass (google.com: domain of linux-kernel+bounces-89193-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 1 Mar 2024 14:19:50 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, Ira Weiny <ira.weiny@intel.com>,
	Jonathan Cameron <jonathan.cameron@huawei.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@amd.com>, Shiju Jose <shiju.jose@huawei.com>
CC: Dan Carpenter <dan.carpenter@linaro.org>, Yazen Ghannam
	<yazen.ghannam@amd.com>, Davidlohr Bueso <dave@stgolabs.net>, Dave Jiang
	<dave.jiang@intel.com>, Alison Schofield <alison.schofield@intel.com>,
	"Vishal Verma" <vishal.l.verma@intel.com>, Ard Biesheuvel <ardb@kernel.org>,
	<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, Ira Weiny <ira.weiny@intel.com>, "Rafael J.
 Wysocki" <rafael@kernel.org>, Tony Luck <tony.luck@intel.com>, "Borislav
 Petkov" <bp@alien8.de>
Subject: Re: [PATCH 4/4] ras/events: Trace CXL CPER events even without the
 CXL stack loaded
Message-ID: <65e25486de5ea_31513a29492@iweiny-mobl.notmuch>
References: <20240228-cxl-cper3-v1-0-6aa3f1343c6c@intel.com>
 <20240228-cxl-cper3-v1-4-6aa3f1343c6c@intel.com>
 <65e24fda80e44_3651e29440@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <65e24fda80e44_3651e29440@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gbC0XlqxVjfXFSST6UqmSUYlrieMypIjO+lY9OxTqjEDc1i9kKVxoetdIhbF?=
 =?us-ascii?Q?0aKu2wLpK2DYKVrApnTOLJBFpd+GE/JiLxy0xv8ekR+iKCJj0LRMoeDIznOu?=
 =?us-ascii?Q?U9pPn2xHXcDs1yOl8Tf7uWxxTBmY3ZwdXMNCflEyYm/ym+fXZr10sPhD91sY?=
 =?us-ascii?Q?kxud45Zju1bmJG4F0lWmncmkl/ecBRNoNlGE7WZVgr8E4+AuxHKYOcAzfyOj?=
 =?us-ascii?Q?CsgnQCGYBHmWj0W4wcCNM/jw33ND5DZfNwdTiUhAL62DtY+uDEK0slHQn1TN?=
 =?us-ascii?Q?RyaPm+6LHhUpR8W8jkLZ+INbpViw1+zkjDSMfqhgfpTQ2BSjRZkZW/4RFB3W?=
 =?us-ascii?Q?l52R0Wp1fdNff/+f0LF4naSF3PEd7sFbdrnJVnVziRvUkmAFS9Vruqoc1Fy4?=
 =?us-ascii?Q?MuxAJQdtNSgawP4/LuWCAuyroqqkHRrHVGYqe7dOMDSHmiCysx6FvOk4lp++?=
 =?us-ascii?Q?tbfLkk2SfXAAbb1fVG9xT+aL3HKwZqokhODyTFNfDXiMEnbmyet6ppld1rIz?=
 =?us-ascii?Q?OeodnA6E/B4EdipxLkDpKX3uJnibEya6WUnMmfC8+pgdl0GUeSovQE2Z59Fq?=
 =?us-ascii?Q?vyn8wKonTe02JwjLozp9fIqUtDEedMGm4iIjpC9dq3g8uiC6G6gVWJZ19g/f?=
 =?us-ascii?Q?z3a6flBSVxaO+Mzb7pAzNM9381+wySeKXT1uEOwIIFo9+9GLMpJPkh9lWGhu?=
 =?us-ascii?Q?uWD5oAkBT6h+qVIaw6Gd+P4t0Xm3dsqrdsn4Y6qnj6SpTti2msSZy93dYgXf?=
 =?us-ascii?Q?LlDRM8eQe5kTfPWmzr9Upj8SIfTQtN/lZIiyIQyCKisM+Lol3OgOUxVglvTo?=
 =?us-ascii?Q?M/2jXbes438B6yGpcaasAb1JWrXVbNXBT4Cvy/LF5OJnW2Mhm4moCwjH9TIa?=
 =?us-ascii?Q?/VCTIX6vkQhqTaU4XjprsvKOdzX08p7upRCAQx9RhF2pKTFyKCJRNZNsKiCt?=
 =?us-ascii?Q?0owxJ8sMj+MQemUSSgETtKANrI74w6jzhLBYyD7jBkMIYelaKrsizJNN1C2r?=
 =?us-ascii?Q?ePcQyeG+81LIaOjjEHb5Dlk3CNWYtgUGn5TN58lNZYLZ+ZEFF2pfJECwCtiL?=
 =?us-ascii?Q?vCGxBuexPKx+2YA/E8mDY+r8aAVuj5aqrfACYWMsWzYQ5WuC1obn0uY69klT?=
 =?us-ascii?Q?b3PtxqUGfNfdZu6mLwDtjn9pbZHSF1/8zpsBvCf6BssCf1N6AxpwVA3p+24F?=
 =?us-ascii?Q?KI0MOdcb8WzOh5k8XrUXodzV2S49E+EXR7++y6MJccpopqegaENU4NGpdJz5?=
 =?us-ascii?Q?7waIpuGOXY90+NwSssWBbv4wCMpzWTTUWe2/Xo5uY+IN4Kk1XUxABaa+hIGT?=
 =?us-ascii?Q?Rz8ABZFNmZN8J21peXN+JOG9ly3yZTZRNiFrq5ppc6kDY1KGZp2KHz235HY8?=
 =?us-ascii?Q?fhI0cHCIaimjJUpyOCmORUbHuvTUymPLiYx5VXyHxLttjcywv8WY6iryIHrx?=
 =?us-ascii?Q?V5+nEwGjdLqNhf1c84rvATV+x31o/8L81b2r/GhDvsJEvD9O2SlrpLMyS+dd?=
 =?us-ascii?Q?toSEOYq4kr7rOlpL031jeHsdH73EcSwHFj3ZGs6qUdKHqyezH0+sinFXk9tO?=
 =?us-ascii?Q?uf8ghx0sZojo+ZJHa1QfmJ9LOv4a4MWO9Oqc7Dzi?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4032f2e1-c089-4cd5-4e94-08dc3a3db8dd
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 22:19:55.0309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y1HfUUn96adwSqyMqjkx8GVjUBcz2zl9JAbr17YVbUrg6kNc+ZL1gTXZ+kvw0lhrM6R7OFVnoEMUPXiDjS4C8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7013
X-OriginatorOrg: intel.com

Dan Williams wrote:
> Ira Weiny wrote:
> > 
> > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > index f433f4eae888..9ac323cbf195 100644
> > --- a/drivers/acpi/apei/ghes.c
> > +++ b/drivers/acpi/apei/ghes.c
> > @@ -729,7 +729,10 @@ static void cxl_cper_local_fn(struct work_struct *work)
> >  
> >  	while (kfifo_out_spinlocked(&cxl_cper_fifo, &wd, 1,
> >  			&cxl_cper_read_lock)) {
> > -		/* drop msg */
> > +		struct cxl_cper_event_rec *rec = &wd.rec;
> > +		union cxl_event *evt = &rec->event;
> > +
> > +		trace_cper_cxl_gen_event(rec, &evt->generic);
> 
> So it was confusing to read the empty stub function 2 patches back when this
> change was coming, and basic reporting of CXL event does not need the
> workqueue indirection. Note that EDAC triggers trace events directly in
> the atomic notifier chain, so CXL could do the same.
> 
> >  static DECLARE_WORK(cxl_local_work, cxl_cper_local_fn);
> > diff --git a/include/ras/ras_event.h b/include/ras/ras_event.h
> > index cbd3ddd7c33d..319faf552b65 100644
> > --- a/include/ras/ras_event.h
> > +++ b/include/ras/ras_event.h
> 
> This is more heavywieght than I was expecting and defeats the purpose of
> centralizing advanced decode in the CXL driver itself.

Fair enough but it is not that heavy IMO.  It was mostly lifted from the
CXL traces.

> 
> I would expect this to be just the tracing equivalent of the
> ignore_section logic in cper_estatus_print_section().

I think it is fair to give the user some information.  I'll redo this
patch to be first and drop the extra work item.

Ira