Received-SPF: pass (google.com: domain of linux-kernel+bounces-89207-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <44f00418-b09b-5ee5-c70c-d4580ffd0049@quicinc.com>
Date: Fri, 1 Mar 2024 14:47:59 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH] usb: dwc3: core: Add DWC31 version 2.00a controller
Content-Language: en-US
To: Greg KH <gregkh@linuxfoundation.org>
CC: <Thinh.Nguyen@synopsys.com>, <linux-kernel@vger.kernel.org>,
        <linux-usb@vger.kernel.org>
References: <20240301213554.7850-1-quic_wcheng@quicinc.com>
 <2024030121-unfold-murky-aae1@gregkh>
From: Wesley Cheng <quic_wcheng@quicinc.com>
In-Reply-To: <2024030121-unfold-murky-aae1@gregkh>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi Greg,

On 3/1/2024 1:45 PM, Greg KH wrote:
> On Fri, Mar 01, 2024 at 01:35:54PM -0800, Wesley Cheng wrote:
>> Add revision value for identifying DWC31 version 2.00a based controllers.
>>
>> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
>> ---
>>   drivers/usb/dwc3/core.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index df544ec730d2..f3bbbc1947bd 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -1259,6 +1259,7 @@ struct dwc3 {
>>   #define DWC31_REVISION_170A	0x3137302a
>>   #define DWC31_REVISION_180A	0x3138302a
>>   #define DWC31_REVISION_190A	0x3139302a
>> +#define DWC31_REVISION_200A	0x3230302a
> 
> What code uses this define?
> 

Don't think there is anything within the DWC3 core that would be 
different specifically for 2.00a versus previous revisions. (so far)

> Why add a define that is not used?
> 

There is a running list of all the DWC3 revisions.  Not all of them are 
being used, so my understanding was that we're just keeping track of all 
possible version values that can be read from the DWC3 version HW 
register.  If this is the not the case, maybe we can just leave this out 
until we find a need to add it.

Thanks
Wesley Cheng