Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp624366lqg; Fri, 1 Mar 2024 16:17:31 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUPp00Mrw1bgn3fv1ybmww+TK7/1xWS0E7CU4kj0K0OlT3R8LIkjLO/9dQ7bRZ+fXPq3d7TdvMX2Nfz/jpn5aPJX4LKu0GK779195b1mQ== X-Google-Smtp-Source: AGHT+IEltxLY8ignMIgNEuJMGvQkauW2LHY/SSwTsIC3EZk+ivvgVbkK7KNw06WqG4Sk/KCoPqN/ X-Received: by 2002:a17:90a:f495:b0:29a:98ad:61d4 with SMTP id bx21-20020a17090af49500b0029a98ad61d4mr2949773pjb.33.1709338651149; Fri, 01 Mar 2024 16:17:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709338651; cv=pass; d=google.com; s=arc-20160816; b=fPm3R7L069QhflqWUBIId5opvMrO3yTGZ6abdm6EQAt5x+n0ZuuVU5Cx5aZU2rj0Fe AjqsQ+uM97t/2O22Hg/0oEmmK/+6KUBInWxl9FYiPFtbK4lhlFTEZmT87Vq/ZI6if3kp NJGoht52MR7V5x5nyI2DhdG77UpqKXjoVktzBkWJ65S0Nj2XByTKAAqZ7AGTC8tahO87 fw/p1QPK5CbXNMOimNoZOg5QZgP1mX574syh+4RirDUmOLB/pceRpertAaoD3WsfIinj lnZ7rPz38wNwH5p2JmOIqC3POEN7CcAobPmJEZbzayCIb6zYHhvP2z5Tm4/2jXePACG0 96IQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=e1sMeEwV6zrYXOM9M9z2DLs2bzRRRslBRFpB8ITBido=; fh=LKv7/ECdWOvQ8HRyO3fxFfve947qkEq8wuprEhmK6uY=; b=qOMCGMsijaFzWJKi5yhhSb6ZRMHlybWGesyO8JCbp3JxUP4Q9tuhyLcwjOXfUIeYMF 80CeYgJvwmsBzYLlrmhvfXBNZNxAjBoEflPxhElJgbeXMe5o33NvWqICnR0WCm6TGFoE GOsLgtf/+yqJh+9XtLRLEyetS3rq5DqdAuycyDqi+BqMNx8oqAx6lq+LpN4iPhLW//wN mGGPnXN5seA5/CNstxm1rXj3Bvf8pmdO4qjGW+jkgKdAOzDQ4FJ6P9EGaPt6e2/txR1N NZNbWGahAMYbN5zvGiHteholgoTMOqg5qljWd5phxNKILi/cXj24+HjyTQsMqGLlkX2O rXvQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LVVn7fb3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-89257-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89257-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id pl5-20020a17090b268500b0029b26e8d2a5si1958875pjb.104.2024.03.01.16.17.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 16:17:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89257-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LVVn7fb3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-89257-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89257-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DE67428291D for ; Sat, 2 Mar 2024 00:17:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ED6F37462; Sat, 2 Mar 2024 00:16:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LVVn7fb3" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1593417F3; Sat, 2 Mar 2024 00:16:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709338582; cv=none; b=MBeZhQgxLLzJOaUuI+bkp7jjT87OLBIfbxeHpjbiKJhRFFYPL2vOUWFz/w9JKJp/LXbeKIhVAp9tEin+JInJlPgdiPopSbHkbFyywjT8pk14mtIzWgP7sZf5E2J7Ek3lvIJuh+nAG6sl2NTkqhlIOpAgEGSlxK8IKVq5OIMcCYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709338582; c=relaxed/simple; bh=e1sMeEwV6zrYXOM9M9z2DLs2bzRRRslBRFpB8ITBido=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ARSUtlDT/RfVailIwwfG8UkPAwdXAubc1s3jLNjs1uGX0PSMJ8JnbYq+3bl1rpOsKdq+skkbBc7nFupcBv40xkPPOUlHSxRQT+jjUINGJNGYpVqsVMpYF3SnGAR9fMsqE+6eGAiGZ10wmZWsww4KP/wMbNRleN7AX/FbmMLyWSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LVVn7fb3; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACCDAC433C7; Sat, 2 Mar 2024 00:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709338581; bh=e1sMeEwV6zrYXOM9M9z2DLs2bzRRRslBRFpB8ITBido=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LVVn7fb3930ZHmaDmxv3Z6Vd1Bo6TsmqTBJ2N8WWx5XosEAqJOZsWs7pvpzXZAare qNwwz9Ap7rlKVE8uNFDfs6gHYzMF7S09S8JJcfLt0bBnZAjPofIifVHuXwa3rDRm/1 xSh/Tan9At8mFSFKjF1qjjMpGj2F4PNcwcmNS2qIW3ai/YEHqgJnpgD7B2XsyCg9uY XDDZMHBTtvXUwXztcg1L8XDBt6s+50ybSfSHdMbyho2gvwu8xHN6qUlkKBi99K0Fiy Isb0PIg7EMX92l3yLvxYEdkG3a0sg5kqAdc7YQUZq4ccPgrG1Q7pMeHxfM9VJ3zd7E lzvA/lcYr/sag== Date: Sat, 2 Mar 2024 01:16:16 +0100 From: Andi Shyti To: =?utf-8?B?VGjDqW8=?= Lebrun Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Gregory Clement , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk , Andi Shyti Subject: Re: [SPAM] [PATCH v2 03/11] i2c: nomadik: rename private struct pointers from dev to priv Message-ID: References: <20240229-mbly-i2c-v2-0-b32ed18c098c@bootlin.com> <20240229-mbly-i2c-v2-3-b32ed18c098c@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240229-mbly-i2c-v2-3-b32ed18c098c@bootlin.com> Hi Theo, On Thu, Feb 29, 2024 at 07:10:51PM +0100, Th?o Lebrun wrote: > Disambiguate the usage of dev as a variable name; it is usually best to > keep it reserved for struct device pointers. Avoid having multiple > names for the same struct pointer (previously: dev, nmk, nmk_i2c). just a nitpick here: this patch does also some small style fixes. Could you please mention them in the commit log in your v3? > Reviewed-by: Linus Walleij > Signed-off-by: Th?o Lebrun In any case, Reviewed-by: Andi Shyti Thanks, Andi