Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp631456lqg; Fri, 1 Mar 2024 16:39:53 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVVeBkAvhE2DrpVfnWY4GP4cvQoKq/octHHyMw9jHHHCEZkOC0ngOABALBt0tk9hYcMs4zlk1EI8PlFhDIqnVH5rlfEwJvOZaDJAdKFNQ== X-Google-Smtp-Source: AGHT+IHVP8iN5Rz5W8UZg75SEMXPiyWYiKDjxAS8IDZCPP5cXVNbaPTI+3S5EPoHJEJAesjrvMrM X-Received: by 2002:a05:6870:1485:b0:220:971:ab2e with SMTP id k5-20020a056870148500b002200971ab2emr3303025oab.41.1709339993504; Fri, 01 Mar 2024 16:39:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709339993; cv=pass; d=google.com; s=arc-20160816; b=JkOrUNAx5KbtFBgytJqYdJqzOGovjITEYZRaE8Rzm4EApEEaKvWYjRv1WDbIqJSRKD CxoDWuRuA4Gh95UsCiDfhBwtRT+TLoVJW9Jh2JY3JGJpZk8/DD4oEOJo0sRCKUewWEZb IKQNjcuchuTCI7wYCHg3PBOn5PZ+AcQbSdt/zkdzPHEuGbyVt0RGv46qhA91IIJ5p4hO iNxCc7MDGkji0DzHc7C71kkgiFId6CckWqZw1v62JPRsuSWK5QYr3D2v+j8AzHTSqGJu D8+ieUuZ8WxfjLaZA9qn++ClI/iGCDyXUrQFAQYzkBSiCtyYDUiwIARCxDbK8nCQrm6j 9gTQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jyKjPvT/EkJla/5n/qmQEJ23pdly8CYhhVUOSg4aClA=; fh=LKv7/ECdWOvQ8HRyO3fxFfve947qkEq8wuprEhmK6uY=; b=VgthJaTU4fAD/6isRDPMHqAid73K3emFoOI4+i8tpNMqkbf1XvwBJmNV55QMzyccqy lCEyChGq402AADg4vg/iqTgjQT+SeGVR7JBpkWb/LJBU2Hs3GHFKxOEHkV4dkprpNltA CgSkbTPA5L/rzORn2jccCqO74Wc4waUiWRHVmdbmR7BT4IbOqO14vx/9OGp5THPatiQ5 j0xvzn9sMjIHn3h1Ts6AKH/rR6zvsLx4JyBOBI1g2MVCj0mTgE1EpDNVQAZsOtQGlwQ4 9rvWf/eKWoGe4F7fKA0dy/1tfN8YXfU8TpK5uLNn8NR586o26TQFmXYWaz1C/Iy2vZhb nydA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fiFmYhpZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-89265-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89265-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id a10-20020a05622a064a00b0042c2fcc55ebsi5031220qtb.24.2024.03.01.16.39.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 16:39:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89265-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fiFmYhpZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-89265-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89265-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3DE911C20DEB for ; Sat, 2 Mar 2024 00:39:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7271E33F7; Sat, 2 Mar 2024 00:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fiFmYhpZ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 878F180C; Sat, 2 Mar 2024 00:39:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709339984; cv=none; b=RTV+IXxFKyI5LG9LnYzoNS1t7kgOBYfMDYKvwf9QYsGFsf/RTfHsHngL5ZA+Jpfc7JrT8CKHUsWI2ZKx2rjk6hiaZ1+jsZ27SeKWUUfaXEWMB8Hc6CalcNdAuhh4CS+ezBt0owgu7WFiB7jUamdAhCtOW8MquA4lg3GKo76LLvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709339984; c=relaxed/simple; bh=jyKjPvT/EkJla/5n/qmQEJ23pdly8CYhhVUOSg4aClA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QhzKBnqVqsyo+8ymkBTUaE4va7n3EWWnCiP4pa4d/nHpWGc/hJf67cvpyv9QVjFHJ4tCetWZV/yYkD1V0mroGeZwYtJJYpRf9BC+Brw7WKEIof+3TDx9qgXW/3CH/MroEWeS7ryjcbuFWnWAV2dkuMu9sSl3QcHSDGgrvtj+dmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fiFmYhpZ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C75DC433F1; Sat, 2 Mar 2024 00:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709339984; bh=jyKjPvT/EkJla/5n/qmQEJ23pdly8CYhhVUOSg4aClA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fiFmYhpZjNSKGHgK13j3O4ixxb1b/aST6+7AGT/EFIPL2Ktp/CQqdvZOzfixrMiNw NYS1h5hVOUnPnpJEt4x+7Wgr3R9/3JoZj8jTNqXWMuOwGP2x7pVPnsgA1EprtCSUTE FY/jb0yFSeh/+lDBQKbMZrohKTrl9wmurE4lP0hTAAgBQInK4eE5r8LoQzp4B/e9A0 XVR6C8Y+gN/rlcLnCg+45mlhIEBR2DaBPuhOsu/Ji4o6oWgNamMx7rba9RPQj/hedY TRzHgYJc14r4p1OyZQufKX5Xr8qAonCx1J3GRnzL1VkMbF2hat9wn3a18y8ODcmVOY lHncka/Hr5m8w== Date: Sat, 2 Mar 2024 01:39:39 +0100 From: Andi Shyti To: =?utf-8?B?VGjDqW8=?= Lebrun Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Gregory Clement , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk , Andi Shyti Subject: Re: [SPAM] [PATCH v2 04/11] i2c: nomadik: simplify IRQ masking logic Message-ID: References: <20240229-mbly-i2c-v2-0-b32ed18c098c@bootlin.com> <20240229-mbly-i2c-v2-4-b32ed18c098c@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240229-mbly-i2c-v2-4-b32ed18c098c@bootlin.com> Hi Theo, On Thu, Feb 29, 2024 at 07:10:52PM +0100, Th?o Lebrun wrote: > IRQ_MASK and I2C_CLEAR_ALL_INTS are redundant. One masks the top three if I2C_CLEAR_ALL_INTS is redundant why don't you remove it? > bits off as reserved, the other one masks the reserved IRQs inside the > u32. Get rid of IRQ_MASK and only use the most restrictive mask. Why is IRQ_MASK redundant? What happens if you write in the reserved bits? Can you please explain a bit better the change you did? Thanks, Andi > Reviewed-by: Linus Walleij > Signed-off-by: Th?o Lebrun