Received-SPF: pass (google.com: domain of linux-kernel+bounces-89364-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sat, 2 Mar 2024 00:04:52 -0800
From: Saeed Mahameed <saeed@kernel.org>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Leon Romanovsky <leonro@nvidia.com>,
	Jason Gunthorpe <jgg@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
	Leonid Bloch <lbloch@nvidia.com>, Itay Avraham <itayavr@nvidia.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Saeed Mahameed <saeedm@nvidia.com>,
	David Ahern <dsahern@kernel.org>,
	Aron Silverton <aron.silverton@oracle.com>,
	Christoph Hellwig <hch@infradead.org>,
	andrew.gospodarek@broadcom.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 2/5] misc: mlx5ctl: Add mlx5ctl misc driver
Message-ID: <ZeLdpNGXqkDlU3MU@x130>
References: <20240207072435.14182-1-saeed@kernel.org>
 <20240207072435.14182-3-saeed@kernel.org>
 <14aca96c-7525-486c-8f7c-accaddd41456@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <14aca96c-7525-486c-8f7c-accaddd41456@oracle.com>

On 29 Feb 12:44, Vegard Nossum wrote:
>
>On 07/02/2024 08:24, Saeed Mahameed wrote:
>>+static int mlx5ctl_open(struct inode *inode, struct file *file)
>>+{
>>+	struct mlx5_core_dev *mdev;
>>+	struct mlx5ctl_dev *mcdev;
>>+	struct mlx5ctl_fd *mfd;
>>+	int err = 0;
>>+
>>+	mcdev = container_of(file->private_data, struct mlx5ctl_dev, miscdev);
>>+	mcdev_get(mcdev);
>>+	down_read(&mcdev->rw_lock);
>>+	mdev = mcdev->mdev;
>>+	if (!mdev) {
>>+		err = -ENODEV;
>>+		goto unlock;
>>+	}
>>+
>>+	mfd = kzalloc(sizeof(*mfd), GFP_KERNEL_ACCOUNT);
>>+	if (!mfd)
>>+		return -ENOMEM;
>
>goto unlock?
>
>Or why not reorder so you always allocate this before doing anything else?

Good catch !, thanks I will reorder.